Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Deprecation] SharedArrayBuffer will require cross-origin isolation as of M91, around May 2021 #21708

Closed
abzr1 opened this issue Jan 31, 2021 · 11 comments
Closed

[Deprecation] SharedArrayBuffer will require cross-origin isolation as of M91, around May 2021 #21708

abzr1 opened this issue Jan 31, 2021 · 11 comments
Labels
bug Issue was opened via the bug report template.

Comments

@abzr1
Copy link
Contributor

abzr1 commented Jan 31, 2021 •
edited

What version of Next.js are you using?

10.0.5

What version of Node.js are you using?

14.15.0

What browser are you using?

Google Chrome Version 90.0.4400.8 (Official Build) dev (64-bit)

What operating system are you using?

Windows 10

How are you deploying your application?

npm run dev (npx next dev)

Describe the Bug

I get this warning in the console:

scheduler.development.js:298 [Deprecation] SharedArrayBuffer will require cross-origin isolation as of M91, around May 2021. See https://developer.chrome.com/blog/enabling-shared-array-buffer/ for more details.

console warning

Expected Behavior

No warnings in the console

To Reproduce

Run npm run dev or npx next dev in the terminal in a Next.js project.
@abzr1 abzr1 added the bug Issue was opened via the bug report template. label Jan 31, 2021
@ploxx95

This comment has been minimized.

Sign in to view
@abzr1 abzr1 changed the title [Deprecation] SharedArrayBuffer will require cross-origin isolation as of M91, around May 2021. [Deprecation] SharedArrayBuffer will require cross-origin isolation as of M91, around May 2021 Feb 4, 2021
@achrizal15

This comment has been minimized.

Sign in to view
@agektmr
Copy link
Contributor

agektmr commented Mar 8, 2021

I'm not entirely sure how next.js works, but since it has dependency with React, this issue might be related: facebook/react#20829

@timneutkens
Copy link
Member

Yep this is coming from React and has already been fixed (as linked above).

@gaearon
Copy link

gaearon commented Mar 22, 2021

17.0.2 is out with the fix. (But there was no real problem, it's a false positive.)

@iDVB
Copy link

iDVB commented Apr 8, 2021

@gaearon

17.0.2 is out with the fix. (But there was no real problem, it's a false positive.)

We are still seeing this error with 17.0.2 for react and react-dom. We've also restarted the dev server.

@gaearon
Copy link

gaearon commented Apr 8, 2021

It does not contain that code so something’s wrong on your side. Check where the log is coming from and manually inspect how that gets pulled into your bundle.

@baileymckay
Copy link

I'm still getting this too.

react and react-dom are both on 17.0.2. I'm using next.js (11.0.1--latest), so it could be some build artifact. newSharedArrayBuffer appears twice in the next.js build file, though the one Chrome flags (I assume the first instance) seems to be coming from node_modules/util.

I know it's just a warning and it's nothing to worry about. I'm just tryin to figure out how it's still in the build. I cleared the cache, restarted the server, restarted my computer... The console warning is also appearing in my prod app.

Screen Shot 2021-07-18 at 10 17 33 PM

Screen Shot 2021-07-18 at 10 14 55 PM

@btahir
Copy link

btahir commented Aug 7, 2021

I'm still getting this too.

react and react-dom are both on 17.0.2. I'm using next.js (11.0.1--latest), so it could be some build artifact. newSharedArrayBuffer appears twice in the next.js build file, though the one Chrome flags (I assume the first instance) seems to be coming from node_modules/util.

I know it's just a warning and it's nothing to worry about. I'm just tryin to figure out how it's still in the build. I cleared the cache, restarted the server, restarted my computer... The console warning is also appearing in my prod app.

Screen Shot 2021-07-18 at 10 17 33 PM Screen Shot 2021-07-18 at 10 14 55 PM

I'm still getting error as well (on React 17.02). Anybody found a workaround?

agektmr added a commit to agektmr/commonjs-assert that referenced this issue Aug 11, 2021
@agektmr
Update util to 0.12.4
c369d9b 
Chrome 92 started to disable `SharedArrayBuffer` without cross-origin isolation which can be enabled by [sending the page with special HTTP headers](https://web.dev/cross-origin-isolation-guide/). This change causes Chrome to emit a warning in DevTools console and [developers are confused with the message](vercel/next.js#21708). `util` is one of the libraries that uses `SharedArrayBuffer` and is causing the warning to appear in the console.

Luckily, the issue in `util` has been resolved in v0.12.4 and I would like to propose applying the fixed version to this library.
@agektmr agektmr mentioned this issue Aug 11, 2021
Closed
@agektmr
Copy link
Contributor

agektmr commented Aug 11, 2021

Apparently util itself has solved the issue in v0.12.4, but multi-level dependencies are causing this issue. The followings are the libraries that depends on util:

  • node-libs-browser@2.2.1
  • assert@1.5.0
  • assert@2.0.0

I've sent a pull request to fix the issue in assert.

agektmr added a commit to agektmr/next.js that referenced this issue Aug 11, 2021
@agektmr
Update util to 0.12.4
419848c 
Chrome 92 started to disable `SharedArrayBuffer` without cross-origin isolation which can be enabled by sending [the page with special HTTP headers](https://web.dev/cross-origin-isolation-guide/). This change causes Chrome to emit a warning in DevTools console and [developers are confused with the message](vercel#21708). `util` is one of the libraries that uses `SharedArrayBuffer` and is causing the warning to appear in the console.

Luckily, the issue in `util` has been resolved in [v0.12.4] and I would like to propose applying the fixed version to this library.

For fixing vercel#21708
@agektmr agektmr mentioned this issue Aug 11, 2021
Merged
10 tasks
kodiakhq bot pushed a commit that referenced this issue Aug 14, 2021
@agektmr
Update util to 0.12.4 (#27939)
73b5d69 
Chrome 92 started to disable `SharedArrayBuffer` without cross-origin isolation which can be enabled by sending [the page with special HTTP headers](https://web.dev/cross-origin-isolation-guide/). This change causes Chrome to emit a warning in DevTools console and [developers are confused with the message](#21708). `util` is one of the libraries that uses `SharedArrayBuffer` and is causing the warning to appear in the console.

Luckily, the issue in `util` has been resolved in [v0.12.4] and I would like to propose applying the fixed version to this library.

For fixing #21708



## Bug

- [x] Related issues linked using `fixes #number`
- [ ] Integration tests added
- [ ] Errors have helpful link attached, see `contributing.md`

## Feature

- [ ] Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR.
- [ ] Related issues linked using `fixes #number`
- [ ] Integration tests added
- [ ] Documentation added
- [ ] Telemetry added. In case of a feature if it's used or not.
- [ ] Errors have helpful link attached, see `contributing.md`

## Documentation / Examples

- [ ] Make sure the linting passes
@balazsorban44
Copy link
Member

This issue has been automatically locked due to no recent activity. If you are running into a similar issue, please create a new issue with the steps to reproduce. Thank you.

@vercel vercel locked as resolved and limited conversation to collaborators Jan 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
bug Issue was opened via the bug report template.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
10 participants
@iDVB @agektmr @gaearon @timneutkens @btahir @balazsorban44 @abzr1 @baileymckay @ploxx95 @achrizal15