Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Playwright example #29426

Merged
merged 5 commits into from Nov 14, 2021
Merged

Add Playwright example #29426

merged 5 commits into from Nov 14, 2021

Conversation

mxschmitt
Copy link
Contributor

@mxschmitt mxschmitt commented Sep 27, 2021

Playwright can be used for writing end-to-end tests across Chromium, Firefox, and WebKit which is supported on all the platforms.

I'll follow up by adding it to the testing.md section: #29832

Documentation / Examples

  • Make sure the linting passes

@ijjk ijjk added the examples Issue/PR related to examples label Sep 27, 2021
kodiakhq bot pushed a commit that referenced this pull request Oct 12, 2021
@mxschmitt
Copy link
Contributor Author

We should not forget about this one, otherwise the example in the docs is not working.

cc @timneutkens
cc @molebox

Thank you!

@benrobot
Copy link

I don't know how long these PR usually take to get reviewed and merged but I couldn't wait to start using this example so I went ahead and ran the following command instead:

npx create-next-app --example https://github.com/mxschmitt/next.js/tree/add-playwright/examples/with-playwright with-playwright-app

@benrobot
Copy link

I believe this pull request will fix the broken link currently live at https://nextjs.org/docs/testing

image

@leerob leerob merged commit b7f8025 into vercel:canary Nov 14, 2021
@vercel vercel locked as resolved and limited conversation to collaborators Jan 27, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
examples Issue/PR related to examples
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants