Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(testing): added Playwright guide #29832

Merged
merged 5 commits into from
Oct 12, 2021

Conversation

mxschmitt
Copy link
Contributor

Blocked by #29426

aslushnikov
aslushnikov previously approved these changes Oct 11, 2021
docs/testing.md Outdated Show resolved Hide resolved
docs/testing.md Outdated Show resolved Hide resolved
Co-authored-by: Andrey Lushnikov <aslushnikov@gmail.com>
@mxschmitt mxschmitt marked this pull request as ready for review October 11, 2021 22:52
@molebox
Copy link
Contributor

molebox commented Oct 12, 2021

This looks great!

Moving forward, I think we should create a page for this guide. Otherwise we run the risk of just adding loads of testing guides to the Testing page and it becomes a big'ol testing soup. I'll create an issue to handle that. Getting this out there in its current format for our users is most important now. 😄

@molebox molebox self-requested a review October 12, 2021 06:22
docs/testing.md Outdated Show resolved Hide resolved
docs/testing.md Outdated Show resolved Hide resolved
docs/testing.md Outdated Show resolved Hide resolved
docs/testing.md Outdated Show resolved Hide resolved
docs/testing.md Outdated Show resolved Hide resolved
docs/testing.md Outdated Show resolved Hide resolved
Co-authored-by: Rich Haines <hello@richardhaines.dev>
Copy link
Contributor

@molebox molebox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

miyagi

@kodiakhq kodiakhq bot merged commit ca062db into vercel:canary Oct 12, 2021
@mxschmitt mxschmitt mentioned this pull request Oct 12, 2021
1 task
@vercel vercel locked as resolved and limited conversation to collaborators Jan 27, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants