Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update firebase in with-firebase #29581

Merged
merged 3 commits into from Feb 6, 2022
Merged

Conversation

msp5382
Copy link
Contributor

@msp5382 msp5382 commented Oct 3, 2021

From issue #29569 that mention with-firebase will error when use measurementId. I update firebase in this example and changed code into firebase 9 and that error is disappeared.

Closes: #29570
Fixes: #29569

@ijjk ijjk added the examples Issue/PR related to examples label Oct 3, 2021
@ijjk
Copy link
Member

ijjk commented Oct 3, 2021

Stats from current PR

Default Build (Decrease detected ✓)
General
vercel/next.js canary msp5382/next.js canary Change
buildDuration 14.7s 15.1s ⚠️ +345ms
buildDurationCached 3.6s 3.6s -31ms
nodeModulesSize 183 MB 183 MB
Page Load Tests Overall decrease ⚠️
vercel/next.js canary msp5382/next.js canary Change
/ failed reqs 0 0
/ total time (seconds) 3.375 3.526 ⚠️ +0.15
/ avg req/sec 740.77 709.04 ⚠️ -31.73
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.824 1.935 ⚠️ +0.11
/error-in-render avg req/sec 1370.95 1291.94 ⚠️ -79.01
Client Bundles (main, webpack, commons)
vercel/next.js canary msp5382/next.js canary Change
779.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42.2 kB 42.2 kB
main-HASH.js gzip 26.9 kB 26.9 kB
webpack-HASH.js gzip 1.45 kB 1.45 kB
Overall change 70.8 kB 70.8 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary msp5382/next.js canary Change
polyfills-a4..dd70.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary msp5382/next.js canary Change
_app-HASH.js gzip 977 B 977 B
_error-HASH.js gzip 194 B 194 B
amp-HASH.js gzip 311 B 311 B
css-HASH.js gzip 328 B 328 B
dynamic-HASH.js gzip 2.67 kB 2.67 kB
head-HASH.js gzip 351 B 351 B
hooks-HASH.js gzip 918 B 918 B
image-HASH.js gzip 4.15 kB 4.15 kB
index-HASH.js gzip 260 B 260 B
link-HASH.js gzip 1.66 kB 1.66 kB
routerDirect..HASH.js gzip 320 B 320 B
script-HASH.js gzip 386 B 386 B
withRouter-HASH.js gzip 319 B 319 B
bb14e60e810b..30f.css gzip 125 B 125 B
Overall change 13 kB 13 kB
Client Build Manifests
vercel/next.js canary msp5382/next.js canary Change
_buildManifest.js gzip 494 B 494 B
Overall change 494 B 494 B
Rendered Page Sizes
vercel/next.js canary msp5382/next.js canary Change
index.html gzip 539 B 539 B
link.html gzip 551 B 551 B
withRouter.html gzip 533 B 533 B
Overall change 1.62 kB 1.62 kB

Default Build with SWC (Increase detected ⚠️)
General
vercel/next.js canary msp5382/next.js canary Change
buildDuration 7.6s 7.5s -100ms
buildDurationCached 3.7s 3.5s -156ms
nodeModulesSize 183 MB 183 MB
Page Load Tests Overall increase ✓
vercel/next.js canary msp5382/next.js canary Change
/ failed reqs 0 0
/ total time (seconds) 3.404 3.379 -0.02
/ avg req/sec 734.38 739.85 +5.47
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.786 1.785 0
/error-in-render avg req/sec 1399.69 1400.46 +0.77
Client Bundles (main, webpack, commons)
vercel/next.js canary msp5382/next.js canary Change
675-HASH.js gzip 13.8 kB 13.8 kB
770.HASH.js gzip 178 B 178 B
framework-HASH.js gzip 50.7 kB 50.7 kB
main-HASH.js gzip 34.9 kB 34.9 kB
webpack-HASH.js gzip 1.64 kB 1.64 kB
Overall change 101 kB 101 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary msp5382/next.js canary Change
polyfills-a4..dd70.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary msp5382/next.js canary Change
_app-HASH.js gzip 1.33 kB 1.33 kB
_error-HASH.js gzip 180 B 180 B
amp-HASH.js gzip 315 B 315 B
css-HASH.js gzip 331 B 331 B
dynamic-HASH.js gzip 2.79 kB 2.79 kB
head-HASH.js gzip 356 B 356 B
hooks-HASH.js gzip 637 B 637 B
image-HASH.js gzip 573 B 573 B
index-HASH.js gzip 262 B 262 B
link-HASH.js gzip 2.2 kB 2.2 kB
routerDirect..HASH.js gzip 326 B 326 B
script-HASH.js gzip 393 B 393 B
withRouter-HASH.js gzip 322 B 322 B
bb14e60e810b..30f.css gzip 125 B 125 B
Overall change 10.1 kB 10.1 kB
Client Build Manifests
vercel/next.js canary msp5382/next.js canary Change
_buildManifest.js gzip 511 B 511 B
Overall change 511 B 511 B
Rendered Page Sizes
vercel/next.js canary msp5382/next.js canary Change
index.html gzip 539 B 539 B
link.html gzip 551 B 551 B
withRouter.html gzip 532 B 532 B
Overall change 1.62 kB 1.62 kB
Commit: 1ded791

@ijjk ijjk requested a review from steven-tey as a code owner February 6, 2022 17:54
Copy link
Member

@ijjk ijjk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

@kodiakhq kodiakhq bot merged commit 021fd94 into vercel:canary Feb 6, 2022
natew pushed a commit to natew/next.js that referenced this pull request Feb 16, 2022
From issue vercel#29569 that mention `with-firebase` will error when use `measurementId`. I update firebase in this example and changed code into firebase 9 and that error is disappeared.

Closes: vercel#29570
Fixes: vercel#29569
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 9, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
examples Issue/PR related to examples
Projects
None yet
Development

Successfully merging this pull request may close these issues.

firebase.analytics() throwing Unhandled Runtime Error in "with-firebase" example
3 participants