Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add eslint rule to prevent importing next/server outside of _middleware #30973

Merged
merged 3 commits into from Nov 12, 2021
Merged

Add eslint rule to prevent importing next/server outside of _middleware #30973

merged 3 commits into from Nov 12, 2021

Conversation

thibautsabot
Copy link
Contributor

@ijjk

This comment has been minimized.

Sign in to view
@ijjk

This comment has been minimized.

Sign in to view
@javivelasco javivelasco self-requested a review November 12, 2021 11:53
@ijjk
Copy link
Member

ijjk commented Nov 12, 2021

Stats from current PR

Default Build (Decrease detected ✓)
General Overall decrease ✓
vercel/next.js canary thibautsabot/next.js no-server-import-in-pages Change
buildDuration 22.1s 22.3s ⚠️ +155ms
buildDurationCached 4.3s 4.6s ⚠️ +255ms
nodeModulesSize 335 MB 335 MB -13 B
Page Load Tests Overall decrease ⚠️
vercel/next.js canary thibautsabot/next.js no-server-import-in-pages Change
/ failed reqs 0 0 ✓
/ total time (seconds) 3.642 3.64 0
/ avg req/sec 686.36 686.89 +0.53
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.617 1.703 ⚠️ +0.09
/error-in-render avg req/sec 1545.81 1468 ⚠️ -77.81
Client Bundles (main, webpack, commons)
vercel/next.js canary thibautsabot/next.js no-server-import-in-pages Change
450.HASH.js gzip 179 B 179 B ✓
framework-HASH.js gzip 42.2 kB 42.2 kB ✓
main-HASH.js gzip 28.3 kB 28.3 kB ✓
webpack-HASH.js gzip 1.45 kB 1.45 kB ✓
Overall change 72.2 kB 72.2 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary thibautsabot/next.js no-server-import-in-pages Change
polyfills-HASH.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary thibautsabot/next.js no-server-import-in-pages Change
_app-HASH.js gzip 1.37 kB 1.37 kB ✓
_error-HASH.js gzip 194 B 194 B ✓
amp-HASH.js gzip 312 B 312 B ✓
css-HASH.js gzip 327 B 327 B ✓
dynamic-HASH.js gzip 2.38 kB 2.38 kB ✓
head-HASH.js gzip 350 B 350 B ✓
hooks-HASH.js gzip 635 B 635 B ✓
image-HASH.js gzip 4.44 kB 4.44 kB ✓
index-HASH.js gzip 263 B 263 B ✓
link-HASH.js gzip 1.87 kB 1.87 kB ✓
routerDirect..HASH.js gzip 321 B 321 B ✓
script-HASH.js gzip 383 B 383 B ✓
withRouter-HASH.js gzip 318 B 318 B ✓
85e02e95b279..7e3.css gzip 107 B 107 B ✓
Overall change 13.3 kB 13.3 kB ✓
Client Build Manifests
vercel/next.js canary thibautsabot/next.js no-server-import-in-pages Change
_buildManifest.js gzip 460 B 460 B ✓
Overall change 460 B 460 B ✓
Rendered Page Sizes
vercel/next.js canary thibautsabot/next.js no-server-import-in-pages Change
index.html gzip 522 B 522 B ✓
link.html gzip 535 B 535 B ✓
withRouter.html gzip 515 B 515 B ✓
Overall change 1.57 kB 1.57 kB ✓
Default Build with SWC (Decrease detected ✓)
General Overall decrease ✓
vercel/next.js canary thibautsabot/next.js no-server-import-in-pages Change
buildDuration 23.6s 24s ⚠️ +425ms
buildDurationCached 4.4s 4.4s ⚠️ +68ms
nodeModulesSize 335 MB 335 MB -13 B
Page Load Tests Overall decrease ⚠️
vercel/next.js canary thibautsabot/next.js no-server-import-in-pages Change
/ failed reqs 0 0 ✓
/ total time (seconds) 3.58 3.63 ⚠️ +0.05
/ avg req/sec 698.28 688.78 ⚠️ -9.5
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.733 1.759 ⚠️ +0.03
/error-in-render avg req/sec 1442.67 1421.28 ⚠️ -21.39
Client Bundles (main, webpack, commons)
vercel/next.js canary thibautsabot/next.js no-server-import-in-pages Change
450.HASH.js gzip 179 B 179 B ✓
framework-HASH.js gzip 42.3 kB 42.3 kB ✓
main-HASH.js gzip 28.5 kB 28.5 kB ✓
webpack-HASH.js gzip 1.43 kB 1.43 kB ✓
Overall change 72.5 kB 72.5 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary thibautsabot/next.js no-server-import-in-pages Change
polyfills-HASH.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary thibautsabot/next.js no-server-import-in-pages Change
_app-HASH.js gzip 1.35 kB 1.35 kB ✓
_error-HASH.js gzip 180 B 180 B ✓
amp-HASH.js gzip 305 B 305 B ✓
css-HASH.js gzip 321 B 321 B ✓
dynamic-HASH.js gzip 2.38 kB 2.38 kB ✓
head-HASH.js gzip 342 B 342 B ✓
hooks-HASH.js gzip 622 B 622 B ✓
image-HASH.js gzip 4.46 kB 4.46 kB ✓
index-HASH.js gzip 256 B 256 B ✓
link-HASH.js gzip 1.91 kB 1.91 kB ✓
routerDirect..HASH.js gzip 314 B 314 B ✓
script-HASH.js gzip 375 B 375 B ✓
withRouter-HASH.js gzip 309 B 309 B ✓
85e02e95b279..7e3.css gzip 107 B 107 B ✓
Overall change 13.2 kB 13.2 kB ✓
Client Build Manifests
vercel/next.js canary thibautsabot/next.js no-server-import-in-pages Change
_buildManifest.js gzip 459 B 459 B ✓
Overall change 459 B 459 B ✓
Rendered Page Sizes
vercel/next.js canary thibautsabot/next.js no-server-import-in-pages Change
index.html gzip 522 B 522 B ✓
link.html gzip 534 B 534 B ✓
withRouter.html gzip 516 B 516 B ✓
Overall change 1.57 kB 1.57 kB ✓
Commit: 061f580

ijjk
ijjk approved these changes Nov 12, 2021
View reviewed changes
Copy link
Member

@ijjk ijjk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

@ijjk ijjk merged commit d1adf1d into vercel:canary Nov 12, 2021
@ljosberinn
Copy link
Contributor

@thibautsabot It appears this has been released, however the rule is not included within the plugin as per index.js. Care to add it there aswell? :)

@thibautsabot thibautsabot mentioned this pull request Nov 28, 2021
Merged
@ykzts
Copy link
Contributor

ykzts commented Dec 4, 2021

@thibautsabot Is it a deliberate behavior to get errors in non-root _middleware.ts like /pages/about/_middleware.ts and /pages/about/team/_middleware.ts?

@ljosberinn
Copy link
Contributor

sounds like an issue with this line. Any path that includes /pages would be a valid path?

@thibautsabot
Copy link
Contributor Author

Hello!

Sorry for the inconvenience, will take a loot at it later today!

@thibautsabot thibautsabot mentioned this pull request Dec 5, 2021
Merged
kodiakhq bot pushed a commit that referenced this pull request Dec 5, 2021
@thibautsabot
Fix no-server-import-in-page eslint rule for subfolder middleware (#3…
5b4e139 
…2139)

People have been reporting on #30973 that the `no-server-import-in-page` eslint rule is reporting false positives for `_middleware` files inside sub-page folders.

Unlike `_document`, we can have multiple `_middleware` files.

Fixes #32121
@vercel vercel locked as resolved and limited conversation to collaborators Jan 27, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@javivelasco javivelasco javivelasco approved these changes

@ijjk ijjk ijjk approved these changes

@huozhi huozhi Awaiting requested review from huozhi huozhi is a code owner

@shuding shuding Awaiting requested review from shuding shuding is a code owner

@timneutkens timneutkens Awaiting requested review from timneutkens timneutkens is a code owner

Assignees
No one assigned
Labels
type: next
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Lint warning if you use next/server outside of Middleware
5 participants
@thibautsabot @ijjk @ljosberinn @ykzts @javivelasco