Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

include no-document-import-in-page rule in plugin index #31890

Merged

Conversation

thibautsabot
Copy link
Contributor

no-document-import-in-page was added in #30973 but was not included in the index.js file.

@ijjk
Copy link
Member

ijjk commented Nov 28, 2021

Stats from current PR

Default Build (Decrease detected ✓)
General Overall increase ⚠️
vercel/next.js canary thibautsabot/next.js default-no-document-import-in-page Change
buildDuration 21.8s 21.9s ⚠️ +79ms
buildDurationCached 4.1s 4s -16ms
nodeModulesSize 346 MB 346 MB ⚠️ +1 B
Page Load Tests Overall decrease ⚠️
vercel/next.js canary thibautsabot/next.js default-no-document-import-in-page Change
/ failed reqs 0 0
/ total time (seconds) 3.552 3.55 0
/ avg req/sec 703.75 704.27 +0.52
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.646 1.66 ⚠️ +0.01
/error-in-render avg req/sec 1518.63 1506.26 ⚠️ -12.37
Client Bundles (main, webpack, commons)
vercel/next.js canary thibautsabot/next.js default-no-document-import-in-page Change
450.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42.2 kB 42.2 kB
main-HASH.js gzip 28.4 kB 28.4 kB
webpack-HASH.js gzip 1.45 kB 1.45 kB
Overall change 72.2 kB 72.2 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary thibautsabot/next.js default-no-document-import-in-page Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary thibautsabot/next.js default-no-document-import-in-page Change
_app-HASH.js gzip 1.37 kB 1.37 kB
_error-HASH.js gzip 194 B 194 B
amp-HASH.js gzip 312 B 312 B
css-HASH.js gzip 327 B 327 B
dynamic-HASH.js gzip 2.38 kB 2.38 kB
head-HASH.js gzip 350 B 350 B
hooks-HASH.js gzip 635 B 635 B
image-HASH.js gzip 4.45 kB 4.45 kB
index-HASH.js gzip 263 B 263 B
link-HASH.js gzip 1.87 kB 1.87 kB
routerDirect..HASH.js gzip 321 B 321 B
script-HASH.js gzip 383 B 383 B
withRouter-HASH.js gzip 318 B 318 B
85e02e95b279..7e3.css gzip 107 B 107 B
Overall change 13.3 kB 13.3 kB
Client Build Manifests
vercel/next.js canary thibautsabot/next.js default-no-document-import-in-page Change
_buildManifest.js gzip 460 B 460 B
Overall change 460 B 460 B
Rendered Page Sizes
vercel/next.js canary thibautsabot/next.js default-no-document-import-in-page Change
index.html gzip 532 B 532 B
link.html gzip 545 B 545 B
withRouter.html gzip 526 B 526 B
Overall change 1.6 kB 1.6 kB

Default Build with SWC (Decrease detected ✓)
General Overall increase ⚠️
vercel/next.js canary thibautsabot/next.js default-no-document-import-in-page Change
buildDuration 23.5s 23.4s -68ms
buildDurationCached 4.1s 4s -35ms
nodeModulesSize 346 MB 346 MB ⚠️ +1 B
Page Load Tests Overall decrease ⚠️
vercel/next.js canary thibautsabot/next.js default-no-document-import-in-page Change
/ failed reqs 0 0
/ total time (seconds) 3.533 3.51 -0.02
/ avg req/sec 707.61 712.3 +4.69
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.628 1.66 ⚠️ +0.03
/error-in-render avg req/sec 1535.32 1505.62 ⚠️ -29.7
Client Bundles (main, webpack, commons)
vercel/next.js canary thibautsabot/next.js default-no-document-import-in-page Change
450.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42.3 kB 42.3 kB
main-HASH.js gzip 28.6 kB 28.6 kB
webpack-HASH.js gzip 1.44 kB 1.44 kB
Overall change 72.5 kB 72.5 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary thibautsabot/next.js default-no-document-import-in-page Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary thibautsabot/next.js default-no-document-import-in-page Change
_app-HASH.js gzip 1.35 kB 1.35 kB
_error-HASH.js gzip 180 B 180 B
amp-HASH.js gzip 305 B 305 B
css-HASH.js gzip 321 B 321 B
dynamic-HASH.js gzip 2.37 kB 2.37 kB
head-HASH.js gzip 342 B 342 B
hooks-HASH.js gzip 622 B 622 B
image-HASH.js gzip 4.47 kB 4.47 kB
index-HASH.js gzip 256 B 256 B
link-HASH.js gzip 1.91 kB 1.91 kB
routerDirect..HASH.js gzip 314 B 314 B
script-HASH.js gzip 375 B 375 B
withRouter-HASH.js gzip 309 B 309 B
85e02e95b279..7e3.css gzip 107 B 107 B
Overall change 13.2 kB 13.2 kB
Client Build Manifests
vercel/next.js canary thibautsabot/next.js default-no-document-import-in-page Change
_buildManifest.js gzip 458 B 458 B
Overall change 458 B 458 B
Rendered Page Sizes
vercel/next.js canary thibautsabot/next.js default-no-document-import-in-page Change
index.html gzip 532 B 532 B
link.html gzip 544 B 544 B
withRouter.html gzip 526 B 526 B
Overall change 1.6 kB 1.6 kB
Commit: 1df14ab

Copy link
Member

@timneutkens timneutkens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@timneutkens timneutkens merged commit 922a1fd into vercel:canary Nov 29, 2021
@vercel vercel locked as resolved and limited conversation to collaborators Jan 27, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants