Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expands next/script documentation #31063

Merged
merged 5 commits into from Nov 8, 2021
Merged

Expands next/script documentation #31063

merged 5 commits into from Nov 8, 2021

Conversation

housseindjirdeh
Copy link
Collaborator

@housseindjirdeh housseindjirdeh commented Nov 5, 2021

This PR does the following to partially address #31062:

  • Expands the Script Component page in the core documentation
  • Adds a next/script API reference page

docs/basic-features/script.md Outdated Show resolved Hide resolved
docs/basic-features/script.md Outdated Show resolved Hide resolved
docs/basic-features/script.md Outdated Show resolved Hide resolved
docs/basic-features/script.md Outdated Show resolved Hide resolved
docs/basic-features/script.md Outdated Show resolved Hide resolved
docs/basic-features/script.md Outdated Show resolved Hide resolved
@leerob
Copy link
Member

leerob commented Nov 8, 2021

Much more clear - nice work!

@kodiakhq kodiakhq bot merged commit ca41952 into vercel:canary Nov 8, 2021

> **Note:**
>
> - `next/script` **must not** be placed in either a `next/head` component or in `pages/_document.js`.
Copy link

@mclaros mclaros Nov 11, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, thanks for the clearer documentation! Had a question about this removed text. Was the Script component always able to be placed inside of next/head or _document.js? Or was this achieved via a change to the Script component in a recent release?

@vercel vercel locked as resolved and limited conversation to collaborators Jan 27, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
created-by: Chrome Aurora PRs by the Google Chrome team: https://web.dev/aurora
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants