-
Notifications
You must be signed in to change notification settings - Fork 26.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Expands next/script
documentation
#31063
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
housseindjirdeh
requested review from
huozhi,
ijjk,
leerob,
lfades,
molebox,
padmaia,
shuding,
styfle and
timneutkens
as code owners
November 5, 2021 23:42
ijjk
added
created-by: Chrome Aurora
PRs by the Google Chrome team: https://web.dev/aurora
type: documentation
labels
Nov 5, 2021
4 tasks
leerob
reviewed
Nov 6, 2021
stefanprobst
reviewed
Nov 6, 2021
leerob
approved these changes
Nov 8, 2021
Much more clear - nice work! |
mclaros
reviewed
Nov 11, 2021
|
||
> **Note:** | ||
> | ||
> - `next/script` **must not** be placed in either a `next/head` component or in `pages/_document.js`. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi, thanks for the clearer documentation! Had a question about this removed text. Was the Script component always able to be placed inside of next/head
or _document.js
? Or was this achieved via a change to the Script component in a recent release?
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR does the following to partially address #31062:
next/script
API reference page