Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Auth0 Example #31284

Merged
merged 2 commits into from Nov 11, 2021
Merged

Fix Auth0 Example #31284

merged 2 commits into from Nov 11, 2021

Conversation

stevejarvis
Copy link
Contributor

@stevejarvis stevejarvis commented Nov 11, 2021 •
edited

Fixes #31286

I was going through the Auth0 example and hit the following issue (screencap):

Screen Shot 2021-11-10 at 12 57 41 PM

This just updates the call there to pass res, which matches the signature documented here: https://auth0.github.io/nextjs-auth0/modules/session_get_session.html

With this fix, the rest of the example worked wonderfully 馃憤.

Bug

  • Related issues linked using fixes #number
  • Integration tests added (NA?)
  • Errors have helpful link attached, see contributing.md

@ijjk ijjk added the examples Issue/PR related to examples label Nov 11, 2021
@stevejarvis stevejarvis mentioned this pull request Nov 11, 2021
Closed
leerob
leerob approved these changes Nov 11, 2021
View reviewed changes
Copy link
Member

@leerob leerob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@kodiakhq kodiakhq bot merged commit 5014362 into vercel:canary Nov 11, 2021
@vercel vercel locked as resolved and limited conversation to collaborators Jan 27, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@leerob leerob leerob approved these changes

@ijjk ijjk Awaiting requested review from ijjk

@lfades lfades Awaiting requested review from lfades

@shuding shuding Awaiting requested review from shuding

@timneutkens timneutkens Awaiting requested review from timneutkens

Assignees
No one assigned
Labels
examples Issue/PR related to examples
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Auth0 API Call Incorrect in Example
3 participants
@stevejarvis @leerob @ijjk