Fix ambiguous flags in Dockerfile example #33417
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
At least with Docker xx this Dockerfile fails to both `adduser` and `addgroup` commands due to ambiguous flags. The error message for example for `addgroup` is: ``` vercel#5 0.292 Option g is ambiguous (gecos, gid, group) vercel#5 0.292 Option s is ambiguous (shell, system) ``` This PR switches both commands to use the long-format flags. I think they are also more understandable for the readers of the Dockerfile.
vertti
requested review from
ijjk,
leerob,
shuding,
steven-tey and
timneutkens
as code owners
balazsorban44
approved these changes
Jan 18, 2022
balazsorban44
requested changes
Jan 20, 2022
Co-authored-by: Balázs Orbán <info@balazsorban.com>
ijjk
approved these changes
Feb 5, 2022
natew
pushed a commit
to natew/next.js
that referenced
this pull request
Feb 16, 2022
* Fix ambiguous flags in Dockerfile example At least with Docker xx this Dockerfile fails to both `adduser` and `addgroup` commands due to ambiguous flags. The error message for example for `addgroup` is: ``` vercel#5 0.292 Option g is ambiguous (gecos, gid, group) vercel#5 0.292 Option s is ambiguous (shell, system) ``` This PR switches both commands to use the long-format flags. I think they are also more understandable for the readers of the Dockerfile. * Apply suggestions from code review Co-authored-by: Balázs Orbán <info@balazsorban.com> Co-authored-by: JJ Kasper <jj@jjsweb.site> Co-authored-by: Balázs Orbán <info@balazsorban.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At least with Docker 20.10.11 this Dockerfile fails to both
adduserandaddgroupcommands due to ambiguous flags. The error message for example foraddgroupis:This PR switches both commands to use the long-format flags. I think they are also more understandable for the readers of the Dockerfile.