Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix ambiguous flags in Dockerfile example #33417

Merged
merged 3 commits into from Feb 5, 2022
Merged

Fix ambiguous flags in Dockerfile example #33417

merged 3 commits into from Feb 5, 2022

Commits on Jan 18, 2022

  1. Fix ambiguous flags in Dockerfile example 

    At least with Docker xx this Dockerfile fails to both `adduser` and `addgroup` commands due to ambiguous flags. The error message for example for `addgroup` is:

```
vercel#5 0.292 Option g is ambiguous (gecos, gid, group)
vercel#5 0.292 Option s is ambiguous (shell, system)
```
This PR switches both commands to use the long-format flags. I think they are also more understandable for the readers of the Dockerfile.
    @vertti
    vertti committed Jan 18, 2022
    Configuration menu
    Copy the full SHA
    dac58dc View commit details
    Browse the repository at this point in the history

Commits on Feb 5, 2022

  1. Apply suggestions from code review 

    Co-authored-by: Balázs Orbán <info@balazsorban.com>
    @ijjk @balazsorban44
    ijjk and balazsorban44 committed Feb 5, 2022
    Configuration menu
    Copy the full SHA
    9be6d13 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'canary' into patch-1

    @ijjk
    ijjk committed Feb 5, 2022
    Configuration menu
    Copy the full SHA
    c76cc75 View commit details
    Browse the repository at this point in the history