New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Clarity About Downloading and Self-Hosting a Font File #33760
Merged
kodiakhq
merged 5 commits into
vercel:canary
from
MaedahBatool:maedah-update-font-optimization
Feb 1, 2022
Merged
Add Clarity About Downloading and Self-Hosting a Font File #33760
kodiakhq
merged 5 commits into
vercel:canary
from
MaedahBatool:maedah-update-font-optimization
Feb 1, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MaedahBatool
requested review from
huozhi,
ijjk,
leerob,
padmaia,
shuding,
styfle and
timneutkens
as code owners
January 28, 2022 08:32
ijjk
added
area: documentation
created-by: Next.js docs team
PRs by the Next.js docs team
labels
Jan 28, 2022
molebox
previously approved these changes
Jan 28, 2022
leerob
reviewed
Jan 28, 2022
Co-authored-by: Lee Robinson <me@leerob.io>
styfle
reviewed
Jan 31, 2022
Co-authored-by: Steven <steven@ceriously.com>
styfle
approved these changes
Feb 1, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
natew
pushed a commit
to natew/next.js
that referenced
this pull request
Feb 16, 2022
) Details about downloading and self-hosting font files were missing from our[ Font Optimization docs](https://nextjs.org/docs/basic-features/font-optimization). This PR addresses these changes. ## Bug - [x] Related issues linked using vercel#33054 ## Documentation / Examples - [x] Make sure the linting passes by running `yarn lint`
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details about downloading and self-hosting font files were missing from our Font Optimization docs. This PR addresses these changes.
Bug
Documentation / Examples
yarn lint