Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Polyfill pipeTo and pipeThrough #34112

Merged
merged 6 commits into from Feb 8, 2022
Merged

Polyfill pipeTo and pipeThrough #34112

merged 6 commits into from Feb 8, 2022

Conversation

shuding
Copy link
Member

@shuding shuding commented Feb 8, 2022

Similar to #32602, pipeTo and pipeThrough are not polyfilled/implemented properly in the Edge runtime. This PR adds basic polyfill for our use case to make sure it doesn't break.

I've tested it in Node.js and it worked well (also covered by the existing integration tests too).

@ijjk ijjk added created-by: Next.js team PRs by the Next.js team type: next labels Feb 8, 2022
@shuding shuding marked this pull request as ready for review February 8, 2022 20:58
@shuding shuding requested a review from devknoll February 8, 2022 20:59
@ijjk
Copy link
Member

ijjk commented Feb 8, 2022

Stats from current PR

Default Build
General Overall increase ⚠️
vercel/next.js canary shuding/next.js shu/79d3 Change
buildDuration 21.2s 21.4s ⚠️ +191ms
buildDurationCached 8.1s 8.1s -19ms
nodeModulesSize 359 MB 359 MB ⚠️ +1.69 kB
Page Load Tests Overall increase ✓
vercel/next.js canary shuding/next.js shu/79d3 Change
/ failed reqs 0 0
/ total time (seconds) 4.722 4.62 -0.1
/ avg req/sec 529.42 541.17 +11.75
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 2.357 2.372 ⚠️ +0.01
/error-in-render avg req/sec 1060.87 1054.06 ⚠️ -6.81
Client Bundles (main, webpack, commons)
vercel/next.js canary shuding/next.js shu/79d3 Change
450.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42 kB 42 kB
main-HASH.js gzip 27.5 kB 27.5 kB
webpack-HASH.js gzip 1.44 kB 1.44 kB
Overall change 71.2 kB 71.2 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary shuding/next.js shu/79d3 Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary shuding/next.js shu/79d3 Change
_app-HASH.js gzip 1.36 kB 1.36 kB
_error-HASH.js gzip 194 B 194 B
amp-HASH.js gzip 312 B 312 B
css-HASH.js gzip 326 B 326 B
dynamic-HASH.js gzip 2.57 kB 2.57 kB
head-HASH.js gzip 350 B 350 B
hooks-HASH.js gzip 919 B 919 B
image-HASH.js gzip 5.01 kB 5.01 kB
index-HASH.js gzip 263 B 263 B
link-HASH.js gzip 2.26 kB 2.26 kB
routerDirect..HASH.js gzip 321 B 321 B
script-HASH.js gzip 383 B 383 B
withRouter-HASH.js gzip 318 B 318 B
85e02e95b279..7e3.css gzip 107 B 107 B
Overall change 14.7 kB 14.7 kB
Client Build Manifests
vercel/next.js canary shuding/next.js shu/79d3 Change
_buildManifest.js gzip 458 B 458 B
Overall change 458 B 458 B
Rendered Page Sizes
vercel/next.js canary shuding/next.js shu/79d3 Change
index.html gzip 531 B 531 B
link.html gzip 544 B 544 B
withRouter.html gzip 525 B 525 B
Overall change 1.6 kB 1.6 kB

Default Build with SWC (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary shuding/next.js shu/79d3 Change
buildDuration 26.2s 26.1s -110ms
buildDurationCached 8.2s 8.1s -58ms
nodeModulesSize 359 MB 359 MB ⚠️ +1.69 kB
Page Load Tests Overall increase ✓
vercel/next.js canary shuding/next.js shu/79d3 Change
/ failed reqs 0 0
/ total time (seconds) 4.916 4.572 -0.34
/ avg req/sec 508.58 546.84 +38.26
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 2.4 2.317 -0.08
/error-in-render avg req/sec 1041.47 1079.08 +37.61
Client Bundles (main, webpack, commons)
vercel/next.js canary shuding/next.js shu/79d3 Change
450.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42.1 kB 42.1 kB
main-HASH.js gzip 27.5 kB 27.5 kB
webpack-HASH.js gzip 1.44 kB 1.44 kB
Overall change 71.3 kB 71.3 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary shuding/next.js shu/79d3 Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary shuding/next.js shu/79d3 Change
_app-HASH.js gzip 1.35 kB 1.35 kB
_error-HASH.js gzip 180 B 180 B
amp-HASH.js gzip 305 B 305 B
css-HASH.js gzip 321 B 321 B
dynamic-HASH.js gzip 2.56 kB 2.56 kB
head-HASH.js gzip 342 B 342 B
hooks-HASH.js gzip 911 B 911 B
image-HASH.js gzip 5.05 kB 5.05 kB
index-HASH.js gzip 256 B 256 B
link-HASH.js gzip 2.28 kB 2.28 kB
routerDirect..HASH.js gzip 314 B 314 B
script-HASH.js gzip 375 B 375 B
withRouter-HASH.js gzip 309 B 309 B
85e02e95b279..7e3.css gzip 107 B 107 B
Overall change 14.7 kB 14.7 kB
Client Build Manifests
vercel/next.js canary shuding/next.js shu/79d3 Change
_buildManifest.js gzip 459 B 459 B
Overall change 459 B 459 B
Rendered Page Sizes
vercel/next.js canary shuding/next.js shu/79d3 Change
index.html gzip 533 B 533 B
link.html gzip 547 B 547 B
withRouter.html gzip 527 B 527 B
Overall change 1.61 kB 1.61 kB
Commit: 162b38e

@shuding shuding merged commit eb3cba3 into vercel:canary Feb 8, 2022
@shuding shuding deleted the shu/79d3 branch February 8, 2022 21:40
natew pushed a commit to natew/next.js that referenced this pull request Feb 16, 2022
* polyfill pipeTo

* add pipeThrough

* covert pipeThrough calls

* use pipe

* invert logic

Co-authored-by: Jiachi Liu <inbox@huozhi.im>
Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 11, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants