Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: disallow using pipe and pipeThrough for streaming #34148

Closed
wants to merge 1 commit into from

Conversation

huozhi
Copy link
Member

@huozhi huozhi commented Feb 9, 2022

Follow up for #34112

Since the web-streams-polyfill has been used in other dependencies like formdata-node, we cannot directly mock it globally. In the test integration, next is spinned up through process and code is bundled for edge runtime cases, not able to mock through custom readable-stream polyfill through jest.

Use this as workaround: throw error for readable.pipe and readable.pipeThrough so that they cannot continue

@ijjk ijjk added created-by: Next.js team PRs by the Next.js team type: next labels Feb 9, 2022
@ijjk
Copy link
Member

ijjk commented Feb 9, 2022

Stats from current PR

Default Build (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary huozhi/next.js test/streaming-runtime Change
buildDuration 15.4s 15.6s ⚠️ +160ms
buildDurationCached 6.1s 6s -30ms
nodeModulesSize 359 MB 359 MB ⚠️ +725 B
Page Load Tests Overall increase ✓
vercel/next.js canary huozhi/next.js test/streaming-runtime Change
/ failed reqs 0 0
/ total time (seconds) 3.186 3.18 -0.01
/ avg req/sec 784.76 786.09 +1.33
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.368 1.347 -0.02
/error-in-render avg req/sec 1827.7 1856.22 +28.52
Client Bundles (main, webpack, commons)
vercel/next.js canary huozhi/next.js test/streaming-runtime Change
450.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42 kB 42 kB
main-HASH.js gzip 27.9 kB 27.9 kB
webpack-HASH.js gzip 1.44 kB 1.44 kB
Overall change 71.5 kB 71.5 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary huozhi/next.js test/streaming-runtime Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary huozhi/next.js test/streaming-runtime Change
_app-HASH.js gzip 1.36 kB 1.36 kB
_error-HASH.js gzip 194 B 194 B
amp-HASH.js gzip 312 B 312 B
css-HASH.js gzip 326 B 326 B
dynamic-HASH.js gzip 2.57 kB 2.57 kB
head-HASH.js gzip 350 B 350 B
hooks-HASH.js gzip 919 B 919 B
image-HASH.js gzip 5.01 kB 5.01 kB
index-HASH.js gzip 263 B 263 B
link-HASH.js gzip 2.26 kB 2.26 kB
routerDirect..HASH.js gzip 321 B 321 B
script-HASH.js gzip 383 B 383 B
withRouter-HASH.js gzip 318 B 318 B
85e02e95b279..7e3.css gzip 107 B 107 B
Overall change 14.7 kB 14.7 kB
Client Build Manifests
vercel/next.js canary huozhi/next.js test/streaming-runtime Change
_buildManifest.js gzip 459 B 459 B
Overall change 459 B 459 B
Rendered Page Sizes
vercel/next.js canary huozhi/next.js test/streaming-runtime Change
index.html gzip 531 B 531 B
link.html gzip 544 B 544 B
withRouter.html gzip 526 B 526 B
Overall change 1.6 kB 1.6 kB

Default Build with SWC (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary huozhi/next.js test/streaming-runtime Change
buildDuration 19s 18.9s -125ms
buildDurationCached 6s 6s -15ms
nodeModulesSize 359 MB 359 MB ⚠️ +725 B
Page Load Tests Overall increase ✓
vercel/next.js canary huozhi/next.js test/streaming-runtime Change
/ failed reqs 0 0
/ total time (seconds) 3.17 3.168 0
/ avg req/sec 788.54 789.07 +0.53
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.397 1.343 -0.05
/error-in-render avg req/sec 1789.55 1861.01 +71.46
Client Bundles (main, webpack, commons)
vercel/next.js canary huozhi/next.js test/streaming-runtime Change
450.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42.1 kB 42.1 kB
main-HASH.js gzip 27.9 kB 27.9 kB
webpack-HASH.js gzip 1.44 kB 1.44 kB
Overall change 71.6 kB 71.6 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary huozhi/next.js test/streaming-runtime Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary huozhi/next.js test/streaming-runtime Change
_app-HASH.js gzip 1.35 kB 1.35 kB
_error-HASH.js gzip 180 B 180 B
amp-HASH.js gzip 305 B 305 B
css-HASH.js gzip 321 B 321 B
dynamic-HASH.js gzip 2.56 kB 2.56 kB
head-HASH.js gzip 342 B 342 B
hooks-HASH.js gzip 911 B 911 B
image-HASH.js gzip 5.05 kB 5.05 kB
index-HASH.js gzip 256 B 256 B
link-HASH.js gzip 2.28 kB 2.28 kB
routerDirect..HASH.js gzip 314 B 314 B
script-HASH.js gzip 375 B 375 B
withRouter-HASH.js gzip 309 B 309 B
85e02e95b279..7e3.css gzip 107 B 107 B
Overall change 14.7 kB 14.7 kB
Client Build Manifests
vercel/next.js canary huozhi/next.js test/streaming-runtime Change
_buildManifest.js gzip 458 B 458 B
Overall change 458 B 458 B
Rendered Page Sizes
vercel/next.js canary huozhi/next.js test/streaming-runtime Change
index.html gzip 533 B 533 B
link.html gzip 547 B 547 B
withRouter.html gzip 527 B 527 B
Overall change 1.61 kB 1.61 kB
Commit: 5256c58

@huozhi
Copy link
Member Author

huozhi commented Feb 18, 2022

This polyfill is also bound with other dependency, can't be deleted. Throwing error will hang there, still not ideal

@huozhi huozhi closed this Feb 18, 2022
@huozhi huozhi deleted the test/streaming-runtime branch February 18, 2022 08:34
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 20, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants