New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Docs] Prefer function _app component in examples #39967

Merged

kodiakhq merged 1 commit into vercel:canary from HaNdTriX:next/function-app

Aug 26, 2022

Contributor

HaNdTriX commented Aug 26, 2022

Documentation / Examples

Make sure the linting passes by running pnpm lint
The examples guidelines are followed from our contributing doc


          [Docs] Prefer functional _app component

dc420b0

HaNdTriX requested review from timneutkens, ijjk, shuding, leerob, steven-tey and balazsorban44 as code owners

August 26, 2022 08:12

ijjk added the examples label

timneutkens approved these changes

View reviewed changes

timneutkens changed the title ~~[Docs] Prefer functional _app component in examples~~ [Docs] Prefer function _app component in examples

kodiakhq bot merged commit 53ecdd1 into vercel:canary

HaNdTriX deleted the next/function-app branch

August 26, 2022 12:18

github-actions bot locked as resolved and limited conversation to collaborators

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

timneutkens timneutkens approved these changes

ijjk Awaiting requested review from ijjk

shuding Awaiting requested review from shuding

leerob Awaiting requested review from leerob

steven-tey Awaiting requested review from steven-tey

balazsorban44 Awaiting requested review from balazsorban44