Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Docs] Prefer function _app component in examples #39967

Merged
merged 1 commit into from Aug 26, 2022
Merged

[Docs] Prefer function _app component in examples #39967

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
16 changes: 6 additions & 10 deletions examples/with-grommet/pages/_app.js
View file
Open in desktop
@@ -1,13 +1,9 @@
import App from 'next/app'
import { Grommet, grommet as grommetTheme } from 'grommet'

export default class MyApp extends App {
render() {
const { Component, pageProps } = this.props
return (
<Grommet theme={grommetTheme}>
<Component {...pageProps} />
</Grommet>
)
}
export default function App({ Component, pageProps }) {
return (
<Grommet theme={grommetTheme}>
<Component {...pageProps} />
</Grommet>
)
}
23 changes: 9 additions & 14 deletions examples/with-orbit-components/pages/_app.js
View file
Open in desktop
@@ -1,5 +1,3 @@
import * as React from 'react'
import App from 'next/app'
import { getTokens } from '@kiwicom/orbit-components'
import { ThemeProvider, createGlobalStyle } from 'styled-components'

Expand All @@ -14,16 +12,13 @@ const GlobalStyle = createGlobalStyle`

const tokens = getTokens()

export default class MyApp extends App {
render() {
const { Component, pageProps } = this.props
return (
<ThemeProvider theme={{ orbit: tokens }}>
<>
<GlobalStyle />
<Component {...pageProps} />
</>
</ThemeProvider>
)
}
export default function App({ Component, pageProps }) {
return (
<ThemeProvider theme={{ orbit: tokens }}>
<>
<GlobalStyle />
<Component {...pageProps} />
</>
</ThemeProvider>
)
}
22 changes: 8 additions & 14 deletions examples/with-portals-ssr/pages/_app.js
View file
Open in desktop
@@ -1,4 +1,3 @@
import App from 'next/app'
import { prepareClientPortals } from '@jesstelford/react-portal-universal'

if (typeof window !== 'undefined') {
Expand All @@ -8,17 +7,12 @@ if (typeof window !== 'undefined') {
prepareClientPortals()
}

class MyApp extends App {
render() {
const { Component, pageProps } = this.props
return (
/* This is where we'll render one of our universal portals */
<>
<div id="modal" />
<Component {...pageProps} />
</>
)
}
export default function App({ Component, pageProps }) {
return (
/* This is where we'll render one of our universal portals */
<>
<div id="modal" />
<Component {...pageProps} />
</>
)
}

export default MyApp
18 changes: 7 additions & 11 deletions examples/with-prefetching/pages/_app.js
View file
Open in desktop
@@ -1,14 +1,10 @@
import App from 'next/app'
import Nav from '../components/Nav'

export default class MyApp extends App {
render() {
const { Component, pageProps } = this.props
return (
<>
<Nav />
<Component {...pageProps} />
</>
)
}
export default function App({ Component, pageProps }) {
return (
<>
<Nav />
<Component {...pageProps} />
</>
)
}
10 changes: 5 additions & 5 deletions examples/with-react-jss/pages/_app.js
View file
Open in desktop
@@ -1,11 +1,11 @@
import App from 'next/app'
import { useEffect } from 'react'

export default class MyApp extends App {
componentDidMount() {
export default function App({ Component, pageProps }) {
useEffect(() => {
const style = document.getElementById('server-side-styles')

if (style) {
style.parentNode.removeChild(style)
}
}
}, [])
return <Component {...pageProps} />
}
16 changes: 5 additions & 11 deletions examples/with-stencil/packages/web-app/pages/_app.js
View file
Open in desktop
@@ -1,17 +1,11 @@
import React from 'react'
import App from 'next/app'

import { useLayoutEffect } from 'react'
import { applyPolyfills, defineCustomElements } from 'test-component/loader'

export default class MyApp extends App {
componentDidMount() {
export default function App({ Component, pageProps }) {
useLayoutEffect(() => {
applyPolyfills().then(() => {
defineCustomElements(window)
})
}

render() {
const { Component, pageProps } = this.props
return <Component {...pageProps} />
}
}, [])
return <Component {...pageProps} />
}
17 changes: 6 additions & 11 deletions examples/with-styled-components-rtl/pages/_app.js
View file
Open in desktop
@@ -1,4 +1,3 @@
import App from 'next/app'
import { ThemeProvider } from 'styled-components'

const theme = {
Expand All @@ -7,14 +6,10 @@ const theme = {
},
}

export default class MyApp extends App {
render() {
const { Component, pageProps } = this.props

return (
<ThemeProvider theme={theme}>
<Component {...pageProps} />
</ThemeProvider>
)
}
export default function App({ Component, pageProps }) {
return (
<ThemeProvider theme={theme}>
<Component {...pageProps} />
</ThemeProvider>
)
}
16 changes: 6 additions & 10 deletions examples/with-styletron/pages/_app.js
View file
Open in desktop
@@ -1,14 +1,10 @@
import App from 'next/app'
import { Provider as StyletronProvider } from 'styletron-react'
import { styletron } from '../styletron'

export default class MyApp extends App {
render() {
const { Component, pageProps } = this.props
return (
<StyletronProvider value={styletron}>
<Component {...pageProps} />
</StyletronProvider>
)
}
export default function App({ Component, pageProps }) {
return (
<StyletronProvider value={styletron}>
<Component {...pageProps} />
</StyletronProvider>
)
}