[Docs] Migrate image-component example to typescript #40204
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HaNdTriX
requested review from
timneutkens,
ijjk,
shuding and
styfle
as code owners
2 tasks
HaNdTriX
changed the title
balazsorban44
approved these changes
Sep 5, 2022
ijjk
approved these changes
Sep 5, 2022
atilafassina
pushed a commit
to atilafassina/next.js
that referenced
this pull request
Sep 5, 2022
<!-- Thanks for opening a PR! Your contribution is much appreciated. In order to make sure your PR is handled as smoothly as possible we request that you follow the checklist sections below. Choose the right checklist for the change that you're making: --> @styfle as suggested here the TS PR. > I suggest creating the first PR that is just JS => TS. > > The create a second PR that makes style changes. > ## Changelog - Update react - Migrated to typescript ## Related vercel#40153 ## Documentation / Examples - [x] Make sure the linting passes by running `pnpm lint` - [x] The examples guidelines are followed from [our contributing doc](https://github.com/vercel/next.js/blob/canary/contributing.md#adding-examples)
styfle
reviewed
Sep 8, 2022
|
|
||
| const Code = (p) => <code className={styles.inlineCode} {...p} /> | ||
| const Code = (props: PropsWithChildren) => ( |
There was a problem hiding this comment.
I'm getting an error
Type error: Generic type 'PropsWithChildren' requires 1 type argument(s).
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@styfle as suggested here the TS PR.
Changelog
Related
#40153
Documentation / Examples
pnpm lint