Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Docs] Updated image-component example #40153

Closed
wants to merge 5 commits into from
Closed

[Docs] Updated image-component example #40153

wants to merge 5 commits into from

Conversation

HaNdTriX
Copy link
Contributor

@HaNdTriX HaNdTriX commented Sep 1, 2022

Changelog

  • migrated example to typescript
  • abstracted layout stuff to make example more readable
  • adjust layout

Documentation / Examples

  • Make sure the linting passes by running pnpm lint
  • The examples guidelines are followed from our contributing doc

@ijjk ijjk added the examples Issue/PR related to examples label Sep 1, 2022
balazsorban44
balazsorban44 requested changes Sep 1, 2022
View reviewed changes
Copy link
Member

@balazsorban44 balazsorban44 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, added some comments. Could you address those?

@HaNdTriX
Copy link
Contributor Author

HaNdTriX commented Sep 2, 2022

@balazsorban44 Thanks for your review!

styfle
styfle reviewed Sep 2, 2022
View reviewed changes
examples/image-component/styles/globals.css

#__next p {
margin: 1.5rem 0;
}
Copy link
Member

@styfle styfle Sep 2, 2022 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These don't seem releated to typescript

styfle
styfle requested changes Sep 2, 2022
View reviewed changes
Copy link
Member

@styfle styfle left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This breaks the background image demo

I suggest creating the first PR that is just JS => TS.

The create a second PR that makes style changes.

image

@HaNdTriX
Copy link
Contributor Author

HaNdTriX commented Sep 3, 2022 •
edited

This breaks the background image demo

Good catch! I have fixed this issue. Next time I will keep the git history clean I promise 😜.

localhost_3000_

@HaNdTriX HaNdTriX changed the title [Docs] Migrated image-component example to typescript [Docs] Updated image-component example Sep 3, 2022
@HaNdTriX
Copy link
Contributor Author

HaNdTriX commented Sep 4, 2022 •
edited

closing in favour of #40204 (@styfle)

@HaNdTriX HaNdTriX closed this Sep 4, 2022
@HaNdTriX HaNdTriX mentioned this pull request Sep 4, 2022
Merged
2 tasks
ijjk pushed a commit that referenced this pull request Sep 5, 2022
@HaNdTriX
[Docs] Migrate image-component example to typescript (#40204)
d0fc673 
<!--
Thanks for opening a PR! Your contribution is much appreciated.
In order to make sure your PR is handled as smoothly as possible we request that you follow the checklist sections below.
Choose the right checklist for the change that you're making:
-->

@styfle as suggested here the TS PR.

> I suggest creating the first PR that is just JS => TS.
> 
> The create a second PR that makes style changes.
> 

## Changelog

- Update react
- Migrated to typescript

## Related

#40153

## Documentation / Examples

- [x] Make sure the linting passes by running `pnpm lint`
- [x] The examples guidelines are followed from [our contributing doc](https://github.com/vercel/next.js/blob/canary/contributing.md#adding-examples)
atilafassina pushed a commit to atilafassina/next.js that referenced this pull request Sep 5, 2022
@HaNdTriX @atilafassina
[Docs] Migrate image-component example to typescript (vercel#40204)
bb872fd 
<!--
Thanks for opening a PR! Your contribution is much appreciated.
In order to make sure your PR is handled as smoothly as possible we request that you follow the checklist sections below.
Choose the right checklist for the change that you're making:
-->

@styfle as suggested here the TS PR.

> I suggest creating the first PR that is just JS => TS.
> 
> The create a second PR that makes style changes.
> 

## Changelog

- Update react
- Migrated to typescript

## Related

vercel#40153

## Documentation / Examples

- [x] Make sure the linting passes by running `pnpm lint`
- [x] The examples guidelines are followed from [our contributing doc](https://github.com/vercel/next.js/blob/canary/contributing.md#adding-examples)
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 4, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@styfle styfle styfle requested changes

@timneutkens timneutkens Awaiting requested review from timneutkens timneutkens is a code owner

@ijjk ijjk Awaiting requested review from ijjk ijjk is a code owner

@shuding shuding Awaiting requested review from shuding shuding is a code owner

@balazsorban44 balazsorban44 Awaiting requested review from balazsorban44

Assignees
No one assigned
Labels
examples Issue/PR related to examples
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@HaNdTriX @styfle @balazsorban44 @ijjk