Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable ReactRefreshLogBox-builtins.test.ts, remove loader from import trace #41645

Merged
merged 1 commit into from Oct 22, 2022
Merged

Enable ReactRefreshLogBox-builtins.test.ts, remove loader from import trace #41645

merged 1 commit into from Oct 22, 2022

Conversation

timneutkens
Copy link
Member

Follow-up to #41598. Going to land this as the tests are failing currently because of the experimental React revert.

Bug

  • Related issues linked using fixes #number
  • Integration tests added
  • Errors have a helpful link attached, see contributing.md

Feature

  • Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR.
  • Related issues linked using fixes #number
  • Integration tests added
  • Documentation added
  • Telemetry added. In case of a feature if it's used or not.
  • Errors have a helpful link attached, see contributing.md

Documentation / Examples

  • Make sure the linting passes by running pnpm lint
  • The "examples guidelines" are followed from our contributing doc

@ijjk ijjk added created-by: Next.js team PRs by the Next.js team type: next labels Oct 22, 2022
@timneutkens timneutkens merged commit 9dae7a8 into vercel:canary Oct 22, 2022
@timneutkens timneutkens deleted the fix/loader-import-trace branch October 22, 2022 12:26
shuding pushed a commit to shuding/next.js that referenced this pull request Oct 23, 2022
@timneutkens @shuding
Enable ReactRefreshLogBox-builtins.test.ts, remove loader from import…
20db42b 
… trace (vercel#41645)
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 22, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ijjk ijjk Awaiting requested review from ijjk ijjk is a code owner

@shuding shuding Awaiting requested review from shuding shuding is a code owner

@padmaia padmaia Awaiting requested review from padmaia

@huozhi huozhi Awaiting requested review from huozhi huozhi is a code owner

Assignees
No one assigned
Labels
created-by: Next.js team PRs by the Next.js team type: next
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@timneutkens @ijjk