Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Vanilla Extract Example #50394

Merged

Conversation

SuttonJack
Copy link
Contributor

@SuttonJack SuttonJack commented May 26, 2023

What?

  • Adds an updated Vanilla Extract example
  • Note that @vanilla-extract/next-plugin currently requires experimental: { appDir: true } to be set.

Why?

-->

@SuttonJack SuttonJack requested review from a team, leerob and steven-tey as code owners May 26, 2023 15:43
@ijjk ijjk added the examples Issue/PR related to examples label May 26, 2023
leerob
leerob previously approved these changes May 26, 2023
@shuding
Copy link
Member

shuding commented May 26, 2023

Note that @vanilla-extract/next-plugin currently requires experimental: { appDir: true } to be set.

Maybe we can ship vanilla-extract-css/vanilla-extract#1099 first so that's no longer needed?

@SuttonJack
Copy link
Contributor Author

SuttonJack commented May 26, 2023

@shuding That'd be ideal

--

Edit: shipped and updated the PR - thanks!

@socket-security
Copy link

New dependency changes detected. Learn more about Socket for GitHub ↗︎


👍 No new dependency issues detected in pull request

Bot Commands

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of package-name@version specifiers. e.g. @SocketSecurity ignore foo@1.0.0 bar@* or ignore all packages with @SocketSecurity ignore-all

Pull request alert summary
Issue Status
Install scripts ✅ 0 issues
Native code ✅ 0 issues
Bin script shell injection ✅ 0 issues
Unresolved require ✅ 0 issues
Invalid package.json ✅ 0 issues
HTTP dependency ✅ 0 issues
Git dependency ✅ 0 issues
Potential typo squat ✅ 0 issues
Known Malware ✅ 0 issues
Telemetry ✅ 0 issues
Protestware/Troll package ✅ 0 issues

📊 Modified Dependency Overview:

➕ Added Package Capability Access +/- Transitive Count Publisher
@types/react@18.0.34 None +0 types

@leerob leerob enabled auto-merge (squash) May 27, 2023 01:35
@leerob leerob merged commit 27655db into vercel:canary May 27, 2023
111 checks passed
hydRAnger pushed a commit to hydRAnger/next.js that referenced this pull request Jun 12, 2023
### What?
- Adds an updated Vanilla Extract example
- ~~Note that `@vanilla-extract/next-plugin` currently requires
`experimental: { appDir: true }` to be set.~~

### Why?
- The
[documentation](https://nextjs.org/docs/app/building-your-application/styling/css-in-js)
currently links to a [personal
repo](https://github.com/SuttonJack/vanilla-extract-app-dir)
- Closes SuttonJack/vanilla-extract-app-dir#2

<p align="center"><img width="600"
src="https://github.com/vercel/next.js/assets/92991945/eeab322e-e75e-4999-9fe7-39aa15c45c11"
/></p>

-->
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 26, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
examples Issue/PR related to examples
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Moving into Next.js examples repo?
4 participants