Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

disable test case for Turbopack #50530

Merged
merged 1 commit into from May 30, 2023
Merged

disable test case for Turbopack #50530

merged 1 commit into from May 30, 2023

Conversation

sokra
Copy link
Member

@sokra sokra commented May 30, 2023 •
edited

What?

This test case was never passing and accidentally enabled for Turbopack.

We could disable the whole test suite, but since only one test case is affected we can also disable only that one.

@ijjk ijjk added area: tests created-by: Turbopack team PRs by the turbopack team labels May 30, 2023
sokra
sokra commented May 30, 2023
View reviewed changes
test/e2e/app-dir/rsc-basic/rsc-basic.test.ts
({ next, isNextDev, isNextStart }) => {
if (isNextDev) {
({ next, isNextDev, isNextStart, isTurbopack }) => {
if (isNextDev && !isTurbopack) {
it('should have correct client references keys in manifest', async () => {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Turbopack doesn't create this file

@ijjk
Copy link
Member

ijjk commented May 30, 2023

Failing test suites

Commit: efe5e58

pnpm testheadless test/development/tsconfig-path-reloading/index.test.ts

  • tsconfig-path-reloading > tsconfig > should recover from module not found when paths is updated
  • tsconfig-path-reloading > tsconfig added after starting dev > should recover from module not found when paths is updated
Expand output

● tsconfig-path-reloading › tsconfig › should recover from module not found when paths is updated

TIMED OUT: success

<head><meta charset="utf-8"><meta name="viewport" content="width=device-width"><meta name="next-head-count" content="2"><noscript data-n-css=""></noscript><script src="/_next/static/chunks/node_modules__pnpm_8b0d11._.js" defer=""></script><script src="/_next/static/chunks/components_button-1_tsx_40ce57._.js" defer=""></script><script src="/_next/static/chunks/components_button-2_tsx_9bb80a._.js" defer=""></script><script src="/_next/static/chunks/lib_second-lib_second-data_ts_76ac42._.js" defer=""></script><script src="/_next/static/chunks/lib_first-lib_first-data_ts_21e8f7._.js" defer=""></script><script src="/_next/static/chunks/_env_b53fce.js" defer=""></script><script src="/_next/static/chunks/pages_index_tsx_1ce184._.js" defer=""></script><script src="/_next/static/chunks/%5Bnext%5D_internal_shims-client_ts_f13465._.js" defer=""></script><script src="/_next/static/chunks/%5Bnext%5D_overlay_client_ts_eac06c._.js" defer=""></script><script src="/_next/static/chunks/%5Bnext%5D_dev_client_ts_bd5a09._.js" defer=""></script><script src="/_next/static/chunks/%5Bnext%5D_entry_next-hydrate_tsx_534d53._.js" defer=""></script><script src="/_next/static/chunks/%5Bnext%5D_compiled_platform_index_54c04a.js" defer=""></script><script src="/_next/static/chunks/%5Bnext%5D_compiled_css_escape_index_fb7d8b.js" defer=""></script><script src="/_next/static/chunks/%5Bnext%5D_compiled_strip-ansi_index_c52e83.js" defer=""></script><script src="/_next/static/chunks/%5Bnext%5D_compiled_stacktrace-parser_index_c28d4a.js" defer=""></script><script src="/_next/static/chunks/%5Bnext%5D_compiled_anser_index_3b1656.js" defer=""></script><script src="/_next/static/chunks/%5Bturbopack%5D_dev_client_aef2f5._.js" defer=""></script><script src="/_next/static/chunks/%5Bnext%5D_entry_next-hydrate_tsx_0b908c._.js" defer=""></script><script src="/_next/static/chunks/%5Bnext%5D_entry_next-hydrate_tsx_279b4d._.js" defer=""></script><script src="/_next/static/development/_buildManifest.js" defer=""></script></head><body><div id="__next"><button>first button</button><button>second button</button><p id="first-data">{"hello":"world"}</p><p id="second-data">{"hello":"again"}</p></div><script id="__NEXT_DATA__" type="application/json">{"props":{"pageProps":{}},"page":"/","query":{},"buildId":"development","runtimeConfig":{},"nextExport":true,"autoExport":true,"isFallback":false,"scriptLoader":[]}</script><next-route-announcer><p aria-live="assertive" id="__next-route-announcer__" role="alert" style="border: 0px; clip: rect(0px, 0px, 0px, 0px); height: 1px; margin: -1px; overflow: hidden; padding: 0px; position: absolute; top: 0px; width: 1px; white-space: nowrap; overflow-wrap: normal;"></p></next-route-announcer></body>

undefined

  569 |
  570 |   if (hardError) {
> 571 |     throw new Error('TIMED OUT: ' + regex + '\n\n' + content + '\n\n' + lastErr)
      |           ^
  572 |   }
  573 |   return false
  574 | }

  at check (lib/next-test-utils.js:571:11)
  at Object.<anonymous> (development/tsconfig-path-reloading/index.test.ts:115:9)

● tsconfig-path-reloading › tsconfig added after starting dev › should recover from module not found when paths is updated

TIMED OUT: success

<head><meta charset="utf-8"><meta name="viewport" content="width=device-width"><meta name="next-head-count" content="2"><noscript data-n-css=""></noscript><script src="/_next/static/chunks/node_modules__pnpm_8b0d11._.js" defer=""></script><script src="/_next/static/chunks/components_button-1_tsx_40ce57._.js" defer=""></script><script src="/_next/static/chunks/components_button-2_tsx_9bb80a._.js" defer=""></script><script src="/_next/static/chunks/lib_second-lib_second-data_ts_76ac42._.js" defer=""></script><script src="/_next/static/chunks/lib_first-lib_first-data_ts_21e8f7._.js" defer=""></script><script src="/_next/static/chunks/_env_b53fce.js" defer=""></script><script src="/_next/static/chunks/pages_index_tsx_1ce184._.js" defer=""></script><script src="/_next/static/chunks/%5Bnext%5D_internal_shims-client_ts_f13465._.js" defer=""></script><script src="/_next/static/chunks/%5Bnext%5D_overlay_client_ts_eac06c._.js" defer=""></script><script src="/_next/static/chunks/%5Bnext%5D_dev_client_ts_bd5a09._.js" defer=""></script><script src="/_next/static/chunks/%5Bnext%5D_entry_next-hydrate_tsx_534d53._.js" defer=""></script><script src="/_next/static/chunks/%5Bnext%5D_compiled_platform_index_54c04a.js" defer=""></script><script src="/_next/static/chunks/%5Bnext%5D_compiled_css_escape_index_fb7d8b.js" defer=""></script><script src="/_next/static/chunks/%5Bnext%5D_compiled_strip-ansi_index_c52e83.js" defer=""></script><script src="/_next/static/chunks/%5Bnext%5D_compiled_stacktrace-parser_index_c28d4a.js" defer=""></script><script src="/_next/static/chunks/%5Bnext%5D_compiled_anser_index_3b1656.js" defer=""></script><script src="/_next/static/chunks/%5Bturbopack%5D_dev_client_aef2f5._.js" defer=""></script><script src="/_next/static/chunks/%5Bnext%5D_entry_next-hydrate_tsx_0b908c._.js" defer=""></script><script src="/_next/static/chunks/%5Bnext%5D_entry_next-hydrate_tsx_279b4d._.js" defer=""></script><script src="/_next/static/development/_buildManifest.js" defer=""></script></head><body><div id="__next"><button>first button</button><button>second button</button><p id="first-data">{"hello":"world"}</p><p id="second-data">{"hello":"again"}</p></div><script id="__NEXT_DATA__" type="application/json">{"props":{"pageProps":{}},"page":"/","query":{},"buildId":"development","runtimeConfig":{},"nextExport":true,"autoExport":true,"isFallback":false,"scriptLoader":[]}</script><next-route-announcer><p aria-live="assertive" id="__next-route-announcer__" role="alert" style="border: 0px; clip: rect(0px, 0px, 0px, 0px); height: 1px; margin: -1px; overflow: hidden; padding: 0px; position: absolute; top: 0px; width: 1px; white-space: nowrap; overflow-wrap: normal;"></p></next-route-announcer></body>

undefined

  569 |
  570 |   if (hardError) {
> 571 |     throw new Error('TIMED OUT: ' + regex + '\n\n' + content + '\n\n' + lastErr)
      |           ^
  572 |   }
  573 |   return false
  574 | }

  at check (lib/next-test-utils.js:571:11)
  at Object.<anonymous> (development/tsconfig-path-reloading/index.test.ts:115:9)

Read more about building and testing Next.js in contributing.md.

@timneutkens timneutkens merged commit ffb68e9 into canary May 30, 2023
140 of 142 checks passed
@timneutkens timneutkens deleted the sokra/disable-test-case branch May 30, 2023 10:08
hydRAnger pushed a commit to hydRAnger/next.js that referenced this pull request Jun 12, 2023
@sokra @hydRAnger
disable test case for Turbopack (vercel#50530)
d57eeee 
### What?

This test case was never passing and accidentally enabled for Turbopack.

We could disable the whole test suite, but since only one test case is
affected we can also disable only that one.
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 29, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@timneutkens timneutkens timneutkens approved these changes

@ijjk ijjk ijjk approved these changes

@shuding shuding Awaiting requested review from shuding shuding is a code owner

@huozhi huozhi Awaiting requested review from huozhi huozhi is a code owner

@feedthejim feedthejim Awaiting requested review from feedthejim feedthejim is a code owner

Assignees
No one assigned
Labels
created-by: Turbopack team PRs by the turbopack team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@sokra @ijjk @timneutkens