Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stabilize New Dev Test #10188

Merged
merged 1 commit into from Jan 21, 2020
Merged

Stabilize New Dev Test #10188

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 3 additions & 1 deletion test/integration/invalid-href/test/index.test.js
View file
Open in desktop
Expand Up @@ -64,6 +64,7 @@ const showsError = async (

const noError = async (pathname, click = false) => {
const browser = await webdriver(appPort, '/')
await waitFor(2000)
await browser.eval(`(function() {
window.caughtErrors = []
window.addEventListener('error', function (error) {
Expand All @@ -74,7 +75,8 @@ const noError = async (pathname, click = false) => {
})
window.next.router.replace('${pathname}')
})()`)
await waitFor(250)
// wait for page to be built and navigated to
await waitFor(3000)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should probably look into adding a didHydration callback or something for testing instead of trying to waiting for an arbitrary amount of time 🤔

if (click) {
await browser.elementByCss('a').click()
}
Expand Down