Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use builtins for React transform #10207

Merged
merged 9 commits into from Jan 22, 2020
Merged

Use builtins for React transform #10207

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
4722270
Disable core-js on Next.js core files as it's not transforming anythi…
timneutkens Jan 21, 2020
bc4193d
Move babel options to taskr plugin
timneutkens Jan 21, 2020
85da73d
Disable transform-runtime for pages dir
timneutkens Jan 21, 2020
fc0c4a1
Disable correctly
timneutkens Jan 21, 2020
8d1e436
Disable corejs for core files
timneutkens Jan 21, 2020
ec06ce0
Temporarily check if this fixes the error
timneutkens Jan 22, 2020
de7f68c
Use builtIns and exclude async-to-generator
timneutkens Jan 22, 2020
f8ad8ce
Merge branch 'canary' of github.com:zeit/next.js into fix/disable-cor…
timneutkens Jan 22, 2020
2024296
Update index.test.js
timneutkens Jan 22, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/next/client/router.ts
View file
Open in desktop
Expand Up @@ -138,7 +138,7 @@ export function makePublicRouterInstance(router: Router): NextRouter {

for (const property of urlPropertyFields) {
if (typeof _router[property] === 'object') {
instance[property] = { ..._router[property] } // makes sure query is not stateful
instance[property] = Object.assign({}, _router[property]) // makes sure query is not stateful
continue
}

Expand Down
11 changes: 8 additions & 3 deletions packages/next/taskfile-babel.js
View file
Open in desktop
Expand Up @@ -15,10 +15,15 @@ const babelClientOpts = {
esmodules: true,
},
loose: true,
exclude: ['transform-typeof-symbol'],
// This is handled by the Next.js webpack config that will run next/babel over the same code.
exclude: [
'transform-typeof-symbol',
'transform-async-to-generator',
'transform-spread',
],
},
],
'@babel/preset-react',
['@babel/preset-react', { useBuiltIns: true }],
],
plugins: [
// workaround for @taskr/esnext bug replacing `-import` with `-require(`
Expand All @@ -31,7 +36,7 @@ const babelClientOpts = {
const babelServerOpts = {
presets: [
'@babel/preset-typescript',
'@babel/preset-react',
['@babel/preset-react', { useBuiltIns: true }],
[
'@babel/preset-env',
{
Expand Down
4 changes: 2 additions & 2 deletions test/integration/size-limit/test/index.test.js
View file
Open in desktop
Expand Up @@ -81,7 +81,7 @@ describe('Production response size', () => {
)

// These numbers are without gzip compression!
const delta = responseSizeKilobytes - 235
const delta = responseSizeKilobytes - 233
expect(delta).toBeLessThanOrEqual(0) // don't increase size
expect(delta).toBeGreaterThanOrEqual(-1) // don't decrease size without updating target
})
Expand All @@ -101,7 +101,7 @@ describe('Production response size', () => {
)

// These numbers are without gzip compression!
const delta = responseSizeKilobytes - 203
const delta = responseSizeKilobytes - 202
expect(delta).toBeLessThanOrEqual(0) // don't increase size
expect(delta).toBeGreaterThanOrEqual(-1) // don't decrease size without updating target
})
Expand Down