Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: remove --save from npm install; avoid system-ui #10252

Merged
merged 4 commits into from Jan 27, 2020
Merged

docs: remove --save from npm install; avoid system-ui #10252

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
764781e
Minor edits for CSS doc
chibicode Jan 24, 2020
f8391b5
Remove unnecessary --save from npm install
chibicode Jan 24, 2020
3f36f70
Different font family
Timer Jan 27, 2020
c7bcf14
Merge branch 'canary' into update-css
Timer Jan 27, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 2 additions & 2 deletions docs/basic-features/built-in-css-support.md
View file
Open in desktop
Expand Up @@ -15,7 +15,7 @@ For example, consider the following stylesheet named `styles.css`:

```css
body {
font-family: 'SF Pro Text', 'SF Pro Icons', system-ui;
font-family: sans-serif;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, this was partially intentional to show the property would get compiled.

Copy link
Member Author

@chibicode chibicode Jan 24, 2020 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Timer If we want to show that the style will change, how about monospace? That'll make the change obvious.

Or we can use the stack we use on Next.js site (which doesn't use system-ui).

padding: 20px 20px 60px;
max-width: 680px;
margin: 0 auto;
Expand Down Expand Up @@ -165,7 +165,7 @@ You can use component-level Sass via CSS Modules and the `.module.scss` or `.mod
Before you can use Next.js' built-in Sass support, be sure to install [`sass`](https://github.com/sass/sass):

```bash
npm install sass
npm install --save sass
chibicode marked this conversation as resolved.
Show resolved Hide resolved
```

Sass support has the same benefits and restrictions as the built-in CSS support detailed above.
Expand Down