Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement experimental pages/404.js for custom 404 page #10329

Merged
merged 13 commits into from Feb 1, 2020
Merged

Implement experimental pages/404.js for custom 404 page #10329

merged 13 commits into from Feb 1, 2020

Commits on Jan 29, 2020

  1. Implement experimental pages/404.js for custom 404 page

    @ijjk
    ijjk committed Jan 29, 2020
    Copy the full SHA
    bb4aca6 View commit details
    Browse the repository at this point in the history

  2. Make sure to show error for getInitialProps in pages/404 in dev mode … 

    …also
    @ijjk
    ijjk committed Jan 29, 2020
    Copy the full SHA
    3ede95e View commit details
    Browse the repository at this point in the history

  3. Update routes-manifest tests for new value

    @ijjk
    ijjk committed Jan 29, 2020
    Copy the full SHA
    7133860 View commit details
    Browse the repository at this point in the history

  4. Make sure page404 is boolean in routes-manifest

    @ijjk
    ijjk committed Jan 29, 2020
    Copy the full SHA
    8cd7fa7 View commit details
    Browse the repository at this point in the history

  5. Rename variables for consistency

    @ijjk
    ijjk committed Jan 29, 2020
    Copy the full SHA
    39c385e View commit details
    Browse the repository at this point in the history

Commits on Jan 30, 2020

  1. Make sure to only use 404 page for 404 error

    @ijjk
    ijjk committed Jan 30, 2020
    Copy the full SHA
    499cd63 View commit details
    Browse the repository at this point in the history

  2. Merge remote-tracking branch 'upstream/canary' into add/pages-404

    @ijjk
    ijjk committed Jan 30, 2020
    Copy the full SHA
    d882f6b View commit details
    Browse the repository at this point in the history

  3. Merge branch 'canary' into add/pages-404

    @ijjk
    ijjk committed Jan 30, 2020
    Copy the full SHA
    f78354a View commit details
    Browse the repository at this point in the history

  4. Merge branch 'add/pages-404' of github.com:ijjk/next.js into add/page… 

    …s-404
    @ijjk
    ijjk committed Jan 30, 2020
    Copy the full SHA
    3a44f89 View commit details
    Browse the repository at this point in the history

  5. Merge remote-tracking branch 'upstream/canary' into add/pages-404

    @ijjk
    ijjk committed Jan 30, 2020
    Copy the full SHA
    0875dd2 View commit details
    Browse the repository at this point in the history

  6. Merge branch 'canary' into add/pages-404

    @ijjk
    ijjk committed Jan 30, 2020
    Copy the full SHA
    0a5ff9a View commit details
    Browse the repository at this point in the history

Commits on Feb 1, 2020

  1. Merge remote-tracking branch 'upstream/canary' into add/pages-404

    @ijjk
    ijjk committed Feb 1, 2020
    Copy the full SHA
    b6beff3 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'add/pages-404' of github.com:ijjk/next.js into add/page… 

    …s-404
    @ijjk
    ijjk committed Feb 1, 2020
    Copy the full SHA
    f4deaa8 View commit details
    Browse the repository at this point in the history