Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

get the http2 example to work #10470

Merged
merged 9 commits into from Feb 10, 2020
Merged

get the http2 example to work #10470

Changes from 4 commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
5443888
copy only the necessary files during stage 2 in multi-stage.
areai51 Jan 1, 2020
c8dc6c9
update readme
areai51 Jan 1, 2020
e5468ab
adds compress:false to prevent the server from crashing while runnin…
areai51 Feb 8, 2020
eef5ece
Merge remote-tracking branch 'upstream/canary' into canary
areai51 Feb 8, 2020
abfec0e
moving the config to next.config
areai51 Feb 8, 2020
a56e9f9
link to the issue
areai51 Feb 9, 2020
d8bff8d
fix grammatical error
areai51 Feb 9, 2020
110cc1d
Update examples/with-http2/next.config.js
areai51 Feb 9, 2020
9e35bc3
Merge branch 'canary' into canary
Timer Feb 10, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
8 changes: 7 additions & 1 deletion examples/with-http2/server.js
View file
Open in desktop
Expand Up @@ -6,7 +6,13 @@ const port = parseInt(process.env.PORT, 10) || 3000
const dev = process.env.NODE_ENV !== 'production'

// Init the Next app:
const app = next({ dev })
const app = next({
dev,
conf: {
// this needs to be set false unitl to a bug in the compression npm module ets fixed.
compress: false,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be set in next.config.js, not here!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes of course!! moved it to next.config.js

},
})

// Create the secure HTTPS server:
// Don't forget to create the keys for your development
Expand Down