Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix url-polyfill dep and re-enable native-url #10726

Merged
merged 65 commits into from Feb 28, 2020
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
65 commits
Select commit Hold shift + click to select a range
0d24bde
Adding native-url package
janicklas-ralph Sep 23, 2019
252ff9b
Merge branch 'canary' of github.com:zeit/next.js into native-url
janicklas-ralph Oct 22, 2019
ec54da8
Bumping native-url version
janicklas-ralph Oct 22, 2019
bc22678
Upgrading native-url
janicklas-ralph Oct 25, 2019
22fbeb7
Merge branch 'canary' of github.com:zeit/next.js into native-url
janicklas-ralph Oct 25, 2019
c74137b
Logging stats object for debugging
janicklas-ralph Oct 25, 2019
a816aff
Logging stats object for debugging
janicklas-ralph Oct 25, 2019
465fe2d
Merge branch 'canary' into native-url
timneutkens Oct 25, 2019
aa99ed0
Merge branch 'canary' into native-url
ijjk Oct 26, 2019
50c2e7c
Merge branch 'canary' of github.com:zeit/next.js into native-url
janicklas-ralph Oct 28, 2019
5bbf585
Adding try catch to the error lines
janicklas-ralph Oct 28, 2019
49fdf55
Merge branch 'native-url' of github.com:janicklas-ralph/next.js into …
janicklas-ralph Oct 28, 2019
044dae3
Experimenting with regex
janicklas-ralph Oct 28, 2019
e45be11
Experimenting with regex
janicklas-ralph Oct 28, 2019
5458c70
Experimenting with regex
janicklas-ralph Oct 28, 2019
bf44461
Testing regex changes
janicklas-ralph Oct 28, 2019
0e0f422
Merge branch 'canary' of github.com:zeit/next.js into native-url
janicklas-ralph Oct 29, 2019
e976414
Fixing defer-script test case to not include polyfill.js
janicklas-ralph Oct 29, 2019
31c709d
Merge branch 'canary' of github.com:zeit/next.js into native-url
janicklas-ralph Oct 30, 2019
e77df8b
Merge branch 'canary' of github.com:zeit/next.js into native-url
janicklas-ralph Nov 5, 2019
96e4456
Meging changes with existing polyfill work
janicklas-ralph Nov 5, 2019
6134036
Merge branch 'canary' of github.com:zeit/next.js into native-url
janicklas-ralph Nov 19, 2019
587783a
Merge branch 'canary' of github.com:zeit/next.js into native-url
janicklas-ralph Nov 25, 2019
8431e0a
Bumping version
janicklas-ralph Nov 25, 2019
62c15ac
adjust webpack config
Timer Nov 25, 2019
98f5742
Reduce size in size test
Timer Nov 25, 2019
9183fa2
Merge branch 'canary' into native-url
Timer Nov 25, 2019
ba8e6da
Remove 1kb from legacy
Timer Nov 25, 2019
57df7e3
Merge branch 'canary' into native-url
Timer Nov 25, 2019
0ee9952
Merge branch 'canary' into native-url
Timer Nov 25, 2019
3af4325
Bumping native-url version, includes fix for IE11
janicklas-ralph Nov 26, 2019
ae4ed5a
Merge branch 'native-url' of github.com:janicklas-ralph/next.js into …
janicklas-ralph Nov 26, 2019
ad7b0a7
Merge branch 'canary' of github.com:zeit/next.js into native-url
janicklas-ralph Nov 26, 2019
d9b07f2
Update lock file
Timer Nov 26, 2019
e81dc2f
Merge branch 'canary' of github.com:zeit/next.js into native-url
janicklas-ralph Nov 26, 2019
1321a6c
Merge branch 'canary' of github.com:zeit/next.js into native-url
janicklas-ralph Nov 27, 2019
1cb4e98
Updating native-url, fixes issue on IE11
janicklas-ralph Nov 27, 2019
6952517
Merge branch 'native-url' of github.com:janicklas-ralph/next.js into …
janicklas-ralph Nov 27, 2019
80b3d56
Fix sourcemap being added in document
janicklas-ralph Dec 4, 2019
d70af64
Merge branch 'canary' of github.com:zeit/next.js into native-url
janicklas-ralph Dec 4, 2019
a24cc59
Merge branch 'canary' into native-url
janicklas-ralph Dec 4, 2019
65d0646
Merge branch 'native-url' of github.com:janicklas-ralph/next.js into …
janicklas-ralph Dec 4, 2019
054c9eb
Merge branch 'canary' into native-url
Timer Dec 5, 2019
024fa44
Merge branch 'canary' into native-url
Timer Dec 5, 2019
ed0d65a
Merge branch 'canary' of github.com:zeit/next.js into native-url
janicklas-ralph Dec 5, 2019
1c3a145
Adding Router as an app level dep. Fixes Router not being added as a …
janicklas-ralph Dec 9, 2019
9cf2881
Merge branch 'canary' of github.com:zeit/next.js into native-url
janicklas-ralph Dec 9, 2019
86e0940
Merge branch 'native-url' of github.com:janicklas-ralph/next.js into …
janicklas-ralph Dec 9, 2019
356edee
Fix typescript error
janicklas-ralph Dec 9, 2019
9661e19
Merge branch 'canary' of github.com:zeit/next.js into native-url
janicklas-ralph Dec 12, 2019
9272b59
Fix modern + granularChunks hydration failing
janicklas-ralph Dec 12, 2019
a575d5b
Fix TS error
janicklas-ralph Dec 12, 2019
d72eb98
Merge branch 'canary' of github.com:zeit/next.js into native-url
janicklas-ralph Dec 16, 2019
d9c593e
Update native-url version
janicklas-ralph Dec 16, 2019
51be1b0
Merge branch 'canary' into native-url
Timer Jan 14, 2020
a93355e
Merge branch 'canary' of github.com:zeit/next.js into native-url
janicklas-ralph Feb 14, 2020
72b7243
Merge branch 'canary' of github.com:zeit/next.js into native-url
janicklas-ralph Feb 14, 2020
a323b44
Adding native-url with safari fix
janicklas-ralph Feb 14, 2020
84d8b6d
Merge branch 'native-url' of github.com:janicklas-ralph/next.js into …
janicklas-ralph Feb 14, 2020
dd1f2f2
Merge branch 'canary' into native-url
Timer Feb 21, 2020
a160364
Merge branch 'canary' of github.com:zeit/next.js into native-url
janicklas-ralph Feb 28, 2020
2485d0a
Update url-polyfill in polyfill-nomodule package
janicklas-ralph Feb 28, 2020
6242b95
Merge branch 'native-url' of github.com:janicklas-ralph/next.js into …
janicklas-ralph Feb 28, 2020
51c5790
Remove url-polyfill from next package.json
janicklas-ralph Feb 28, 2020
03da713
Merge branch 'canary' into native-url
Timer Feb 28, 2020
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/next-polyfill-nomodule/package.json
Expand Up @@ -13,7 +13,7 @@
"microbundle": "0.11.0",
"object-assign": "4.1.1",
"promise-polyfill": "8.1.3",
"url-polyfill": "1.1.7",
"url-polyfill": "1.1.8",
"whatwg-fetch": "3.0.0"
}
}
5 changes: 2 additions & 3 deletions packages/next/build/webpack-config.ts
Expand Up @@ -88,9 +88,8 @@ function getOptimizedAliases(isServer: boolean): { [pkg: string]: string } {
'object.assign/polyfill': path.join(shimAssign, 'polyfill.js'),
'object.assign/shim': path.join(shimAssign, 'shim.js'),

// TODO: re-enable when `native-url` supports Safari 10
// // Replace: full URL polyfill with platform-based polyfill
// url: require.resolve('native-url'),
// Replace: full URL polyfill with platform-based polyfill
url: require.resolve('native-url'),
}
)
}
Expand Down
2 changes: 1 addition & 1 deletion packages/next/package.json
Expand Up @@ -115,6 +115,7 @@
"lru-cache": "5.1.1",
"mini-css-extract-plugin": "0.8.0",
"mkdirp": "0.5.1",
"native-url": "0.2.6",
"node-fetch": "2.6.0",
"ora": "3.4.0",
"path-to-regexp": "6.1.0",
Expand All @@ -140,7 +141,6 @@
"thread-loader": "2.1.3",
"unfetch": "4.1.0",
"url": "0.11.0",
"url-polyfill": "1.1.7",
"use-subscription": "1.1.1",
"watchpack": "2.0.0-beta.13",
"webpack": "4.41.2",
Expand Down
4 changes: 2 additions & 2 deletions test/integration/size-limit/test/index.test.js
Expand Up @@ -80,7 +80,7 @@ describe('Production response size', () => {
)

// These numbers are without gzip compression!
const delta = responseSizesBytes - 237 * 1024
const delta = responseSizesBytes - 230 * 1024
expect(delta).toBeLessThanOrEqual(1024) // don't increase size more than 1kb
expect(delta).toBeGreaterThanOrEqual(-1024) // don't decrease size more than 1kb without updating target
})
Expand All @@ -100,7 +100,7 @@ describe('Production response size', () => {
)

// These numbers are without gzip compression!
const delta = responseSizesBytes - 171 * 1024
const delta = responseSizesBytes - 163 * 1024
expect(delta).toBeLessThanOrEqual(1024) // don't increase size more than 1kb
expect(delta).toBeGreaterThanOrEqual(-1024) // don't decrease size more than 1kb without updating target
})
Expand Down
15 changes: 11 additions & 4 deletions yarn.lock
Expand Up @@ -10953,6 +10953,13 @@ native-or-bluebird@^1.2.0:
resolved "https://registry.yarnpkg.com/native-or-bluebird/-/native-or-bluebird-1.2.0.tgz#39c47bfd7825d1fb9ffad32210ae25daadf101c9"
integrity sha1-OcR7/Xgl0fuf+tMiEK4l2q3xAck=

native-url@0.2.6:
version "0.2.6"
resolved "https://registry.yarnpkg.com/native-url/-/native-url-0.2.6.tgz#ca1258f5ace169c716ff44eccbddb674e10399ae"
integrity sha512-k4bDC87WtgrdD362gZz6zoiXQrl40kYlBmpfmSjwRO1VU0V5ccwJTlxuE72F6m3V0vc1xOf6n3UCP9QyerRqmA==
dependencies:
querystring "^0.2.0"

natural-compare@^1.4.0:
version "1.4.0"
resolved "https://registry.yarnpkg.com/natural-compare/-/natural-compare-1.4.0.tgz#4abebfeed7541f2c27acfb29bdbbd15c8d5ba4f7"
Expand Down Expand Up @@ -16552,10 +16559,10 @@ url-parse-lax@^3.0.0:
dependencies:
prepend-http "^2.0.0"

url-polyfill@1.1.7:
version "1.1.7"
resolved "https://registry.yarnpkg.com/url-polyfill/-/url-polyfill-1.1.7.tgz#402ee84360eb549bbeb585f4c7971e79a31de9e3"
integrity sha512-ZrAxYWCREjmMtL8gSbSiKKLZZticgihCvVBtrFbUVpyoETt8GQJeG2okMWA8XryDAaHMjJfhnc+rnhXRbI4DXA==
url-polyfill@1.1.8:
version "1.1.8"
resolved "https://registry.yarnpkg.com/url-polyfill/-/url-polyfill-1.1.8.tgz#21eb58ad61192f52b77dcac8ab5293ae7bc67060"
integrity sha512-Ey61F4FEqhcu1vHSOMmjl0Vd/RPRLEjMj402qszD/dhMBrVfoUsnIj8KSZo2yj+eIlxJGKFdnm6ES+7UzMgZ3Q==

url-template@^2.0.8:
version "2.0.8"
Expand Down