Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New example: with-relay-modern-typescript #10790

Closed
wants to merge 7 commits into from
Closed

New example: with-relay-modern-typescript #10790

wants to merge 7 commits into from

Conversation

bdombro
Copy link
Contributor

@bdombro bdombro commented Mar 2, 2020

This new example is literally the same as examples/with-relay-modern except with typescript.

@ijjk
Copy link
Member

ijjk commented Mar 2, 2020

Stats from current PR

Default Server Mode
General
zeit/next.js canary bdombro/next.js with-relay-modern-typescript-example Change
buildDuration 9.8s 9.9s ⚠️ +93ms
nodeModulesSize 56.3 MB 56.3 MB ✓
Client Bundles (main, webpack, commons)
zeit/next.js canary bdombro/next.js with-relay-modern-typescript-example Change
main-HASH.js gzip 5.41 kB 5.41 kB ✓
webpack-HASH.js gzip 746 B 746 B ✓
de003c3a9d30..7030.js gzip 9.68 kB 9.68 kB ✓
framework.HASH.js gzip 39.1 kB 39.1 kB ✓
Overall change 55 kB 55 kB ✓
Client Bundles (main, webpack, commons) Modern
zeit/next.js canary bdombro/next.js with-relay-modern-typescript-example Change
main-HASH.module.js gzip 4.44 kB 4.44 kB ✓
webpack-HASH..dule.js gzip 746 B 746 B ✓
de003c3a9d30..dule.js gzip 6.63 kB 6.63 kB ✓
framework.HA..dule.js gzip 39.1 kB 39.1 kB ✓
Overall change 51 kB 51 kB ✓
Legacy Client Bundles (polyfills)
zeit/next.js canary bdombro/next.js with-relay-modern-typescript-example Change
polyfills-HASH.js gzip 18.9 kB 18.9 kB ✓
Overall change 18.9 kB 18.9 kB ✓
Client Pages
zeit/next.js canary bdombro/next.js with-relay-modern-typescript-example Change
_app.js gzip 1.07 kB 1.07 kB ✓
_error.js gzip 2.98 kB 2.98 kB ✓
hooks.js gzip 664 B 664 B ✓
index.js gzip 222 B 222 B ✓
link.js gzip 1.89 kB 1.89 kB ✓
routerDirect.js gzip 279 B 279 B ✓
withRouter.js gzip 278 B 278 B ✓
Overall change 7.38 kB 7.38 kB ✓
Client Pages Modern
zeit/next.js canary bdombro/next.js with-relay-modern-typescript-example Change
_app.module.js gzip 589 B 589 B ✓
_error.module.js gzip 2.08 kB 2.08 kB ✓
hooks.module.js gzip 370 B 370 B ✓
index.module.js gzip 212 B 212 B ✓
link.module.js gzip 1.48 kB 1.48 kB ✓
routerDirect..dule.js gzip 271 B 271 B ✓
withRouter.m..dule.js gzip 270 B 270 B ✓
Overall change 5.27 kB 5.27 kB ✓
Client Build Manifests
zeit/next.js canary bdombro/next.js with-relay-modern-typescript-example Change
_buildManifest.js gzip 61 B 61 B ✓
_buildManife..dule.js gzip 61 B 61 B ✓
Overall change 122 B 122 B ✓
Rendered Page Sizes
zeit/next.js canary bdombro/next.js with-relay-modern-typescript-example Change
index.html gzip 925 B 925 B ✓
link.html gzip 935 B 935 B ✓
withRouter.html gzip 923 B 923 B ✓
Overall change 2.78 kB 2.78 kB ✓
Serverless Mode (Decrease detected ✓)
General
zeit/next.js canary bdombro/next.js with-relay-modern-typescript-example Change
buildDuration 10.5s 10.6s ⚠️ +54ms
nodeModulesSize 56.3 MB 56.3 MB ✓
Client Bundles (main, webpack, commons)
zeit/next.js canary bdombro/next.js with-relay-modern-typescript-example Change
main-HASH.js gzip 5.41 kB 5.41 kB ✓
webpack-HASH.js gzip 746 B 746 B ✓
de003c3a9d30..7030.js gzip 9.68 kB 9.68 kB ✓
framework.HASH.js gzip 39.1 kB 39.1 kB ✓
Overall change 55 kB 55 kB ✓
Client Bundles (main, webpack, commons) Modern
zeit/next.js canary bdombro/next.js with-relay-modern-typescript-example Change
main-HASH.module.js gzip 4.44 kB 4.44 kB ✓
webpack-HASH..dule.js gzip 746 B 746 B ✓
de003c3a9d30..dule.js gzip 6.63 kB 6.63 kB ✓
framework.HA..dule.js gzip 39.1 kB 39.1 kB ✓
Overall change 51 kB 51 kB ✓
Legacy Client Bundles (polyfills)
zeit/next.js canary bdombro/next.js with-relay-modern-typescript-example Change
polyfills-HASH.js gzip 18.9 kB 18.9 kB ✓
Overall change 18.9 kB 18.9 kB ✓
Client Pages
zeit/next.js canary bdombro/next.js with-relay-modern-typescript-example Change
_app.js gzip 1.07 kB 1.07 kB ✓
_error.js gzip 2.98 kB 2.98 kB ✓
hooks.js gzip 664 B 664 B ✓
index.js gzip 222 B 222 B ✓
link.js gzip 1.89 kB 1.89 kB ✓
routerDirect.js gzip 279 B 279 B ✓
withRouter.js gzip 278 B 278 B ✓
Overall change 7.38 kB 7.38 kB ✓
Client Pages Modern
zeit/next.js canary bdombro/next.js with-relay-modern-typescript-example Change
_app.module.js gzip 589 B 589 B ✓
_error.module.js gzip 2.08 kB 2.08 kB ✓
hooks.module.js gzip 370 B 370 B ✓
index.module.js gzip 212 B 212 B ✓
link.module.js gzip 1.48 kB 1.48 kB ✓
routerDirect..dule.js gzip 271 B 271 B ✓
withRouter.m..dule.js gzip 270 B 270 B ✓
Overall change 5.27 kB 5.27 kB ✓
Client Build Manifests
zeit/next.js canary bdombro/next.js with-relay-modern-typescript-example Change
_buildManifest.js gzip 61 B 61 B ✓
_buildManife..dule.js gzip 61 B 61 B ✓
Overall change 122 B 122 B ✓
Serverless bundles Overall decrease ✓
zeit/next.js canary bdombro/next.js with-relay-modern-typescript-example Change
_error.js gzip 292 kB 292 kB -100 B
404.html gzip 1.33 kB 1.33 kB ✓
hooks.html gzip 964 B 964 B ✓
index.js gzip 292 kB 292 kB -187 B
link.js gzip 299 kB 300 kB ⚠️ +296 B
routerDirect.js gzip 299 kB 298 kB -1.19 kB
withRouter.js gzip 298 kB 298 kB -34 B
Overall change 1.48 MB 1.48 MB -1.21 kB

Commit: 1285a64

@ijjk
Copy link
Member

ijjk commented Mar 4, 2020

Stats from current PR

Default Server Mode
General
zeit/next.js canary bdombro/next.js with-relay-modern-typescript-example Change
buildDuration 9.6s 9.6s -55ms
nodeModulesSize 56.3 MB 56.3 MB ✓
Client Bundles (main, webpack, commons)
zeit/next.js canary bdombro/next.js with-relay-modern-typescript-example Change
main-HASH.js gzip 5.76 kB 5.76 kB ✓
webpack-HASH.js gzip 746 B 746 B ✓
de003c3a9d30..67cb.js gzip 9.69 kB 9.69 kB ✓
framework.HASH.js gzip 39.1 kB 39.1 kB ✓
Overall change 55.3 kB 55.3 kB ✓
Client Bundles (main, webpack, commons) Modern
zeit/next.js canary bdombro/next.js with-relay-modern-typescript-example Change
main-HASH.module.js gzip 4.79 kB 4.79 kB ✓
webpack-HASH..dule.js gzip 746 B 746 B ✓
de003c3a9d30..dule.js gzip 6.64 kB 6.64 kB ✓
framework.HA..dule.js gzip 39.1 kB 39.1 kB ✓
Overall change 51.3 kB 51.3 kB ✓
Legacy Client Bundles (polyfills)
zeit/next.js canary bdombro/next.js with-relay-modern-typescript-example Change
polyfills-HASH.js gzip 18.9 kB 18.9 kB ✓
Overall change 18.9 kB 18.9 kB ✓
Client Pages
zeit/next.js canary bdombro/next.js with-relay-modern-typescript-example Change
_app.js gzip 1.07 kB 1.07 kB ✓
_error.js gzip 2.98 kB 2.98 kB ✓
hooks.js gzip 664 B 664 B ✓
index.js gzip 222 B 222 B ✓
link.js gzip 1.89 kB 1.89 kB ✓
routerDirect.js gzip 279 B 279 B ✓
withRouter.js gzip 278 B 278 B ✓
Overall change 7.38 kB 7.38 kB ✓
Client Pages Modern
zeit/next.js canary bdombro/next.js with-relay-modern-typescript-example Change
_app.module.js gzip 589 B 589 B ✓
_error.module.js gzip 2.08 kB 2.08 kB ✓
hooks.module.js gzip 370 B 370 B ✓
index.module.js gzip 212 B 212 B ✓
link.module.js gzip 1.48 kB 1.48 kB ✓
routerDirect..dule.js gzip 271 B 271 B ✓
withRouter.m..dule.js gzip 270 B 270 B ✓
Overall change 5.27 kB 5.27 kB ✓
Client Build Manifests
zeit/next.js canary bdombro/next.js with-relay-modern-typescript-example Change
_buildManifest.js gzip 61 B 61 B ✓
_buildManife..dule.js gzip 61 B 61 B ✓
Overall change 122 B 122 B ✓
Rendered Page Sizes
zeit/next.js canary bdombro/next.js with-relay-modern-typescript-example Change
index.html gzip 936 B 936 B ✓
link.html gzip 946 B 946 B ✓
withRouter.html gzip 934 B 934 B ✓
Overall change 2.82 kB 2.82 kB ✓
Serverless Mode (Increase detected ⚠️)
General
zeit/next.js canary bdombro/next.js with-relay-modern-typescript-example Change
buildDuration 10.3s 10.3s ⚠️ +70ms
nodeModulesSize 56.3 MB 56.3 MB ✓
Client Bundles (main, webpack, commons)
zeit/next.js canary bdombro/next.js with-relay-modern-typescript-example Change
main-HASH.js gzip 5.76 kB 5.76 kB ✓
webpack-HASH.js gzip 746 B 746 B ✓
de003c3a9d30..67cb.js gzip 9.69 kB 9.69 kB ✓
framework.HASH.js gzip 39.1 kB 39.1 kB ✓
Overall change 55.3 kB 55.3 kB ✓
Client Bundles (main, webpack, commons) Modern
zeit/next.js canary bdombro/next.js with-relay-modern-typescript-example Change
main-HASH.module.js gzip 4.79 kB 4.79 kB ✓
webpack-HASH..dule.js gzip 746 B 746 B ✓
de003c3a9d30..dule.js gzip 6.64 kB 6.64 kB ✓
framework.HA..dule.js gzip 39.1 kB 39.1 kB ✓
Overall change 51.3 kB 51.3 kB ✓
Legacy Client Bundles (polyfills)
zeit/next.js canary bdombro/next.js with-relay-modern-typescript-example Change
polyfills-HASH.js gzip 18.9 kB 18.9 kB ✓
Overall change 18.9 kB 18.9 kB ✓
Client Pages
zeit/next.js canary bdombro/next.js with-relay-modern-typescript-example Change
_app.js gzip 1.07 kB 1.07 kB ✓
_error.js gzip 2.98 kB 2.98 kB ✓
hooks.js gzip 664 B 664 B ✓
index.js gzip 222 B 222 B ✓
link.js gzip 1.89 kB 1.89 kB ✓
routerDirect.js gzip 279 B 279 B ✓
withRouter.js gzip 278 B 278 B ✓
Overall change 7.38 kB 7.38 kB ✓
Client Pages Modern
zeit/next.js canary bdombro/next.js with-relay-modern-typescript-example Change
_app.module.js gzip 589 B 589 B ✓
_error.module.js gzip 2.08 kB 2.08 kB ✓
hooks.module.js gzip 370 B 370 B ✓
index.module.js gzip 212 B 212 B ✓
link.module.js gzip 1.48 kB 1.48 kB ✓
routerDirect..dule.js gzip 271 B 271 B ✓
withRouter.m..dule.js gzip 270 B 270 B ✓
Overall change 5.27 kB 5.27 kB ✓
Client Build Manifests
zeit/next.js canary bdombro/next.js with-relay-modern-typescript-example Change
_buildManifest.js gzip 61 B 61 B ✓
_buildManife..dule.js gzip 61 B 61 B ✓
Overall change 122 B 122 B ✓
Serverless bundles Overall increase ⚠️
zeit/next.js canary bdombro/next.js with-relay-modern-typescript-example Change
_error.js gzip 292 kB 292 kB ⚠️ +1 B
404.html gzip 1.34 kB 1.34 kB ✓
hooks.html gzip 975 B 975 B ✓
index.js gzip 292 kB 292 kB ⚠️ +72 B
link.js gzip 299 kB 300 kB ⚠️ +778 B
routerDirect.js gzip 298 kB 298 kB -348 B
withRouter.js gzip 299 kB 299 kB ⚠️ +66 B
Overall change 1.48 MB 1.48 MB ⚠️ +569 B

@ijjk
Copy link
Member

ijjk commented Mar 15, 2020

Stats from current PR

Default Server Mode
General
zeit/next.js canary bdombro/next.js with-relay-modern-typescript-example Change
buildDuration 9.7s 9.5s -125ms
nodeModulesSize 54.8 MB 54.8 MB ✓
Client Bundles (main, webpack, commons)
zeit/next.js canary bdombro/next.js with-relay-modern-typescript-example Change
main-HASH.js gzip 5.77 kB 5.77 kB ✓
webpack-HASH.js gzip 746 B 746 B ✓
de003c3a9d30..8eb0.js gzip 9.78 kB 9.78 kB ✓
framework.HASH.js gzip 39.1 kB 39.1 kB ✓
Overall change 55.4 kB 55.4 kB ✓
Client Bundles (main, webpack, commons) Modern
zeit/next.js canary bdombro/next.js with-relay-modern-typescript-example Change
main-HASH.module.js gzip 4.78 kB 4.78 kB ✓
webpack-HASH..dule.js gzip 746 B 746 B ✓
de003c3a9d30..dule.js gzip 6.71 kB 6.71 kB ✓
framework.HA..dule.js gzip 39.1 kB 39.1 kB ✓
Overall change 51.4 kB 51.4 kB ✓
Legacy Client Bundles (polyfills)
zeit/next.js canary bdombro/next.js with-relay-modern-typescript-example Change
polyfills-HASH.js gzip 26.3 kB 26.3 kB ✓
Overall change 26.3 kB 26.3 kB ✓
Client Pages
zeit/next.js canary bdombro/next.js with-relay-modern-typescript-example Change
_app.js gzip 1.09 kB 1.09 kB ✓
_error.js gzip 2.97 kB 2.97 kB ✓
hooks.js gzip 664 B 664 B ✓
index.js gzip 222 B 222 B ✓
link.js gzip 1.89 kB 1.89 kB ✓
routerDirect.js gzip 279 B 279 B ✓
withRouter.js gzip 278 B 278 B ✓
Overall change 7.39 kB 7.39 kB ✓
Client Pages Modern
zeit/next.js canary bdombro/next.js with-relay-modern-typescript-example Change
_app.module.js gzip 594 B 594 B ✓
_error.module.js gzip 2.08 kB 2.08 kB ✓
hooks.module.js gzip 370 B 370 B ✓
index.module.js gzip 212 B 212 B ✓
link.module.js gzip 1.48 kB 1.48 kB ✓
routerDirect..dule.js gzip 271 B 271 B ✓
withRouter.m..dule.js gzip 270 B 270 B ✓
Overall change 5.28 kB 5.28 kB ✓
Client Build Manifests
zeit/next.js canary bdombro/next.js with-relay-modern-typescript-example Change
_buildManifest.js gzip 61 B 61 B ✓
_buildManife..dule.js gzip 61 B 61 B ✓
Overall change 122 B 122 B ✓
Rendered Page Sizes
zeit/next.js canary bdombro/next.js with-relay-modern-typescript-example Change
index.html gzip 916 B 916 B ✓
link.html gzip 926 B 926 B ✓
withRouter.html gzip 913 B 913 B ✓
Overall change 2.75 kB 2.75 kB ✓
Serverless Mode (Increase detected ⚠️)
General
zeit/next.js canary bdombro/next.js with-relay-modern-typescript-example Change
buildDuration 10.5s 10.3s -231ms
nodeModulesSize 54.8 MB 54.8 MB ✓
Client Bundles (main, webpack, commons)
zeit/next.js canary bdombro/next.js with-relay-modern-typescript-example Change
main-HASH.js gzip 5.77 kB 5.77 kB ✓
webpack-HASH.js gzip 746 B 746 B ✓
de003c3a9d30..8eb0.js gzip 9.78 kB 9.78 kB ✓
framework.HASH.js gzip 39.1 kB 39.1 kB ✓
Overall change 55.4 kB 55.4 kB ✓
Client Bundles (main, webpack, commons) Modern
zeit/next.js canary bdombro/next.js with-relay-modern-typescript-example Change
main-HASH.module.js gzip 4.78 kB 4.78 kB ✓
webpack-HASH..dule.js gzip 746 B 746 B ✓
de003c3a9d30..dule.js gzip 6.71 kB 6.71 kB ✓
framework.HA..dule.js gzip 39.1 kB 39.1 kB ✓
Overall change 51.4 kB 51.4 kB ✓
Legacy Client Bundles (polyfills)
zeit/next.js canary bdombro/next.js with-relay-modern-typescript-example Change
polyfills-HASH.js gzip 26.3 kB 26.3 kB ✓
Overall change 26.3 kB 26.3 kB ✓
Client Pages
zeit/next.js canary bdombro/next.js with-relay-modern-typescript-example Change
_app.js gzip 1.09 kB 1.09 kB ✓
_error.js gzip 2.97 kB 2.97 kB ✓
hooks.js gzip 664 B 664 B ✓
index.js gzip 222 B 222 B ✓
link.js gzip 1.89 kB 1.89 kB ✓
routerDirect.js gzip 279 B 279 B ✓
withRouter.js gzip 278 B 278 B ✓
Overall change 7.39 kB 7.39 kB ✓
Client Pages Modern
zeit/next.js canary bdombro/next.js with-relay-modern-typescript-example Change
_app.module.js gzip 594 B 594 B ✓
_error.module.js gzip 2.08 kB 2.08 kB ✓
hooks.module.js gzip 370 B 370 B ✓
index.module.js gzip 212 B 212 B ✓
link.module.js gzip 1.48 kB 1.48 kB ✓
routerDirect..dule.js gzip 271 B 271 B ✓
withRouter.m..dule.js gzip 270 B 270 B ✓
Overall change 5.28 kB 5.28 kB ✓
Client Build Manifests
zeit/next.js canary bdombro/next.js with-relay-modern-typescript-example Change
_buildManifest.js gzip 61 B 61 B ✓
_buildManife..dule.js gzip 61 B 61 B ✓
Overall change 122 B 122 B ✓
Serverless bundles Overall increase ⚠️
zeit/next.js canary bdombro/next.js with-relay-modern-typescript-example Change
_error.js gzip 293 kB 293 kB ⚠️ +494 B
404.html gzip 1.32 kB 1.32 kB ✓
hooks.html gzip 956 B 956 B ✓
index.js gzip 293 kB 293 kB ⚠️ +298 B
link.js gzip 301 kB 301 kB -170 B
routerDirect.js gzip 300 kB 300 kB ⚠️ +245 B
withRouter.js gzip 300 kB 300 kB -51 B
Overall change 1.49 MB 1.49 MB ⚠️ +816 B

@ijjk
Copy link
Member

ijjk commented Mar 15, 2020

Stats from current PR

Default Server Mode
General
zeit/next.js canary bdombro/next.js with-relay-modern-typescript-example Change
buildDuration 11.1s 11.3s ⚠️ +172ms
nodeModulesSize 54.8 MB 54.8 MB ✓
Client Bundles (main, webpack, commons)
zeit/next.js canary bdombro/next.js with-relay-modern-typescript-example Change
main-HASH.js gzip 5.77 kB 5.77 kB ✓
webpack-HASH.js gzip 746 B 746 B ✓
de003c3a9d30..8eb0.js gzip 9.78 kB 9.78 kB ✓
framework.HASH.js gzip 39.1 kB 39.1 kB ✓
Overall change 55.4 kB 55.4 kB ✓
Client Bundles (main, webpack, commons) Modern
zeit/next.js canary bdombro/next.js with-relay-modern-typescript-example Change
main-HASH.module.js gzip 4.78 kB 4.78 kB ✓
webpack-HASH..dule.js gzip 746 B 746 B ✓
de003c3a9d30..dule.js gzip 6.71 kB 6.71 kB ✓
framework.HA..dule.js gzip 39.1 kB 39.1 kB ✓
Overall change 51.4 kB 51.4 kB ✓
Legacy Client Bundles (polyfills)
zeit/next.js canary bdombro/next.js with-relay-modern-typescript-example Change
polyfills-HASH.js gzip 26.3 kB 26.3 kB ✓
Overall change 26.3 kB 26.3 kB ✓
Client Pages
zeit/next.js canary bdombro/next.js with-relay-modern-typescript-example Change
_app.js gzip 1.09 kB 1.09 kB ✓
_error.js gzip 2.97 kB 2.97 kB ✓
hooks.js gzip 664 B 664 B ✓
index.js gzip 222 B 222 B ✓
link.js gzip 1.89 kB 1.89 kB ✓
routerDirect.js gzip 279 B 279 B ✓
withRouter.js gzip 278 B 278 B ✓
Overall change 7.39 kB 7.39 kB ✓
Client Pages Modern
zeit/next.js canary bdombro/next.js with-relay-modern-typescript-example Change
_app.module.js gzip 594 B 594 B ✓
_error.module.js gzip 2.08 kB 2.08 kB ✓
hooks.module.js gzip 370 B 370 B ✓
index.module.js gzip 212 B 212 B ✓
link.module.js gzip 1.48 kB 1.48 kB ✓
routerDirect..dule.js gzip 271 B 271 B ✓
withRouter.m..dule.js gzip 270 B 270 B ✓
Overall change 5.28 kB 5.28 kB ✓
Client Build Manifests
zeit/next.js canary bdombro/next.js with-relay-modern-typescript-example Change
_buildManifest.js gzip 61 B 61 B ✓
_buildManife..dule.js gzip 61 B 61 B ✓
Overall change 122 B 122 B ✓
Rendered Page Sizes
zeit/next.js canary bdombro/next.js with-relay-modern-typescript-example Change
index.html gzip 916 B 916 B ✓
link.html gzip 926 B 926 B ✓
withRouter.html gzip 913 B 913 B ✓
Overall change 2.75 kB 2.75 kB ✓
Serverless Mode (Increase detected ⚠️)
General
zeit/next.js canary bdombro/next.js with-relay-modern-typescript-example Change
buildDuration 12.1s 12s -77ms
nodeModulesSize 54.8 MB 54.8 MB ✓
Client Bundles (main, webpack, commons)
zeit/next.js canary bdombro/next.js with-relay-modern-typescript-example Change
main-HASH.js gzip 5.77 kB 5.77 kB ✓
webpack-HASH.js gzip 746 B 746 B ✓
de003c3a9d30..8eb0.js gzip 9.78 kB 9.78 kB ✓
framework.HASH.js gzip 39.1 kB 39.1 kB ✓
Overall change 55.4 kB 55.4 kB ✓
Client Bundles (main, webpack, commons) Modern
zeit/next.js canary bdombro/next.js with-relay-modern-typescript-example Change
main-HASH.module.js gzip 4.78 kB 4.78 kB ✓
webpack-HASH..dule.js gzip 746 B 746 B ✓
de003c3a9d30..dule.js gzip 6.71 kB 6.71 kB ✓
framework.HA..dule.js gzip 39.1 kB 39.1 kB ✓
Overall change 51.4 kB 51.4 kB ✓
Legacy Client Bundles (polyfills)
zeit/next.js canary bdombro/next.js with-relay-modern-typescript-example Change
polyfills-HASH.js gzip 26.3 kB 26.3 kB ✓
Overall change 26.3 kB 26.3 kB ✓
Client Pages
zeit/next.js canary bdombro/next.js with-relay-modern-typescript-example Change
_app.js gzip 1.09 kB 1.09 kB ✓
_error.js gzip 2.97 kB 2.97 kB ✓
hooks.js gzip 664 B 664 B ✓
index.js gzip 222 B 222 B ✓
link.js gzip 1.89 kB 1.89 kB ✓
routerDirect.js gzip 279 B 279 B ✓
withRouter.js gzip 278 B 278 B ✓
Overall change 7.39 kB 7.39 kB ✓
Client Pages Modern
zeit/next.js canary bdombro/next.js with-relay-modern-typescript-example Change
_app.module.js gzip 594 B 594 B ✓
_error.module.js gzip 2.08 kB 2.08 kB ✓
hooks.module.js gzip 370 B 370 B ✓
index.module.js gzip 212 B 212 B ✓
link.module.js gzip 1.48 kB 1.48 kB ✓
routerDirect..dule.js gzip 271 B 271 B ✓
withRouter.m..dule.js gzip 270 B 270 B ✓
Overall change 5.28 kB 5.28 kB ✓
Client Build Manifests
zeit/next.js canary bdombro/next.js with-relay-modern-typescript-example Change
_buildManifest.js gzip 61 B 61 B ✓
_buildManife..dule.js gzip 61 B 61 B ✓
Overall change 122 B 122 B ✓
Serverless bundles Overall increase ⚠️
zeit/next.js canary bdombro/next.js with-relay-modern-typescript-example Change
_error.js gzip 293 kB 293 kB ⚠️ +446 B
404.html gzip 1.32 kB 1.32 kB ✓
hooks.html gzip 956 B 956 B ✓
index.js gzip 294 kB 293 kB -485 B
link.js gzip 301 kB 302 kB ⚠️ +865 B
routerDirect.js gzip 300 kB 300 kB ⚠️ +63 B
withRouter.js gzip 300 kB 300 kB -230 B
Overall change 1.49 MB 1.49 MB ⚠️ +659 B

@ijjk
Copy link
Member

ijjk commented Mar 16, 2020

Stats from current PR

Default Server Mode
General
zeit/next.js canary bdombro/next.js with-relay-modern-typescript-example Change
buildDuration 10.2s 10.3s ⚠️ +17ms
nodeModulesSize 54.8 MB 54.8 MB ✓
Client Bundles (main, webpack, commons)
zeit/next.js canary bdombro/next.js with-relay-modern-typescript-example Change
main-HASH.js gzip 5.77 kB 5.77 kB ✓
webpack-HASH.js gzip 746 B 746 B ✓
de003c3a9d30..8eb0.js gzip 9.78 kB 9.78 kB ✓
framework.HASH.js gzip 39.1 kB 39.1 kB ✓
Overall change 55.4 kB 55.4 kB ✓
Client Bundles (main, webpack, commons) Modern
zeit/next.js canary bdombro/next.js with-relay-modern-typescript-example Change
main-HASH.module.js gzip 4.78 kB 4.78 kB ✓
webpack-HASH..dule.js gzip 746 B 746 B ✓
de003c3a9d30..dule.js gzip 6.71 kB 6.71 kB ✓
framework.HA..dule.js gzip 39.1 kB 39.1 kB ✓
Overall change 51.4 kB 51.4 kB ✓
Legacy Client Bundles (polyfills)
zeit/next.js canary bdombro/next.js with-relay-modern-typescript-example Change
polyfills-HASH.js gzip 26.3 kB 26.3 kB ✓
Overall change 26.3 kB 26.3 kB ✓
Client Pages
zeit/next.js canary bdombro/next.js with-relay-modern-typescript-example Change
_app.js gzip 1.09 kB 1.09 kB ✓
_error.js gzip 2.97 kB 2.97 kB ✓
hooks.js gzip 664 B 664 B ✓
index.js gzip 222 B 222 B ✓
link.js gzip 1.89 kB 1.89 kB ✓
routerDirect.js gzip 279 B 279 B ✓
withRouter.js gzip 278 B 278 B ✓
Overall change 7.39 kB 7.39 kB ✓
Client Pages Modern
zeit/next.js canary bdombro/next.js with-relay-modern-typescript-example Change
_app.module.js gzip 594 B 594 B ✓
_error.module.js gzip 2.08 kB 2.08 kB ✓
hooks.module.js gzip 370 B 370 B ✓
index.module.js gzip 212 B 212 B ✓
link.module.js gzip 1.48 kB 1.48 kB ✓
routerDirect..dule.js gzip 271 B 271 B ✓
withRouter.m..dule.js gzip 270 B 270 B ✓
Overall change 5.28 kB 5.28 kB ✓
Client Build Manifests
zeit/next.js canary bdombro/next.js with-relay-modern-typescript-example Change
_buildManifest.js gzip 61 B 61 B ✓
_buildManife..dule.js gzip 61 B 61 B ✓
Overall change 122 B 122 B ✓
Rendered Page Sizes
zeit/next.js canary bdombro/next.js with-relay-modern-typescript-example Change
index.html gzip 916 B 916 B ✓
link.html gzip 924 B 924 B ✓
withRouter.html gzip 911 B 911 B ✓
Overall change 2.75 kB 2.75 kB ✓
Serverless Mode (Increase detected ⚠️)
General
zeit/next.js canary bdombro/next.js with-relay-modern-typescript-example Change
buildDuration 11.8s 12.2s ⚠️ +404ms
nodeModulesSize 54.8 MB 54.8 MB ✓
Client Bundles (main, webpack, commons)
zeit/next.js canary bdombro/next.js with-relay-modern-typescript-example Change
main-HASH.js gzip 5.77 kB 5.77 kB ✓
webpack-HASH.js gzip 746 B 746 B ✓
de003c3a9d30..8eb0.js gzip 9.78 kB 9.78 kB ✓
framework.HASH.js gzip 39.1 kB 39.1 kB ✓
Overall change 55.4 kB 55.4 kB ✓
Client Bundles (main, webpack, commons) Modern
zeit/next.js canary bdombro/next.js with-relay-modern-typescript-example Change
main-HASH.module.js gzip 4.78 kB 4.78 kB ✓
webpack-HASH..dule.js gzip 746 B 746 B ✓
de003c3a9d30..dule.js gzip 6.71 kB 6.71 kB ✓
framework.HA..dule.js gzip 39.1 kB 39.1 kB ✓
Overall change 51.4 kB 51.4 kB ✓
Legacy Client Bundles (polyfills)
zeit/next.js canary bdombro/next.js with-relay-modern-typescript-example Change
polyfills-HASH.js gzip 26.3 kB 26.3 kB ✓
Overall change 26.3 kB 26.3 kB ✓
Client Pages
zeit/next.js canary bdombro/next.js with-relay-modern-typescript-example Change
_app.js gzip 1.09 kB 1.09 kB ✓
_error.js gzip 2.97 kB 2.97 kB ✓
hooks.js gzip 664 B 664 B ✓
index.js gzip 222 B 222 B ✓
link.js gzip 1.89 kB 1.89 kB ✓
routerDirect.js gzip 279 B 279 B ✓
withRouter.js gzip 278 B 278 B ✓
Overall change 7.39 kB 7.39 kB ✓
Client Pages Modern
zeit/next.js canary bdombro/next.js with-relay-modern-typescript-example Change
_app.module.js gzip 594 B 594 B ✓
_error.module.js gzip 2.08 kB 2.08 kB ✓
hooks.module.js gzip 370 B 370 B ✓
index.module.js gzip 212 B 212 B ✓
link.module.js gzip 1.48 kB 1.48 kB ✓
routerDirect..dule.js gzip 271 B 271 B ✓
withRouter.m..dule.js gzip 270 B 270 B ✓
Overall change 5.28 kB 5.28 kB ✓
Client Build Manifests
zeit/next.js canary bdombro/next.js with-relay-modern-typescript-example Change
_buildManifest.js gzip 61 B 61 B ✓
_buildManife..dule.js gzip 61 B 61 B ✓
Overall change 122 B 122 B ✓
Serverless bundles Overall increase ⚠️
zeit/next.js canary bdombro/next.js with-relay-modern-typescript-example Change
_error.js gzip 294 kB 293 kB -259 B
404.html gzip 1.32 kB 1.32 kB ✓
hooks.html gzip 956 B 956 B ✓
index.js gzip 293 kB 293 kB ⚠️ +389 B
link.js gzip 301 kB 301 kB ⚠️ +442 B
routerDirect.js gzip 300 kB 300 kB -163 B
withRouter.js gzip 299 kB 300 kB ⚠️ +557 B
Overall change 1.49 MB 1.49 MB ⚠️ +966 B

@ijjk
Copy link
Member

ijjk commented Mar 19, 2020

Stats from current PR

Default Server Mode
General
zeit/next.js canary bdombro/next.js with-relay-modern-typescript-example Change
buildDuration 9.9s 9.9s -40ms
nodeModulesSize 53.2 MB 53.2 MB ✓
Client Bundles (main, webpack, commons)
zeit/next.js canary bdombro/next.js with-relay-modern-typescript-example Change
main-HASH.js gzip 5.77 kB 5.77 kB ✓
webpack-HASH.js gzip 746 B 746 B ✓
de003c3a9d30..8eb0.js gzip 9.78 kB 9.78 kB ✓
framework.HASH.js gzip 39.1 kB 39.1 kB ✓
Overall change 55.4 kB 55.4 kB ✓
Client Bundles (main, webpack, commons) Modern
zeit/next.js canary bdombro/next.js with-relay-modern-typescript-example Change
main-HASH.module.js gzip 4.78 kB 4.78 kB ✓
webpack-HASH..dule.js gzip 746 B 746 B ✓
de003c3a9d30..dule.js gzip 6.71 kB 6.71 kB ✓
framework.HA..dule.js gzip 39.1 kB 39.1 kB ✓
Overall change 51.4 kB 51.4 kB ✓
Legacy Client Bundles (polyfills)
zeit/next.js canary bdombro/next.js with-relay-modern-typescript-example Change
polyfills-HASH.js gzip 26.3 kB 26.3 kB ✓
Overall change 26.3 kB 26.3 kB ✓
Client Pages
zeit/next.js canary bdombro/next.js with-relay-modern-typescript-example Change
_app.js gzip 1.09 kB 1.09 kB ✓
_error.js gzip 2.97 kB 2.97 kB ✓
hooks.js gzip 664 B 664 B ✓
index.js gzip 222 B 222 B ✓
link.js gzip 1.89 kB 1.89 kB ✓
routerDirect.js gzip 279 B 279 B ✓
withRouter.js gzip 278 B 278 B ✓
Overall change 7.39 kB 7.39 kB ✓
Client Pages Modern
zeit/next.js canary bdombro/next.js with-relay-modern-typescript-example Change
_app.module.js gzip 594 B 594 B ✓
_error.module.js gzip 2.08 kB 2.08 kB ✓
hooks.module.js gzip 370 B 370 B ✓
index.module.js gzip 212 B 212 B ✓
link.module.js gzip 1.48 kB 1.48 kB ✓
routerDirect..dule.js gzip 271 B 271 B ✓
withRouter.m..dule.js gzip 270 B 270 B ✓
Overall change 5.28 kB 5.28 kB ✓
Client Build Manifests
zeit/next.js canary bdombro/next.js with-relay-modern-typescript-example Change
_buildManifest.js gzip 61 B 61 B ✓
_buildManife..dule.js gzip 61 B 61 B ✓
Overall change 122 B 122 B ✓
Rendered Page Sizes
zeit/next.js canary bdombro/next.js with-relay-modern-typescript-example Change
index.html gzip 916 B 916 B ✓
link.html gzip 924 B 924 B ✓
withRouter.html gzip 913 B 913 B ✓
Overall change 2.75 kB 2.75 kB ✓
Serverless Mode (Decrease detected ✓)
General
zeit/next.js canary bdombro/next.js with-relay-modern-typescript-example Change
buildDuration 10.4s 10.7s ⚠️ +328ms
nodeModulesSize 53.2 MB 53.2 MB ✓
Client Bundles (main, webpack, commons)
zeit/next.js canary bdombro/next.js with-relay-modern-typescript-example Change
main-HASH.js gzip 5.77 kB 5.77 kB ✓
webpack-HASH.js gzip 746 B 746 B ✓
de003c3a9d30..8eb0.js gzip 9.78 kB 9.78 kB ✓
framework.HASH.js gzip 39.1 kB 39.1 kB ✓
Overall change 55.4 kB 55.4 kB ✓
Client Bundles (main, webpack, commons) Modern
zeit/next.js canary bdombro/next.js with-relay-modern-typescript-example Change
main-HASH.module.js gzip 4.78 kB 4.78 kB ✓
webpack-HASH..dule.js gzip 746 B 746 B ✓
de003c3a9d30..dule.js gzip 6.71 kB 6.71 kB ✓
framework.HA..dule.js gzip 39.1 kB 39.1 kB ✓
Overall change 51.4 kB 51.4 kB ✓
Legacy Client Bundles (polyfills)
zeit/next.js canary bdombro/next.js with-relay-modern-typescript-example Change
polyfills-HASH.js gzip 26.3 kB 26.3 kB ✓
Overall change 26.3 kB 26.3 kB ✓
Client Pages
zeit/next.js canary bdombro/next.js with-relay-modern-typescript-example Change
_app.js gzip 1.09 kB 1.09 kB ✓
_error.js gzip 2.97 kB 2.97 kB ✓
hooks.js gzip 664 B 664 B ✓
index.js gzip 222 B 222 B ✓
link.js gzip 1.89 kB 1.89 kB ✓
routerDirect.js gzip 279 B 279 B ✓
withRouter.js gzip 278 B 278 B ✓
Overall change 7.39 kB 7.39 kB ✓
Client Pages Modern
zeit/next.js canary bdombro/next.js with-relay-modern-typescript-example Change
_app.module.js gzip 594 B 594 B ✓
_error.module.js gzip 2.08 kB 2.08 kB ✓
hooks.module.js gzip 370 B 370 B ✓
index.module.js gzip 212 B 212 B ✓
link.module.js gzip 1.48 kB 1.48 kB ✓
routerDirect..dule.js gzip 271 B 271 B ✓
withRouter.m..dule.js gzip 270 B 270 B ✓
Overall change 5.28 kB 5.28 kB ✓
Client Build Manifests
zeit/next.js canary bdombro/next.js with-relay-modern-typescript-example Change
_buildManifest.js gzip 61 B 61 B ✓
_buildManife..dule.js gzip 61 B 61 B ✓
Overall change 122 B 122 B ✓
Serverless bundles Overall decrease ✓
zeit/next.js canary bdombro/next.js with-relay-modern-typescript-example Change
_error.js gzip 293 kB 293 kB -463 B
404.html gzip 1.32 kB 1.32 kB ✓
hooks.html gzip 957 B 957 B ✓
index.js gzip 293 kB 293 kB ⚠️ +309 B
link.js gzip 301 kB 301 kB -174 B
routerDirect.js gzip 300 kB 300 kB -7 B
withRouter.js gzip 300 kB 300 kB ⚠️ +151 B
Overall change 1.49 MB 1.49 MB -184 B

@ijjk
Copy link
Member

ijjk commented Mar 19, 2020

Stats from current PR

Default Server Mode
General
zeit/next.js canary bdombro/next.js with-relay-modern-typescript-example Change
buildDuration 9.6s 9.6s -21ms
nodeModulesSize 53.2 MB 53.2 MB ✓
Client Bundles (main, webpack, commons)
zeit/next.js canary bdombro/next.js with-relay-modern-typescript-example Change
main-HASH.js gzip 5.77 kB 5.77 kB ✓
webpack-HASH.js gzip 746 B 746 B ✓
de003c3a9d30..8eb0.js gzip 9.78 kB 9.78 kB ✓
framework.HASH.js gzip 39.1 kB 39.1 kB ✓
Overall change 55.4 kB 55.4 kB ✓
Client Bundles (main, webpack, commons) Modern
zeit/next.js canary bdombro/next.js with-relay-modern-typescript-example Change
main-HASH.module.js gzip 4.78 kB 4.78 kB ✓
webpack-HASH..dule.js gzip 746 B 746 B ✓
de003c3a9d30..dule.js gzip 6.71 kB 6.71 kB ✓
framework.HA..dule.js gzip 39.1 kB 39.1 kB ✓
Overall change 51.4 kB 51.4 kB ✓
Legacy Client Bundles (polyfills)
zeit/next.js canary bdombro/next.js with-relay-modern-typescript-example Change
polyfills-HASH.js gzip 26.3 kB 26.3 kB ✓
Overall change 26.3 kB 26.3 kB ✓
Client Pages
zeit/next.js canary bdombro/next.js with-relay-modern-typescript-example Change
_app.js gzip 1.09 kB 1.09 kB ✓
_error.js gzip 2.97 kB 2.97 kB ✓
hooks.js gzip 664 B 664 B ✓
index.js gzip 222 B 222 B ✓
link.js gzip 1.89 kB 1.89 kB ✓
routerDirect.js gzip 279 B 279 B ✓
withRouter.js gzip 278 B 278 B ✓
Overall change 7.39 kB 7.39 kB ✓
Client Pages Modern
zeit/next.js canary bdombro/next.js with-relay-modern-typescript-example Change
_app.module.js gzip 594 B 594 B ✓
_error.module.js gzip 2.08 kB 2.08 kB ✓
hooks.module.js gzip 370 B 370 B ✓
index.module.js gzip 212 B 212 B ✓
link.module.js gzip 1.48 kB 1.48 kB ✓
routerDirect..dule.js gzip 271 B 271 B ✓
withRouter.m..dule.js gzip 270 B 270 B ✓
Overall change 5.28 kB 5.28 kB ✓
Client Build Manifests
zeit/next.js canary bdombro/next.js with-relay-modern-typescript-example Change
_buildManifest.js gzip 61 B 61 B ✓
_buildManife..dule.js gzip 61 B 61 B ✓
Overall change 122 B 122 B ✓
Rendered Page Sizes
zeit/next.js canary bdombro/next.js with-relay-modern-typescript-example Change
index.html gzip 916 B 916 B ✓
link.html gzip 924 B 924 B ✓
withRouter.html gzip 913 B 913 B ✓
Overall change 2.75 kB 2.75 kB ✓
Serverless Mode (Decrease detected ✓)
General
zeit/next.js canary bdombro/next.js with-relay-modern-typescript-example Change
buildDuration 10.5s 10.2s -295ms
nodeModulesSize 53.2 MB 53.2 MB ✓
Client Bundles (main, webpack, commons)
zeit/next.js canary bdombro/next.js with-relay-modern-typescript-example Change
main-HASH.js gzip 5.77 kB 5.77 kB ✓
webpack-HASH.js gzip 746 B 746 B ✓
de003c3a9d30..8eb0.js gzip 9.78 kB 9.78 kB ✓
framework.HASH.js gzip 39.1 kB 39.1 kB ✓
Overall change 55.4 kB 55.4 kB ✓
Client Bundles (main, webpack, commons) Modern
zeit/next.js canary bdombro/next.js with-relay-modern-typescript-example Change
main-HASH.module.js gzip 4.78 kB 4.78 kB ✓
webpack-HASH..dule.js gzip 746 B 746 B ✓
de003c3a9d30..dule.js gzip 6.71 kB 6.71 kB ✓
framework.HA..dule.js gzip 39.1 kB 39.1 kB ✓
Overall change 51.4 kB 51.4 kB ✓
Legacy Client Bundles (polyfills)
zeit/next.js canary bdombro/next.js with-relay-modern-typescript-example Change
polyfills-HASH.js gzip 26.3 kB 26.3 kB ✓
Overall change 26.3 kB 26.3 kB ✓
Client Pages
zeit/next.js canary bdombro/next.js with-relay-modern-typescript-example Change
_app.js gzip 1.09 kB 1.09 kB ✓
_error.js gzip 2.97 kB 2.97 kB ✓
hooks.js gzip 664 B 664 B ✓
index.js gzip 222 B 222 B ✓
link.js gzip 1.89 kB 1.89 kB ✓
routerDirect.js gzip 279 B 279 B ✓
withRouter.js gzip 278 B 278 B ✓
Overall change 7.39 kB 7.39 kB ✓
Client Pages Modern
zeit/next.js canary bdombro/next.js with-relay-modern-typescript-example Change
_app.module.js gzip 594 B 594 B ✓
_error.module.js gzip 2.08 kB 2.08 kB ✓
hooks.module.js gzip 370 B 370 B ✓
index.module.js gzip 212 B 212 B ✓
link.module.js gzip 1.48 kB 1.48 kB ✓
routerDirect..dule.js gzip 271 B 271 B ✓
withRouter.m..dule.js gzip 270 B 270 B ✓
Overall change 5.28 kB 5.28 kB ✓
Client Build Manifests
zeit/next.js canary bdombro/next.js with-relay-modern-typescript-example Change
_buildManifest.js gzip 61 B 61 B ✓
_buildManife..dule.js gzip 61 B 61 B ✓
Overall change 122 B 122 B ✓
Serverless bundles Overall decrease ✓
zeit/next.js canary bdombro/next.js with-relay-modern-typescript-example Change
_error.js gzip 294 kB 293 kB -740 B
404.html gzip 1.32 kB 1.32 kB ✓
hooks.html gzip 957 B 957 B ✓
index.js gzip 294 kB 293 kB -435 B
link.js gzip 302 kB 301 kB -307 B
routerDirect.js gzip 300 kB 300 kB -65 B
withRouter.js gzip 300 kB 300 kB ⚠️ +5 B
Overall change 1.49 MB 1.49 MB -1.54 kB

@lfades
Copy link
Member

lfades commented Mar 19, 2020 •
edited by timneutkens

Hi @bdombro thank you for the PR!.

We're currently moving most examples to using the new data fetching methods getStaticProps and getServerSideProps, as these provide a better model for data fetching and code included in the methods is not shipped to browsers, allowing for smaller bundle sizes. We're tracking this work in #11014.

Furthermore, we already have this exact example and there's around 200 examples right now, so we're currently not introducing duplicates of examples.

@lfades lfades closed this Mar 19, 2020
@messa
Copy link
Contributor

messa commented Mar 20, 2020

Hi @lfades, from getServerSideProps documentation:

When you request this page on client-side page transitions through next/link or next/router, Next.js sends an API request to the server, which runs getServerSideProps.

But here we do not want to make a server round-trip - we want to make the graphql request directly from the browser. Exactly what getInitialProps does. What is the recommended solution here then? Is there going to be some getClientSideProps in the future?

@timneutkens
Copy link
Member

timneutkens commented Mar 20, 2020 •
edited

Just to be clear, we are not planning to remove/deprecate getInitialProps. However, we're not duplicating examples as there's already around 200 of them.

The relay example will be updated to use getStaticProps / getServerSideProps accordingly eventually, and if it doesn't cover that case we'll see if the new methods can be updated to support the ideal way to use it.

Replied here also: https://twitter.com/timneutkens/status/1240903685300985856

Also updated @lfades's reply to correctly reflect the reasoning for not merging it.

@bdombro
Copy link
Contributor Author

bdombro commented Apr 14, 2020

@timneutkens I wouldn't have contributed this example if I didn't think it was helpful. Converting a NextJS javascript example to strict Typescript is very tricky IMO, which is why I took the time to contribute a working example. On the other hand, converting a typescript example to javascript is easy.

At the same time, there are WAY more Apollo Client examples than React Relay, so it seems a little biased towards Apollo Client.

If you're concerned about the number of examples, may I recommend that we instead keep the typescript example in this PR and drop the existing javascript example?

@timneutkens
Copy link
Member

I'm not opposed to adding this example per-se, just want to make sure we solve the case that getInitialProps is used with the new data fetching methods instead of adding in more examples for getInitialProps

@bdombro
Copy link
Contributor Author

bdombro commented Apr 14, 2020

Okay, got it! So would you consider accepting if I update upgraded to getServerSideProps?

@timneutkens
Copy link
Member

Yep!

@vercel vercel locked as resolved and limited conversation to collaborators Jan 31, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@messa messa messa requested changes

@lfades lfades Awaiting requested review from lfades

@Timer Timer Awaiting requested review from Timer

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@bdombro @ijjk @lfades @messa @timneutkens