Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure an accessible default viewport meta tag #10823

Merged
merged 4 commits into from Mar 5, 2020
Merged

Ensure an accessible default viewport meta tag #10823

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
d964dd7
fix: remove minimum-scale from default viewport
rifaidev Mar 4, 2020
bbcb29f
update test
rifaidev Mar 4, 2020
3ae5726
remove extra comma
rifaidev Mar 4, 2020
1bccd59
drop initial-scale
rifaidev Mar 4, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
5 changes: 1 addition & 4 deletions packages/next/next-server/lib/head.tsx
View file
Open in desktop
Expand Up @@ -12,10 +12,7 @@ export function defaultHead(inAmpMode = false) {
const head = [<meta charSet="utf-8" />]
if (!inAmpMode) {
head.push(
<meta
name="viewport"
content="width=device-width,minimum-scale=1,initial-scale=1"
/>
<meta name="viewport" content="width=device-width, initial-scale=1" />
timneutkens marked this conversation as resolved.
Show resolved Hide resolved
)
}
return head
Expand Down
2 changes: 1 addition & 1 deletion test/integration/client-navigation/test/rendering.js
View file
Open in desktop
Expand Up @@ -52,7 +52,7 @@ export default function(render, fetch) {
test('header renders default viewport', async () => {
const html = await render('/default-head')
expect(html).toContain(
'<meta name="viewport" content="width=device-width,minimum-scale=1,initial-scale=1"/>'
'<meta name="viewport" content="width=device-width, initial-scale=1"/>'
)
})

Expand Down