Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Generic form of GetStaticProps and GetServerSideProps #10856

Merged
merged 8 commits into from Mar 12, 2020
Merged

Generic form of GetStaticProps and GetServerSideProps #10856

Changes from 4 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
88de866
Generic form of GetStaticProps and GetServerSideProps
jstcki Mar 5, 2020
4c5c5d7
Oops, fix type!
jstcki Mar 5, 2020
0bfe909
Add constraint for P
jstcki Mar 5, 2020
72689e1
Merge branch 'canary' into staticprops-generics
jstcki Mar 6, 2020
5188bfb
Update packages/next/types/index.d.ts
Timer Mar 12, 2020
5c6512f
Merge branch 'canary' into staticprops-generics
Timer Mar 12, 2020
a7f0824
Merge branch 'canary' into staticprops-generics
Timer Mar 12, 2020
88e71fb
Merge branch 'canary' into staticprops-generics
Timer Mar 12, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
12 changes: 8 additions & 4 deletions packages/next/types/index.d.ts
View file
Open in desktop
Expand Up @@ -64,12 +64,14 @@ export {
NextApiHandler,
}

export type GetStaticProps = (ctx: {
export type GetStaticProps<
P extends { [key: string]: any } = { [key: string]: any }
> = (ctx: {
params?: ParsedUrlQuery
preview?: boolean
previewData?: any
}) => Promise<{
props: { [key: string]: any }
props: P
revalidate?: number | boolean
}>

Expand All @@ -78,13 +80,15 @@ export type GetStaticPaths = () => Promise<{
fallback: boolean
}>

export type GetServerSideProps = (context: {
export type GetServerSideProps<
P extends { [key: string]: any } = { [key: string]: any }
> = (context: {
req: IncomingMessage
res: ServerResponse
params?: ParsedUrlQuery
query: ParsedUrlQuery
preview?: boolean
previewData?: any
}) => Promise<{ [key: string]: any }>
}) => Promise<P>
Timer marked this conversation as resolved.
Show resolved Hide resolved

export default next