Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

diegomendezp:update-with-aws-amplify #11148

Conversation

diegomendezp
Copy link

In this PR:
– Update TodoPage from getInitialProps to getStaticProps.
– Update index from getInitialProps to getStaticProps.

Related to #11014

@ijjk
Copy link
Member

ijjk commented Mar 17, 2020

Stats from current PR

Default Server Mode
General
zeit/next.js canary diegomendezp/next.js feature/update-with-aws-amplify Change
buildDuration 9.1s 9.1s -9ms
nodeModulesSize 54.9 MB 54.9 MB
Client Bundles (main, webpack, commons)
zeit/next.js canary diegomendezp/next.js feature/update-with-aws-amplify Change
main-HASH.js gzip 5.76 kB 5.76 kB
webpack-HASH.js gzip 746 B 746 B
de003c3a9d30..8eb0.js gzip 9.78 kB 9.78 kB
framework.HASH.js gzip 39.1 kB 39.1 kB
Overall change 55.4 kB 55.4 kB
Client Bundles (main, webpack, commons) Modern
zeit/next.js canary diegomendezp/next.js feature/update-with-aws-amplify Change
main-HASH.module.js gzip 4.77 kB 4.77 kB
webpack-HASH..dule.js gzip 746 B 746 B
de003c3a9d30..dule.js gzip 6.71 kB 6.71 kB
framework.HA..dule.js gzip 39.1 kB 39.1 kB
Overall change 51.4 kB 51.4 kB
Legacy Client Bundles (polyfills)
zeit/next.js canary diegomendezp/next.js feature/update-with-aws-amplify Change
polyfills-HASH.js gzip 26.3 kB 26.3 kB
Overall change 26.3 kB 26.3 kB
Client Pages
zeit/next.js canary diegomendezp/next.js feature/update-with-aws-amplify Change
_app.js gzip 1.09 kB 1.09 kB
_error.js gzip 2.97 kB 2.97 kB
hooks.js gzip 664 B 664 B
index.js gzip 222 B 222 B
link.js gzip 1.89 kB 1.89 kB
routerDirect.js gzip 279 B 279 B
withRouter.js gzip 278 B 278 B
Overall change 7.39 kB 7.39 kB
Client Pages Modern
zeit/next.js canary diegomendezp/next.js feature/update-with-aws-amplify Change
_app.module.js gzip 594 B 594 B
_error.module.js gzip 2.08 kB 2.08 kB
hooks.module.js gzip 370 B 370 B
index.module.js gzip 212 B 212 B
link.module.js gzip 1.48 kB 1.48 kB
routerDirect..dule.js gzip 271 B 271 B
withRouter.m..dule.js gzip 270 B 270 B
Overall change 5.28 kB 5.28 kB
Client Build Manifests
zeit/next.js canary diegomendezp/next.js feature/update-with-aws-amplify Change
_buildManifest.js gzip 61 B 61 B
_buildManife..dule.js gzip 61 B 61 B
Overall change 122 B 122 B
Rendered Page Sizes
zeit/next.js canary diegomendezp/next.js feature/update-with-aws-amplify Change
index.html gzip 916 B 916 B
link.html gzip 925 B 925 B
withRouter.html gzip 914 B 914 B
Overall change 2.75 kB 2.75 kB

Serverless Mode (Increase detected ⚠️)
General
zeit/next.js canary diegomendezp/next.js feature/update-with-aws-amplify Change
buildDuration 10s 9.6s -347ms
nodeModulesSize 54.9 MB 54.9 MB
Client Bundles (main, webpack, commons)
zeit/next.js canary diegomendezp/next.js feature/update-with-aws-amplify Change
main-HASH.js gzip 5.76 kB 5.76 kB
webpack-HASH.js gzip 746 B 746 B
de003c3a9d30..8eb0.js gzip 9.78 kB 9.78 kB
framework.HASH.js gzip 39.1 kB 39.1 kB
Overall change 55.4 kB 55.4 kB
Client Bundles (main, webpack, commons) Modern
zeit/next.js canary diegomendezp/next.js feature/update-with-aws-amplify Change
main-HASH.module.js gzip 4.77 kB 4.77 kB
webpack-HASH..dule.js gzip 746 B 746 B
de003c3a9d30..dule.js gzip 6.71 kB 6.71 kB
framework.HA..dule.js gzip 39.1 kB 39.1 kB
Overall change 51.4 kB 51.4 kB
Legacy Client Bundles (polyfills)
zeit/next.js canary diegomendezp/next.js feature/update-with-aws-amplify Change
polyfills-HASH.js gzip 26.3 kB 26.3 kB
Overall change 26.3 kB 26.3 kB
Client Pages
zeit/next.js canary diegomendezp/next.js feature/update-with-aws-amplify Change
_app.js gzip 1.09 kB 1.09 kB
_error.js gzip 2.97 kB 2.97 kB
hooks.js gzip 664 B 664 B
index.js gzip 222 B 222 B
link.js gzip 1.89 kB 1.89 kB
routerDirect.js gzip 279 B 279 B
withRouter.js gzip 278 B 278 B
Overall change 7.39 kB 7.39 kB
Client Pages Modern
zeit/next.js canary diegomendezp/next.js feature/update-with-aws-amplify Change
_app.module.js gzip 594 B 594 B
_error.module.js gzip 2.08 kB 2.08 kB
hooks.module.js gzip 370 B 370 B
index.module.js gzip 212 B 212 B
link.module.js gzip 1.48 kB 1.48 kB
routerDirect..dule.js gzip 271 B 271 B
withRouter.m..dule.js gzip 270 B 270 B
Overall change 5.28 kB 5.28 kB
Client Build Manifests
zeit/next.js canary diegomendezp/next.js feature/update-with-aws-amplify Change
_buildManifest.js gzip 61 B 61 B
_buildManife..dule.js gzip 61 B 61 B
Overall change 122 B 122 B
Serverless bundles Overall increase ⚠️
zeit/next.js canary diegomendezp/next.js feature/update-with-aws-amplify Change
_error.js gzip 293 kB 293 kB ⚠️ +42 B
404.html gzip 1.32 kB 1.32 kB
hooks.html gzip 957 B 957 B
index.js gzip 293 kB 294 kB ⚠️ +636 B
link.js gzip 301 kB 301 kB ⚠️ +144 B
routerDirect.js gzip 300 kB 300 kB -108 B
withRouter.js gzip 300 kB 299 kB -507 B
Overall change 1.49 MB 1.49 MB ⚠️ +207 B

Copy link
Member

@timneutkens timneutkens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This update is incorrect, you can't assign these properties as Next.js will not execute them, they have to be exported using export async function getStaticProps for example.

@lfades
Copy link
Member

lfades commented Mar 18, 2020

I'm closing this PR as the current Apollo HOC used in apollo examples won't support the new SSG methods and an alternative method is needed.

@lfades lfades closed this Mar 18, 2020
@vercel vercel locked as resolved and limited conversation to collaborators Jan 31, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants