Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix assignment of props in WithApollo.getInitialProps #11236

Merged
merged 1 commit into from Mar 24, 2020
Merged

Fix assignment of props in WithApollo.getInitialProps #11236

merged 1 commit into from Mar 24, 2020

Commits on Mar 20, 2020

  1. Fix assignment of props in WithApollo.getInitialProps 

    The props are being assigned incorrectly based on the `inAppContext`, they should be wrapped in `pageProps` when `inAppContext` is true, not the other way around. This will cause a new apollo client to be created during `getDataFromTree` instead of using the one that has already been created on the server.
    @bgoerdt
    bgoerdt committed Mar 20, 2020
    Copy the full SHA
    f794434 View commit details
    Browse the repository at this point in the history