Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixes 404 no longer returned when error with code ENOENT is thrown. #11480

Closed
wants to merge 8 commits into from
Closed

fixes 404 no longer returned when error with code ENOENT is thrown. #11480

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
9767e43
restore ENOENT handling during rendering to allow returning 404 statu…
fabb Mar 30, 2020
16aaa11
Merge remote-tracking branch 'upstream/canary' into fix-404-status-code
ijjk Apr 6, 2020
7a438df
Fix behavior in dev mode and add test cases
ijjk Apr 6, 2020
2ae0e84
Merge remote-tracking branch 'upstream/canary' into fix-404-status-code
ijjk Apr 9, 2020
4c58a0e
Add warning when ENOENT is used to trigger 404
ijjk Apr 9, 2020
849b93c
Add GSP test from GSSP suite for throwing ENOENT
ijjk Apr 9, 2020
1286651
Merge remote-tracking branch 'upstream/canary' into fix-404-status-code
ijjk Apr 10, 2020
0074314
Update err.sh
ijjk Apr 10, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
11 changes: 8 additions & 3 deletions packages/next/next-server/server/next-server.ts
View file
Open in desktop
Expand Up @@ -1238,9 +1238,14 @@ export default class Server {
}
}
} catch (err) {
this.logError(err)
res.statusCode = 500
return await this.renderErrorToHTML(err, req, res, pathname, query)
if (err && err.code === 'ENOENT') {
res.statusCode = 404
return await this.renderErrorToHTML(null, req, res, pathname, query)
} else {
this.logError(err)
res.statusCode = 500
return await this.renderErrorToHTML(err, req, res, pathname, query)
}
}

res.statusCode = 404
Expand Down