Run tsconfig paths resolver before PnP #12104
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Based on vercel#11293 (comment) Not sure how to test PnP and couldn't figure out how to debug packages installed through PnP. We'll have to update this either way as PnP is going to be built into webpack 5 and that would change the order to be like this too.
Quick note: you can just run |
|
@arcanis thanks! That'll definitely help in the future 🙏 |
This was referenced May 1, 2020
rokinsky
pushed a commit
to rokinsky/next.js
that referenced
this pull request
Jul 11, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on #11293 (comment)
Not sure how to test PnP and couldn't figure out how to debug packages installed through PnP. We'll have to update this either way as PnP is going to be built into webpack 5 and that would change the order to be like this too.