-
Notifications
You must be signed in to change notification settings - Fork 26k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Re-enabled create-next-app tests on windows #12997
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Stats from current PRDefault Server Mode (Decrease detected ✓)General
Page Load Tests Overall decrease
|
zeit/next.js canary | Janpot/next.js create-next-app-tests | Change | |
---|---|---|---|
/ failed reqs | 0 | 0 | ✓ |
/ total time (seconds) | 2.185 | 2.179 | -0.01 |
/ avg req/sec | 1144.42 | 1147.26 | |
/error-in-render failed reqs | 0 | 0 | ✓ |
/error-in-render total time (seconds) | 1.462 | 1.483 | |
/error-in-render avg req/sec | 1710.14 | 1685.48 | -24.66 |
Client Bundles (main, webpack, commons)
zeit/next.js canary | Janpot/next.js create-next-app-tests | Change | |
---|---|---|---|
main-HASH.js gzip | 6.67 kB | 6.67 kB | ✓ |
webpack-HASH.js gzip | 746 B | 746 B | ✓ |
de003c3a9d30..e49d.js gzip | 10.4 kB | 10.4 kB | ✓ |
framework.HASH.js gzip | 39.1 kB | 39.1 kB | ✓ |
Overall change | 57 kB | 57 kB | ✓ |
Client Bundles (main, webpack, commons) Modern
zeit/next.js canary | Janpot/next.js create-next-app-tests | Change | |
---|---|---|---|
main-HASH.module.js gzip | 5.71 kB | 5.71 kB | ✓ |
webpack-HASH..dule.js gzip | 746 B | 746 B | ✓ |
de003c3a9d30..dule.js gzip | 6.85 kB | 6.85 kB | ✓ |
framework.HA..dule.js gzip | 39.1 kB | 39.1 kB | ✓ |
Overall change | 52.4 kB | 52.4 kB | ✓ |
Legacy Client Bundles (polyfills)
zeit/next.js canary | Janpot/next.js create-next-app-tests | Change | |
---|---|---|---|
polyfills-HASH.js gzip | 26.3 kB | 26.3 kB | ✓ |
Overall change | 26.3 kB | 26.3 kB | ✓ |
Client Pages
zeit/next.js canary | Janpot/next.js create-next-app-tests | Change | |
---|---|---|---|
_app.js gzip | 1.26 kB | 1.26 kB | ✓ |
_error.js gzip | 3.28 kB | 3.28 kB | ✓ |
hooks.js gzip | 881 B | 881 B | ✓ |
index.js gzip | 222 B | 222 B | ✓ |
link.js gzip | 2.06 kB | 2.06 kB | ✓ |
routerDirect.js gzip | 279 B | 279 B | ✓ |
withRouter.js gzip | 278 B | 278 B | ✓ |
Overall change | 8.26 kB | 8.26 kB | ✓ |
Client Pages Modern
zeit/next.js canary | Janpot/next.js create-next-app-tests | Change | |
---|---|---|---|
_app.module.js gzip | 604 B | 604 B | ✓ |
_error.module.js gzip | 2.09 kB | 2.09 kB | ✓ |
hooks.module.js gzip | 383 B | 383 B | ✓ |
index.module.js gzip | 223 B | 223 B | ✓ |
link.module.js gzip | 1.52 kB | 1.52 kB | ✓ |
routerDirect..dule.js gzip | 281 B | 281 B | ✓ |
withRouter.m..dule.js gzip | 278 B | 278 B | ✓ |
Overall change | 5.38 kB | 5.38 kB | ✓ |
Client Build Manifests
zeit/next.js canary | Janpot/next.js create-next-app-tests | Change | |
---|---|---|---|
_buildManifest.js gzip | 61 B | 61 B | ✓ |
_buildManife..dule.js gzip | 61 B | 61 B | ✓ |
Overall change | 122 B | 122 B | ✓ |
Rendered Page Sizes
zeit/next.js canary | Janpot/next.js create-next-app-tests | Change | |
---|---|---|---|
index.html gzip | 926 B | 926 B | ✓ |
link.html gzip | 936 B | 936 B | ✓ |
withRouter.html gzip | 923 B | 923 B | ✓ |
Overall change | 2.79 kB | 2.79 kB | ✓ |
Serverless Mode
General
zeit/next.js canary | Janpot/next.js create-next-app-tests | Change | |
---|---|---|---|
buildDuration | 13.5s | 13.7s | |
nodeModulesSize | 58.5 MB | 58.5 MB | ✓ |
Client Bundles (main, webpack, commons)
zeit/next.js canary | Janpot/next.js create-next-app-tests | Change | |
---|---|---|---|
main-HASH.js gzip | 6.67 kB | 6.67 kB | ✓ |
webpack-HASH.js gzip | 746 B | 746 B | ✓ |
de003c3a9d30..e49d.js gzip | 10.4 kB | 10.4 kB | ✓ |
framework.HASH.js gzip | 39.1 kB | 39.1 kB | ✓ |
Overall change | 57 kB | 57 kB | ✓ |
Client Bundles (main, webpack, commons) Modern
zeit/next.js canary | Janpot/next.js create-next-app-tests | Change | |
---|---|---|---|
main-HASH.module.js gzip | 5.71 kB | 5.71 kB | ✓ |
webpack-HASH..dule.js gzip | 746 B | 746 B | ✓ |
de003c3a9d30..dule.js gzip | 6.85 kB | 6.85 kB | ✓ |
framework.HA..dule.js gzip | 39.1 kB | 39.1 kB | ✓ |
Overall change | 52.4 kB | 52.4 kB | ✓ |
Legacy Client Bundles (polyfills)
zeit/next.js canary | Janpot/next.js create-next-app-tests | Change | |
---|---|---|---|
polyfills-HASH.js gzip | 26.3 kB | 26.3 kB | ✓ |
Overall change | 26.3 kB | 26.3 kB | ✓ |
Client Pages
zeit/next.js canary | Janpot/next.js create-next-app-tests | Change | |
---|---|---|---|
_app.js gzip | 1.26 kB | 1.26 kB | ✓ |
_error.js gzip | 3.28 kB | 3.28 kB | ✓ |
hooks.js gzip | 881 B | 881 B | ✓ |
index.js gzip | 222 B | 222 B | ✓ |
link.js gzip | 2.06 kB | 2.06 kB | ✓ |
routerDirect.js gzip | 279 B | 279 B | ✓ |
withRouter.js gzip | 278 B | 278 B | ✓ |
Overall change | 8.26 kB | 8.26 kB | ✓ |
Client Pages Modern
zeit/next.js canary | Janpot/next.js create-next-app-tests | Change | |
---|---|---|---|
_app.module.js gzip | 604 B | 604 B | ✓ |
_error.module.js gzip | 2.09 kB | 2.09 kB | ✓ |
hooks.module.js gzip | 383 B | 383 B | ✓ |
index.module.js gzip | 223 B | 223 B | ✓ |
link.module.js gzip | 1.52 kB | 1.52 kB | ✓ |
routerDirect..dule.js gzip | 281 B | 281 B | ✓ |
withRouter.m..dule.js gzip | 278 B | 278 B | ✓ |
Overall change | 5.38 kB | 5.38 kB | ✓ |
Client Build Manifests
zeit/next.js canary | Janpot/next.js create-next-app-tests | Change | |
---|---|---|---|
_buildManifest.js gzip | 61 B | 61 B | ✓ |
_buildManife..dule.js gzip | 61 B | 61 B | ✓ |
Overall change | 122 B | 122 B | ✓ |
Serverless bundles
zeit/next.js canary | Janpot/next.js create-next-app-tests | Change | |
---|---|---|---|
_error.js | 850 kB | 850 kB | ✓ |
404.html | 4.18 kB | 4.18 kB | ✓ |
hooks.html | 3.81 kB | 3.81 kB | ✓ |
index.js | 851 kB | 851 kB | ✓ |
link.js | 888 kB | 888 kB | ✓ |
routerDirect.js | 880 kB | 880 kB | ✓ |
withRouter.js | 880 kB | 880 kB | ✓ |
Overall change | 4.36 MB | 4.36 MB | ✓ |
Stats from current PRDefault Server Mode (Increase detected
|
zeit/next.js canary | Janpot/next.js create-next-app-tests | Change | |
---|---|---|---|
buildDuration | 10.2s | 10.4s | |
nodeModulesSize | 58.5 MB | 58.5 MB | ✓ |
Page Load Tests Overall increase ✓
zeit/next.js canary | Janpot/next.js create-next-app-tests | Change | |
---|---|---|---|
/ failed reqs | 0 | 0 | ✓ |
/ total time (seconds) | 1.794 | 1.694 | -0.1 |
/ avg req/sec | 1393.36 | 1476.23 | |
/error-in-render failed reqs | 0 | 0 | ✓ |
/error-in-render total time (seconds) | 0.987 | 0.982 | -0.01 |
/error-in-render avg req/sec | 2533.68 | 2546.18 |
Client Bundles (main, webpack, commons)
zeit/next.js canary | Janpot/next.js create-next-app-tests | Change | |
---|---|---|---|
main-HASH.js gzip | 6.67 kB | 6.67 kB | ✓ |
webpack-HASH.js gzip | 746 B | 746 B | ✓ |
de003c3a9d30..e49d.js gzip | 10.4 kB | 10.4 kB | ✓ |
framework.HASH.js gzip | 39.1 kB | 39.1 kB | ✓ |
Overall change | 57 kB | 57 kB | ✓ |
Client Bundles (main, webpack, commons) Modern
zeit/next.js canary | Janpot/next.js create-next-app-tests | Change | |
---|---|---|---|
main-HASH.module.js gzip | 5.71 kB | 5.71 kB | ✓ |
webpack-HASH..dule.js gzip | 746 B | 746 B | ✓ |
de003c3a9d30..dule.js gzip | 6.85 kB | 6.85 kB | ✓ |
framework.HA..dule.js gzip | 39.1 kB | 39.1 kB | ✓ |
Overall change | 52.4 kB | 52.4 kB | ✓ |
Legacy Client Bundles (polyfills)
zeit/next.js canary | Janpot/next.js create-next-app-tests | Change | |
---|---|---|---|
polyfills-HASH.js gzip | 26.3 kB | 26.3 kB | ✓ |
Overall change | 26.3 kB | 26.3 kB | ✓ |
Client Pages
zeit/next.js canary | Janpot/next.js create-next-app-tests | Change | |
---|---|---|---|
_app.js gzip | 1.26 kB | 1.26 kB | ✓ |
_error.js gzip | 3.28 kB | 3.28 kB | ✓ |
hooks.js gzip | 881 B | 881 B | ✓ |
index.js gzip | 222 B | 222 B | ✓ |
link.js gzip | 2.06 kB | 2.06 kB | ✓ |
routerDirect.js gzip | 279 B | 279 B | ✓ |
withRouter.js gzip | 278 B | 278 B | ✓ |
Overall change | 8.26 kB | 8.26 kB | ✓ |
Client Pages Modern
zeit/next.js canary | Janpot/next.js create-next-app-tests | Change | |
---|---|---|---|
_app.module.js gzip | 604 B | 604 B | ✓ |
_error.module.js gzip | 2.09 kB | 2.09 kB | ✓ |
hooks.module.js gzip | 383 B | 383 B | ✓ |
index.module.js gzip | 223 B | 223 B | ✓ |
link.module.js gzip | 1.52 kB | 1.52 kB | ✓ |
routerDirect..dule.js gzip | 281 B | 281 B | ✓ |
withRouter.m..dule.js gzip | 278 B | 278 B | ✓ |
Overall change | 5.38 kB | 5.38 kB | ✓ |
Client Build Manifests
zeit/next.js canary | Janpot/next.js create-next-app-tests | Change | |
---|---|---|---|
_buildManifest.js gzip | 61 B | 61 B | ✓ |
_buildManife..dule.js gzip | 61 B | 61 B | ✓ |
Overall change | 122 B | 122 B | ✓ |
Rendered Page Sizes
zeit/next.js canary | Janpot/next.js create-next-app-tests | Change | |
---|---|---|---|
index.html gzip | 926 B | 926 B | ✓ |
link.html gzip | 936 B | 936 B | ✓ |
withRouter.html gzip | 923 B | 923 B | ✓ |
Overall change | 2.79 kB | 2.79 kB | ✓ |
Serverless Mode
General
zeit/next.js canary | Janpot/next.js create-next-app-tests | Change | |
---|---|---|---|
buildDuration | 11.5s | 11.1s | -388ms |
nodeModulesSize | 58.5 MB | 58.5 MB | ✓ |
Client Bundles (main, webpack, commons)
zeit/next.js canary | Janpot/next.js create-next-app-tests | Change | |
---|---|---|---|
main-HASH.js gzip | 6.67 kB | 6.67 kB | ✓ |
webpack-HASH.js gzip | 746 B | 746 B | ✓ |
de003c3a9d30..e49d.js gzip | 10.4 kB | 10.4 kB | ✓ |
framework.HASH.js gzip | 39.1 kB | 39.1 kB | ✓ |
Overall change | 57 kB | 57 kB | ✓ |
Client Bundles (main, webpack, commons) Modern
zeit/next.js canary | Janpot/next.js create-next-app-tests | Change | |
---|---|---|---|
main-HASH.module.js gzip | 5.71 kB | 5.71 kB | ✓ |
webpack-HASH..dule.js gzip | 746 B | 746 B | ✓ |
de003c3a9d30..dule.js gzip | 6.85 kB | 6.85 kB | ✓ |
framework.HA..dule.js gzip | 39.1 kB | 39.1 kB | ✓ |
Overall change | 52.4 kB | 52.4 kB | ✓ |
Legacy Client Bundles (polyfills)
zeit/next.js canary | Janpot/next.js create-next-app-tests | Change | |
---|---|---|---|
polyfills-HASH.js gzip | 26.3 kB | 26.3 kB | ✓ |
Overall change | 26.3 kB | 26.3 kB | ✓ |
Client Pages
zeit/next.js canary | Janpot/next.js create-next-app-tests | Change | |
---|---|---|---|
_app.js gzip | 1.26 kB | 1.26 kB | ✓ |
_error.js gzip | 3.28 kB | 3.28 kB | ✓ |
hooks.js gzip | 881 B | 881 B | ✓ |
index.js gzip | 222 B | 222 B | ✓ |
link.js gzip | 2.06 kB | 2.06 kB | ✓ |
routerDirect.js gzip | 279 B | 279 B | ✓ |
withRouter.js gzip | 278 B | 278 B | ✓ |
Overall change | 8.26 kB | 8.26 kB | ✓ |
Client Pages Modern
zeit/next.js canary | Janpot/next.js create-next-app-tests | Change | |
---|---|---|---|
_app.module.js gzip | 604 B | 604 B | ✓ |
_error.module.js gzip | 2.09 kB | 2.09 kB | ✓ |
hooks.module.js gzip | 383 B | 383 B | ✓ |
index.module.js gzip | 223 B | 223 B | ✓ |
link.module.js gzip | 1.52 kB | 1.52 kB | ✓ |
routerDirect..dule.js gzip | 281 B | 281 B | ✓ |
withRouter.m..dule.js gzip | 278 B | 278 B | ✓ |
Overall change | 5.38 kB | 5.38 kB | ✓ |
Client Build Manifests
zeit/next.js canary | Janpot/next.js create-next-app-tests | Change | |
---|---|---|---|
_buildManifest.js gzip | 61 B | 61 B | ✓ |
_buildManife..dule.js gzip | 61 B | 61 B | ✓ |
Overall change | 122 B | 122 B | ✓ |
Serverless bundles
zeit/next.js canary | Janpot/next.js create-next-app-tests | Change | |
---|---|---|---|
_error.js | 850 kB | 850 kB | ✓ |
404.html | 4.18 kB | 4.18 kB | ✓ |
hooks.html | 3.81 kB | 3.81 kB | ✓ |
index.js | 851 kB | 851 kB | ✓ |
link.js | 888 kB | 888 kB | ✓ |
routerDirect.js | 880 kB | 880 kB | ✓ |
withRouter.js | 880 kB | 880 kB | ✓ |
Overall change | 4.36 MB | 4.36 MB | ✓ |
Stats from current PRDefault Server Mode (Increase detected
|
zeit/next.js canary | Janpot/next.js create-next-app-tests | Change | |
---|---|---|---|
buildDuration | 12.9s | 12.8s | -122ms |
nodeModulesSize | 58.5 MB | 58.5 MB | ✓ |
Page Load Tests Overall increase ✓
zeit/next.js canary | Janpot/next.js create-next-app-tests | Change | |
---|---|---|---|
/ failed reqs | 0 | 0 | ✓ |
/ total time (seconds) | 2.267 | 2.182 | -0.08 |
/ avg req/sec | 1102.55 | 1145.76 | |
/error-in-render failed reqs | 0 | 0 | ✓ |
/error-in-render total time (seconds) | 1.441 | 1.401 | -0.04 |
/error-in-render avg req/sec | 1735.2 | 1783.98 |
Client Bundles (main, webpack, commons)
zeit/next.js canary | Janpot/next.js create-next-app-tests | Change | |
---|---|---|---|
main-HASH.js gzip | 6.67 kB | 6.67 kB | ✓ |
webpack-HASH.js gzip | 746 B | 746 B | ✓ |
de003c3a9d30..e49d.js gzip | 10.4 kB | 10.4 kB | ✓ |
framework.HASH.js gzip | 39.1 kB | 39.1 kB | ✓ |
Overall change | 57 kB | 57 kB | ✓ |
Client Bundles (main, webpack, commons) Modern
zeit/next.js canary | Janpot/next.js create-next-app-tests | Change | |
---|---|---|---|
main-HASH.module.js gzip | 5.71 kB | 5.71 kB | ✓ |
webpack-HASH..dule.js gzip | 746 B | 746 B | ✓ |
de003c3a9d30..dule.js gzip | 6.85 kB | 6.85 kB | ✓ |
framework.HA..dule.js gzip | 39.1 kB | 39.1 kB | ✓ |
Overall change | 52.4 kB | 52.4 kB | ✓ |
Legacy Client Bundles (polyfills)
zeit/next.js canary | Janpot/next.js create-next-app-tests | Change | |
---|---|---|---|
polyfills-HASH.js gzip | 26.3 kB | 26.3 kB | ✓ |
Overall change | 26.3 kB | 26.3 kB | ✓ |
Client Pages
zeit/next.js canary | Janpot/next.js create-next-app-tests | Change | |
---|---|---|---|
_app.js gzip | 1.26 kB | 1.26 kB | ✓ |
_error.js gzip | 3.28 kB | 3.28 kB | ✓ |
hooks.js gzip | 881 B | 881 B | ✓ |
index.js gzip | 222 B | 222 B | ✓ |
link.js gzip | 2.06 kB | 2.06 kB | ✓ |
routerDirect.js gzip | 279 B | 279 B | ✓ |
withRouter.js gzip | 278 B | 278 B | ✓ |
Overall change | 8.26 kB | 8.26 kB | ✓ |
Client Pages Modern
zeit/next.js canary | Janpot/next.js create-next-app-tests | Change | |
---|---|---|---|
_app.module.js gzip | 604 B | 604 B | ✓ |
_error.module.js gzip | 2.09 kB | 2.09 kB | ✓ |
hooks.module.js gzip | 383 B | 383 B | ✓ |
index.module.js gzip | 223 B | 223 B | ✓ |
link.module.js gzip | 1.52 kB | 1.52 kB | ✓ |
routerDirect..dule.js gzip | 281 B | 281 B | ✓ |
withRouter.m..dule.js gzip | 278 B | 278 B | ✓ |
Overall change | 5.38 kB | 5.38 kB | ✓ |
Client Build Manifests
zeit/next.js canary | Janpot/next.js create-next-app-tests | Change | |
---|---|---|---|
_buildManifest.js gzip | 61 B | 61 B | ✓ |
_buildManife..dule.js gzip | 61 B | 61 B | ✓ |
Overall change | 122 B | 122 B | ✓ |
Rendered Page Sizes
zeit/next.js canary | Janpot/next.js create-next-app-tests | Change | |
---|---|---|---|
index.html gzip | 926 B | 926 B | ✓ |
link.html gzip | 936 B | 936 B | ✓ |
withRouter.html gzip | 923 B | 923 B | ✓ |
Overall change | 2.79 kB | 2.79 kB | ✓ |
Serverless Mode
General
zeit/next.js canary | Janpot/next.js create-next-app-tests | Change | |
---|---|---|---|
buildDuration | 13.6s | 13.9s | |
nodeModulesSize | 58.5 MB | 58.5 MB | ✓ |
Client Bundles (main, webpack, commons)
zeit/next.js canary | Janpot/next.js create-next-app-tests | Change | |
---|---|---|---|
main-HASH.js gzip | 6.67 kB | 6.67 kB | ✓ |
webpack-HASH.js gzip | 746 B | 746 B | ✓ |
de003c3a9d30..e49d.js gzip | 10.4 kB | 10.4 kB | ✓ |
framework.HASH.js gzip | 39.1 kB | 39.1 kB | ✓ |
Overall change | 57 kB | 57 kB | ✓ |
Client Bundles (main, webpack, commons) Modern
zeit/next.js canary | Janpot/next.js create-next-app-tests | Change | |
---|---|---|---|
main-HASH.module.js gzip | 5.71 kB | 5.71 kB | ✓ |
webpack-HASH..dule.js gzip | 746 B | 746 B | ✓ |
de003c3a9d30..dule.js gzip | 6.85 kB | 6.85 kB | ✓ |
framework.HA..dule.js gzip | 39.1 kB | 39.1 kB | ✓ |
Overall change | 52.4 kB | 52.4 kB | ✓ |
Legacy Client Bundles (polyfills)
zeit/next.js canary | Janpot/next.js create-next-app-tests | Change | |
---|---|---|---|
polyfills-HASH.js gzip | 26.3 kB | 26.3 kB | ✓ |
Overall change | 26.3 kB | 26.3 kB | ✓ |
Client Pages
zeit/next.js canary | Janpot/next.js create-next-app-tests | Change | |
---|---|---|---|
_app.js gzip | 1.26 kB | 1.26 kB | ✓ |
_error.js gzip | 3.28 kB | 3.28 kB | ✓ |
hooks.js gzip | 881 B | 881 B | ✓ |
index.js gzip | 222 B | 222 B | ✓ |
link.js gzip | 2.06 kB | 2.06 kB | ✓ |
routerDirect.js gzip | 279 B | 279 B | ✓ |
withRouter.js gzip | 278 B | 278 B | ✓ |
Overall change | 8.26 kB | 8.26 kB | ✓ |
Client Pages Modern
zeit/next.js canary | Janpot/next.js create-next-app-tests | Change | |
---|---|---|---|
_app.module.js gzip | 604 B | 604 B | ✓ |
_error.module.js gzip | 2.09 kB | 2.09 kB | ✓ |
hooks.module.js gzip | 383 B | 383 B | ✓ |
index.module.js gzip | 223 B | 223 B | ✓ |
link.module.js gzip | 1.52 kB | 1.52 kB | ✓ |
routerDirect..dule.js gzip | 281 B | 281 B | ✓ |
withRouter.m..dule.js gzip | 278 B | 278 B | ✓ |
Overall change | 5.38 kB | 5.38 kB | ✓ |
Client Build Manifests
zeit/next.js canary | Janpot/next.js create-next-app-tests | Change | |
---|---|---|---|
_buildManifest.js gzip | 61 B | 61 B | ✓ |
_buildManife..dule.js gzip | 61 B | 61 B | ✓ |
Overall change | 122 B | 122 B | ✓ |
Serverless bundles
zeit/next.js canary | Janpot/next.js create-next-app-tests | Change | |
---|---|---|---|
_error.js | 850 kB | 850 kB | ✓ |
404.html | 4.18 kB | 4.18 kB | ✓ |
hooks.html | 3.81 kB | 3.81 kB | ✓ |
index.js | 851 kB | 851 kB | ✓ |
link.js | 888 kB | 888 kB | ✓ |
routerDirect.js | 880 kB | 880 kB | ✓ |
withRouter.js | 880 kB | 880 kB | ✓ |
Overall change | 4.36 MB | 4.36 MB | ✓ |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Created as a draft PR to see if the theory holds.
Follow up of #12974
Some tests were disabled on windows. Based on the comment next to them they seem to stall on windows. I reviewed the code and found an issue that is similar to one I spotted before. I converted the code to use the
readline
interface. This should guarantee we always receive whole lines.I also changed some unnecessary sync methods to async