New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Font optimization for webpack 5 #17450
Merged
Merged
Changes from 2 commits
Commits
Show all changes
24 commits
Select commit
Hold shift + click to select a range
c7b90c4
fixing font optimization for webpack 5
prateekbh 5a56ccd
fixing comment language
prateekbh 273192f
enable font optimization test for webpack 5
prateekbh 0de4172
Merge branch 'canary' of https://github.com/zeit/next.js into font-we…
prateekbh cc429a2
changing tests order
prateekbh 3746058
updating webpack version
prateekbh b11d239
Merge branch 'canary' into font-webpack5
prateekbh e11dcb8
making webpack version logged
prateekbh 57d6399
Merge branch 'canary' into font-webpack5
prateekbh 8a1b7a2
more logging
prateekbh 8507323
Merge branch 'font-webpack5' of https://github.com/azukaru/next.js in…
prateekbh 5f14ed7
one more log
prateekbh ac6ec8a
some changes
prateekbh 14bd5da
reverting unwanted changes
prateekbh eea002a
some changes
prateekbh 6637989
Merge branch 'canary' of https://github.com/azukaru/next.js into font…
prateekbh 9bfcd29
adding resolutions to package/next instead of root
prateekbh c32dfd7
preview package.json
prateekbh 16bbd70
fixing url
prateekbh c5e8fe7
Apply suggestions from code review
timneutkens 23d862e
Revert "Apply suggestions from code review"
timneutkens 2a3e1a9
Merge branch 'canary' of https://github.com/zeit/next.js into font-we…
prateekbh 4299ce2
removing unwanted logs
prateekbh 56a8e0d
Merge branch 'canary' into font-webpack5
prateekbh File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this be wrapped in
if(isWebpack5)
then?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i guess that would be a safe option.
can you give me a pointer on how to run these test in webpack 5?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cd packages/next && yarn add webpack@next
basically 👍There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done