Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to postcss-loader 4.0.2. #17458

Merged
merged 3 commits into from Oct 19, 2020
Merged

Update to postcss-loader 4.0.2. #17458

merged 3 commits into from Oct 19, 2020

Commits on Oct 10, 2020

  1. Update to postcss-loader 4.0.3.

    - postcss-loader 4.0 improves compatibility with webpack 5.
    - the 4.0.2 and 4.0.3 release notes also mention improved PostCSS 8 compatibility (see issue #17242)
    - postcss-loader by default now detects external PostCss configs and merges them with loader options,
      so I have disabled this to preserve Next’s current behaviour. For example, Next accepts JSON configs with comments,
      but postcss-loader fails to load them.
    - when patching the loader configuration, I try to detect the `postcssOptions` field instead of `ident`
      as now passing an `ident` field to the postcss-loader options triggers a schema validation error
    - in one error overlay integration test, I check whether the error message contains the expected strings
      instead of matching a snapshot exactly, as now the postcss loader inserts the file path from the filesystem
      root in the error message, which we can’t match exactly across test runs
    - updating postcss-loader to 4.0.4 breaks, because `4.0.4` requires schema-utils `^3.0.0`, but the ncc build
      prevents postcss-loader from using its own schema-utils
    ludofischer committed Oct 10, 2020
    Copy the full SHA
    25bb907 View commit details
    Browse the repository at this point in the history

Commits on Oct 19, 2020

  1. Copy the full SHA
    fa02312 View commit details
    Browse the repository at this point in the history
  2. Copy the full SHA
    bac74ec View commit details
    Browse the repository at this point in the history