Enable eslint for async modules tests #17892

Janpot · 2020-10-14T20:39:03Z

Upgrade eslint toolchain and enable eslint on the top-level-await tests from #17590

ijjk · 2020-10-14T20:46:26Z

Failing test suites

Commit: 0f02574

test/integration/async-modules/test/index.test.js

Expand output

● Test suite failed to run

/home/runner/work/next.js/next.js/test/integration/async-modules/test/index.test.js:2
import webdriver from 'next-webdriver';
^^^^^^

SyntaxError: Cannot use import statement outside a module

  at ScriptTransformer._transformAndBuildScript (../node_modules/@jest/transform/build/ScriptTransformer.js:537:17)
  at ScriptTransformer.transform (../node_modules/@jest/transform/build/ScriptTransformer.js:579:25)

ijjk · 2020-10-14T20:57:22Z

Failing test suites

Commit: 272d237

test/integration/async-modules/test/index.test.js

Expand output

● Test suite failed to run

/home/runner/work/next.js/next.js/test/integration/async-modules/test/index.test.js:2
import webdriver from 'next-webdriver';
^^^^^^

SyntaxError: Cannot use import statement outside a module

  at ScriptTransformer._transformAndBuildScript (../node_modules/@jest/transform/build/ScriptTransformer.js:537:17)
  at ScriptTransformer.transform (../node_modules/@jest/transform/build/ScriptTransformer.js:579:25)

ijjk · 2020-10-14T20:58:58Z

Stats from current PR

Default Server Mode (Decrease detected ✓)

General

	vercel/next.js canary	Janpot/next.js babel-eslint	Change
buildDuration	10.8s	10.9s	⚠️ +105ms
nodeModulesSize	64.3 MB	64.3 MB	✓

Page Load Tests Overall decrease ⚠️

	vercel/next.js canary	Janpot/next.js babel-eslint	Change
/ failed reqs	0	0	✓
/ total time (seconds)	2.055	2.027	-0.03
/ avg req/sec	1216.26	1233.53	+17.27
/error-in-render failed reqs	0	0	✓
/error-in-render total time (seconds)	1.099	1.137	⚠️ +0.04
/error-in-render avg req/sec	2275.36	2199.27	⚠️ -76.09

Client Bundles (main, webpack, commons)

	vercel/next.js canary	Janpot/next.js babel-eslint	Change
677f882d2ed8..133b.js gzip	11.1 kB	11.1 kB	✓
framework.HASH.js gzip	39 kB	39 kB	✓
main-3fae807..efe0.js gzip	7.3 kB	7.3 kB	✓
webpack-e067..f178.js gzip	751 B	751 B	✓
Overall change	58.1 kB	58.1 kB	✓

Client Bundles (main, webpack, commons) Modern

	vercel/next.js canary	Janpot/next.js babel-eslint	Change
677f882d2ed8..dule.js gzip	6.9 kB	6.9 kB	✓
framework.HA..dule.js gzip	39 kB	39 kB	✓
main-8ac5189..dule.js gzip	6.29 kB	6.29 kB	✓
webpack-07c5..dule.js gzip	751 B	751 B	✓
Overall change	52.9 kB	52.9 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	Janpot/next.js babel-eslint	Change
polyfills-4b..e242.js gzip	31 kB	31 kB	✓
Overall change	31 kB	31 kB	✓

Client Pages

	vercel/next.js canary	Janpot/next.js babel-eslint	Change
_app-9a0b9e1..b37e.js gzip	1.28 kB	1.28 kB	✓
_error-ed1b0..8fbd.js gzip	3.44 kB	3.44 kB	✓
hooks-89731c..c609.js gzip	887 B	887 B	✓
index-17468f..5d83.js gzip	227 B	227 B	✓
link-409b283..e3ab.js gzip	1.32 kB	1.32 kB	✓
routerDirect..924c.js gzip	284 B	284 B	✓
withRouter-7..c13d.js gzip	284 B	284 B	✓
Overall change	7.73 kB	7.73 kB	✓

Client Pages Modern

	vercel/next.js canary	Janpot/next.js babel-eslint	Change
_app-75d3a82..dule.js gzip	625 B	625 B	✓
_error-4469a..dule.js gzip	2.29 kB	2.29 kB	✓
hooks-cbf13f..dule.js gzip	387 B	387 B	✓
index-b9a643..dule.js gzip	226 B	226 B	✓
link-92d3016..dule.js gzip	1.28 kB	1.28 kB	✓
routerDirect..dule.js gzip	284 B	284 B	✓
withRouter-f..dule.js gzip	282 B	282 B	✓
Overall change	5.37 kB	5.37 kB	✓

Client Build Manifests

	vercel/next.js canary	Janpot/next.js babel-eslint	Change
_buildManifest.js gzip	323 B	323 B	✓
_buildManife..dule.js gzip	329 B	329 B	✓
Overall change	652 B	652 B	✓

Rendered Page Sizes

	vercel/next.js canary	Janpot/next.js babel-eslint	Change
index.html gzip	1 kB	1 kB	✓
link.html gzip	1.01 kB	1.01 kB	✓
withRouter.html gzip	995 B	995 B	✓
Overall change	3.01 kB	3.01 kB	✓

Serverless Mode

General

	vercel/next.js canary	Janpot/next.js babel-eslint	Change
buildDuration	12.6s	12.3s	-298ms
nodeModulesSize	64.3 MB	64.3 MB	✓

Client Bundles (main, webpack, commons)

	vercel/next.js canary	Janpot/next.js babel-eslint	Change
677f882d2ed8..133b.js gzip	11.1 kB	11.1 kB	✓
framework.HASH.js gzip	39 kB	39 kB	✓
main-3fae807..efe0.js gzip	7.3 kB	7.3 kB	✓
webpack-e067..f178.js gzip	751 B	751 B	✓
Overall change	58.1 kB	58.1 kB	✓

Client Bundles (main, webpack, commons) Modern

	vercel/next.js canary	Janpot/next.js babel-eslint	Change
677f882d2ed8..dule.js gzip	6.9 kB	6.9 kB	✓
framework.HA..dule.js gzip	39 kB	39 kB	✓
main-8ac5189..dule.js gzip	6.29 kB	6.29 kB	✓
webpack-07c5..dule.js gzip	751 B	751 B	✓
Overall change	52.9 kB	52.9 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	Janpot/next.js babel-eslint	Change
polyfills-4b..e242.js gzip	31 kB	31 kB	✓
Overall change	31 kB	31 kB	✓

Client Pages

	vercel/next.js canary	Janpot/next.js babel-eslint	Change
_app-9a0b9e1..b37e.js gzip	1.28 kB	1.28 kB	✓
_error-ed1b0..8fbd.js gzip	3.44 kB	3.44 kB	✓
hooks-89731c..c609.js gzip	887 B	887 B	✓
index-17468f..5d83.js gzip	227 B	227 B	✓
link-409b283..e3ab.js gzip	1.32 kB	1.32 kB	✓
routerDirect..924c.js gzip	284 B	284 B	✓
withRouter-7..c13d.js gzip	284 B	284 B	✓
Overall change	7.73 kB	7.73 kB	✓

Client Pages Modern

	vercel/next.js canary	Janpot/next.js babel-eslint	Change
_app-75d3a82..dule.js gzip	625 B	625 B	✓
_error-4469a..dule.js gzip	2.29 kB	2.29 kB	✓
hooks-cbf13f..dule.js gzip	387 B	387 B	✓
index-b9a643..dule.js gzip	226 B	226 B	✓
link-92d3016..dule.js gzip	1.28 kB	1.28 kB	✓
routerDirect..dule.js gzip	284 B	284 B	✓
withRouter-f..dule.js gzip	282 B	282 B	✓
Overall change	5.37 kB	5.37 kB	✓

Client Build Manifests

	vercel/next.js canary	Janpot/next.js babel-eslint	Change
_buildManifest.js gzip	323 B	323 B	✓
_buildManife..dule.js gzip	329 B	329 B	✓
Overall change	652 B	652 B	✓

Serverless bundles

	vercel/next.js canary	Janpot/next.js babel-eslint	Change
_error.js	1.06 MB	1.06 MB	✓
404.html	4.34 kB	4.34 kB	✓
hooks.html	3.92 kB	3.92 kB	✓
index.js	1.06 MB	1.06 MB	✓
link.js	1.1 MB	1.1 MB	✓
routerDirect.js	1.1 MB	1.1 MB	✓
withRouter.js	1.1 MB	1.1 MB	✓
Overall change	5.41 MB	5.41 MB	✓

Commit: 272d237

Janpot added 2 commits October 14, 2020 20:02

Update babel eslint to @babel/eslint-parser

446fede

lint the async-modules test

0f02574

ijjk added the examples Issue/PR related to examples label Oct 14, 2020

Merge branch 'canary' into babel-eslint

272d237

Janpot added 3 commits October 14, 2020 23:00

fix test

28978cf

Merge remote-tracking branch 'upstream/canary' into babel-eslint

c70f9bf

compile

a51ba94

ijjk added the type: next label Oct 14, 2020

Janpot changed the title ~~Enable linting async modules tests~~ Enable eslint for async modules tests Oct 14, 2020

Janpot added 6 commits October 15, 2020 13:54

Merge branch 'canary' into babel-eslint

bedabb6

yarn.lock microsurgery

2e07db1

update eslint

d7e03bd

precompiled

416c65b

not going to touch examples here

914058c

Merge branch 'canary' into babel-eslint

b955bfc

Janpot marked this pull request as ready for review October 15, 2020 15:37

Janpot requested review from chibicode, ijjk, lfades, Timer and timneutkens as code owners October 15, 2020 15:37

Merge remote-tracking branch 'upstream/canary' into babel-eslint

23f56ab

ijjk added create-next-app Related to our CLI tool for quickly starting a new Next.js application. type: documentation labels Oct 18, 2020

Janpot closed this Oct 18, 2020

Janpot deleted the babel-eslint branch October 18, 2020 14:12

timneutkens added the hacktoberfest-accepted label Oct 19, 2020

vercel locked as resolved and limited conversation to collaborators Jan 29, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Enable eslint for async modules tests #17892

Enable eslint for async modules tests #17892

Janpot commented Oct 14, 2020 •

edited

ijjk commented Oct 14, 2020

ijjk commented Oct 14, 2020

ijjk commented Oct 14, 2020

Enable eslint for async modules tests #17892

Enable eslint for async modules tests #17892

Conversation

Janpot commented Oct 14, 2020 • edited

ijjk commented Oct 14, 2020

Failing test suites

ijjk commented Oct 14, 2020

Failing test suites

ijjk commented Oct 14, 2020

Stats from current PR

Janpot commented Oct 14, 2020 •

edited