Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable purgeLayersByDefault on examples using tailwindcss #17986

Closed
wants to merge 1 commit into from
Closed

Enable purgeLayersByDefault on examples using tailwindcss #17986

wants to merge 1 commit into from

Conversation

JohnTitor
Copy link

@JohnTitor JohnTitor commented Oct 18, 2020

The newer tailwindcss emits the warning, like:

warn - The `conservative` purge mode will be removed in Tailwind 2.0.
warn - Please switch to the new `layers` mode instead.

This should remove it on the examples using tailwindcss with the purge config. #17742 applied the new config to one example but this applies it to (hopefully) all the examples here.
ref. https://tailwindcss.com/docs/upcoming-changes#purge-layers-by-default

@ijjk ijjk added the examples Issue/PR related to examples label Oct 18, 2020
@JohnTitor
Copy link
Author

Oops, should've seen the examples actually, closing for now.

@JohnTitor JohnTitor closed this Oct 18, 2020
@JohnTitor JohnTitor reopened this Oct 18, 2020
@ijjk
Copy link
Member

ijjk commented Oct 18, 2020

Stats from current PR

Default Server Mode (Decrease detected ✓)
General
vercel/next.js canary JohnTitor/next.js tailwind-purge Change
buildDuration 13.1s 13.5s ⚠️ +338ms
nodeModulesSize 64.4 MB 64.4 MB
Page Load Tests Overall decrease ⚠️
vercel/next.js canary JohnTitor/next.js tailwind-purge Change
/ failed reqs 0 0
/ total time (seconds) 2.445 2.535 ⚠️ +0.09
/ avg req/sec 1022.49 986.21 ⚠️ -36.28
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.307 1.303 0
/error-in-render avg req/sec 1912.54 1918.36 +5.82
Client Bundles (main, webpack, commons)
vercel/next.js canary JohnTitor/next.js tailwind-purge Change
677f882d2ed8..7765.js gzip 11.1 kB 11.1 kB
framework.HASH.js gzip 39 kB 39 kB
main-5aa1543..4e79.js gzip 7.34 kB 7.34 kB
webpack-e067..f178.js gzip 751 B 751 B
Overall change 58.1 kB 58.1 kB
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary JohnTitor/next.js tailwind-purge Change
677f882d2ed8..dule.js gzip 6.94 kB 6.94 kB
framework.HA..dule.js gzip 39 kB 39 kB
main-7d849dd..dule.js gzip 6.32 kB 6.32 kB
webpack-07c5..dule.js gzip 751 B 751 B
Overall change 53 kB 53 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary JohnTitor/next.js tailwind-purge Change
polyfills-4b..e242.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary JohnTitor/next.js tailwind-purge Change
_app-9a0b9e1..b37e.js gzip 1.28 kB 1.28 kB
_error-ed1b0..8fbd.js gzip 3.44 kB 3.44 kB
hooks-89731c..c609.js gzip 887 B 887 B
index-17468f..5d83.js gzip 227 B 227 B
link-89ad9e7..25bb.js gzip 1.34 kB 1.34 kB
routerDirect..924c.js gzip 284 B 284 B
withRouter-7..c13d.js gzip 284 B 284 B
Overall change 7.74 kB 7.74 kB
Client Pages Modern
vercel/next.js canary JohnTitor/next.js tailwind-purge Change
_app-75d3a82..dule.js gzip 625 B 625 B
_error-4469a..dule.js gzip 2.29 kB 2.29 kB
hooks-cbf13f..dule.js gzip 387 B 387 B
index-b9a643..dule.js gzip 226 B 226 B
link-aeb707b..dule.js gzip 1.29 kB 1.29 kB
routerDirect..dule.js gzip 284 B 284 B
withRouter-f..dule.js gzip 282 B 282 B
Overall change 5.39 kB 5.39 kB
Client Build Manifests
vercel/next.js canary JohnTitor/next.js tailwind-purge Change
_buildManifest.js gzip 322 B 322 B
_buildManife..dule.js gzip 329 B 329 B
Overall change 651 B 651 B
Rendered Page Sizes
vercel/next.js canary JohnTitor/next.js tailwind-purge Change
index.html gzip 1 kB 1 kB
link.html gzip 1.01 kB 1.01 kB
withRouter.html gzip 996 B 996 B
Overall change 3.01 kB 3.01 kB

Serverless Mode
General
vercel/next.js canary JohnTitor/next.js tailwind-purge Change
buildDuration 15.5s 15.1s -390ms
nodeModulesSize 64.4 MB 64.4 MB
Client Bundles (main, webpack, commons)
vercel/next.js canary JohnTitor/next.js tailwind-purge Change
677f882d2ed8..7765.js gzip 11.1 kB 11.1 kB
framework.HASH.js gzip 39 kB 39 kB
main-5aa1543..4e79.js gzip 7.34 kB 7.34 kB
webpack-e067..f178.js gzip 751 B 751 B
Overall change 58.1 kB 58.1 kB
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary JohnTitor/next.js tailwind-purge Change
677f882d2ed8..dule.js gzip 6.94 kB 6.94 kB
framework.HA..dule.js gzip 39 kB 39 kB
main-7d849dd..dule.js gzip 6.32 kB 6.32 kB
webpack-07c5..dule.js gzip 751 B 751 B
Overall change 53 kB 53 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary JohnTitor/next.js tailwind-purge Change
polyfills-4b..e242.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary JohnTitor/next.js tailwind-purge Change
_app-9a0b9e1..b37e.js gzip 1.28 kB 1.28 kB
_error-ed1b0..8fbd.js gzip 3.44 kB 3.44 kB
hooks-89731c..c609.js gzip 887 B 887 B
index-17468f..5d83.js gzip 227 B 227 B
link-89ad9e7..25bb.js gzip 1.34 kB 1.34 kB
routerDirect..924c.js gzip 284 B 284 B
withRouter-7..c13d.js gzip 284 B 284 B
Overall change 7.74 kB 7.74 kB
Client Pages Modern
vercel/next.js canary JohnTitor/next.js tailwind-purge Change
_app-75d3a82..dule.js gzip 625 B 625 B
_error-4469a..dule.js gzip 2.29 kB 2.29 kB
hooks-cbf13f..dule.js gzip 387 B 387 B
index-b9a643..dule.js gzip 226 B 226 B
link-aeb707b..dule.js gzip 1.29 kB 1.29 kB
routerDirect..dule.js gzip 284 B 284 B
withRouter-f..dule.js gzip 282 B 282 B
Overall change 5.39 kB 5.39 kB
Client Build Manifests
vercel/next.js canary JohnTitor/next.js tailwind-purge Change
_buildManifest.js gzip 322 B 322 B
_buildManife..dule.js gzip 329 B 329 B
Overall change 651 B 651 B
Serverless bundles
vercel/next.js canary JohnTitor/next.js tailwind-purge Change
_error.js 1.06 MB 1.06 MB
404.html 4.34 kB 4.34 kB
hooks.html 3.92 kB 3.92 kB
index.js 1.06 MB 1.06 MB
link.js 1.1 MB 1.1 MB
routerDirect.js 1.1 MB 1.1 MB
withRouter.js 1.1 MB 1.1 MB
Overall change 5.42 MB 5.42 MB
Commit: 2b79c26

@JohnTitor
Copy link
Author

Okay, should be fine now!

@JohnTitor JohnTitor closed this Nov 11, 2020
@JohnTitor JohnTitor deleted the tailwind-purge branch November 11, 2020 21:43
@vercel vercel locked as resolved and limited conversation to collaborators Jan 29, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
examples Issue/PR related to examples
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants