Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade use-subscription for React 16/17 bicompat #19087

Merged
merged 2 commits into from Nov 12, 2020
Merged

Upgrade use-subscription for React 16/17 bicompat #19087

merged 2 commits into from Nov 12, 2020

Conversation

Timer
Copy link
Member

@Timer Timer commented Nov 12, 2020

Fixes #18518

@vercel vercel bot temporarily deployed to Preview November 12, 2020 05:14 Inactive
@ijjk
Copy link
Member

ijjk commented Nov 12, 2020

Stats from current PR

Default Server Mode (Increase detected ⚠️)
General Overall decrease ✓
vercel/next.js canary Timer/next.js hotfix/upgrade-use-subscription Change
buildDuration 12.6s 12.8s ⚠️ +155ms
nodeModulesSize 84.8 MB 84.8 MB -152 B
Page Load Tests Overall increase ✓
vercel/next.js canary Timer/next.js hotfix/upgrade-use-subscription Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.326 2.343 ⚠️ +0.02
/ avg req/sec 1074.66 1067.23 ⚠️ -7.43
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.291 1.214 -0.08
/error-in-render avg req/sec 1936.89 2060.06 +123.17
Client Bundles (main, webpack, commons)
vercel/next.js canary Timer/next.js hotfix/upgrade-use-subscription Change
677f882d2ed8..3c49.js gzip 12.6 kB 12.6 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-15d43b2..eae1.js gzip 6.48 kB 6.48 kB ✓
webpack-e067..f178.js gzip 751 B 751 B ✓
Overall change 58.8 kB 58.8 kB ✓
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary Timer/next.js hotfix/upgrade-use-subscription Change
677f882d2ed8..dule.js gzip 8.22 kB 8.22 kB ✓
framework.HA..dule.js gzip 39 kB 39 kB ✓
main-351dac8..dule.js gzip 5.58 kB 5.58 kB ✓
webpack-07c5..dule.js gzip 751 B 751 B ✓
Overall change 53.5 kB 53.5 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary Timer/next.js hotfix/upgrade-use-subscription Change
polyfills-4b..e242.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary Timer/next.js hotfix/upgrade-use-subscription Change
_app-3b0cf13..85f8.js gzip 1.28 kB 1.28 kB ✓
_error-6f635..c393.js gzip 3.44 kB 3.44 kB ✓
hooks-d4ffc3..9e0f.js gzip 887 B 887 B ✓
index-17468f..5d83.js gzip 227 B 227 B ✓
link-d9a15a0..130a.js gzip 1.57 kB 1.57 kB ✓
routerDirect..924c.js gzip 284 B 284 B ✓
withRouter-7..c13d.js gzip 284 B 284 B ✓
Overall change 7.98 kB 7.98 kB ✓
Client Pages Modern
vercel/next.js canary Timer/next.js hotfix/upgrade-use-subscription Change
_app-75d3a82..dule.js gzip 625 B 625 B ✓
_error-f2fcc..dule.js gzip 2.29 kB 2.29 kB ✓
hooks-cbf13f..dule.js gzip 387 B 387 B ✓
index-b9a643..dule.js gzip 226 B 226 B ✓
link-973cce3..dule.js gzip 1.51 kB 1.51 kB ✓
routerDirect..dule.js gzip 284 B 284 B ✓
withRouter-f..dule.js gzip 282 B 282 B ✓
Overall change 5.6 kB 5.6 kB ✓
Client Build Manifests
vercel/next.js canary Timer/next.js hotfix/upgrade-use-subscription Change
_buildManifest.js gzip 321 B 321 B ✓
_buildManife..dule.js gzip 330 B 330 B ✓
Overall change 651 B 651 B ✓
Rendered Page Sizes
vercel/next.js canary Timer/next.js hotfix/upgrade-use-subscription Change
index.html gzip 970 B 970 B ✓
link.html gzip 975 B 975 B ✓
withRouter.html gzip 963 B 963 B ✓
Overall change 2.91 kB 2.91 kB ✓
Serverless Mode (Increase detected ⚠️)
General Overall decrease ✓
vercel/next.js canary Timer/next.js hotfix/upgrade-use-subscription Change
buildDuration 14.1s 14.6s ⚠️ +545ms
nodeModulesSize 84.8 MB 84.8 MB -152 B
Client Bundles (main, webpack, commons)
vercel/next.js canary Timer/next.js hotfix/upgrade-use-subscription Change
677f882d2ed8..3c49.js gzip 12.6 kB 12.6 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-15d43b2..eae1.js gzip 6.48 kB 6.48 kB ✓
webpack-e067..f178.js gzip 751 B 751 B ✓
Overall change 58.8 kB 58.8 kB ✓
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary Timer/next.js hotfix/upgrade-use-subscription Change
677f882d2ed8..dule.js gzip 8.22 kB 8.22 kB ✓
framework.HA..dule.js gzip 39 kB 39 kB ✓
main-351dac8..dule.js gzip 5.58 kB 5.58 kB ✓
webpack-07c5..dule.js gzip 751 B 751 B ✓
Overall change 53.5 kB 53.5 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary Timer/next.js hotfix/upgrade-use-subscription Change
polyfills-4b..e242.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary Timer/next.js hotfix/upgrade-use-subscription Change
_app-3b0cf13..85f8.js gzip 1.28 kB 1.28 kB ✓
_error-6f635..c393.js gzip 3.44 kB 3.44 kB ✓
hooks-d4ffc3..9e0f.js gzip 887 B 887 B ✓
index-17468f..5d83.js gzip 227 B 227 B ✓
link-d9a15a0..130a.js gzip 1.57 kB 1.57 kB ✓
routerDirect..924c.js gzip 284 B 284 B ✓
withRouter-7..c13d.js gzip 284 B 284 B ✓
Overall change 7.98 kB 7.98 kB ✓
Client Pages Modern
vercel/next.js canary Timer/next.js hotfix/upgrade-use-subscription Change
_app-75d3a82..dule.js gzip 625 B 625 B ✓
_error-f2fcc..dule.js gzip 2.29 kB 2.29 kB ✓
hooks-cbf13f..dule.js gzip 387 B 387 B ✓
index-b9a643..dule.js gzip 226 B 226 B ✓
link-973cce3..dule.js gzip 1.51 kB 1.51 kB ✓
routerDirect..dule.js gzip 284 B 284 B ✓
withRouter-f..dule.js gzip 282 B 282 B ✓
Overall change 5.6 kB 5.6 kB ✓
Client Build Manifests
vercel/next.js canary Timer/next.js hotfix/upgrade-use-subscription Change
_buildManifest.js gzip 321 B 321 B ✓
_buildManife..dule.js gzip 330 B 330 B ✓
Overall change 651 B 651 B ✓
Serverless bundles Overall increase ⚠️
vercel/next.js canary Timer/next.js hotfix/upgrade-use-subscription Change
_error.js 916 kB 916 kB ⚠️ +4 B
404.html 4.61 kB 4.61 kB ✓
hooks.html 3.86 kB 3.86 kB ✓
index.js 916 kB 916 kB ⚠️ +4 B
link.js 974 kB 974 kB ⚠️ +4 B
routerDirect.js 967 kB 967 kB ⚠️ +4 B
withRouter.js 967 kB 967 kB ⚠️ +4 B
Overall change 4.75 MB 4.75 MB ⚠️ +20 B
Commit: 565e6d2

@ijjk
Copy link
Member

ijjk commented Nov 12, 2020

Stats from current PR

Default Server Mode (Decrease detected ✓)
General Overall decrease ✓
vercel/next.js canary Timer/next.js hotfix/upgrade-use-subscription Change
buildDuration 13.9s 13.8s -67ms
nodeModulesSize 84.8 MB 84.8 MB -152 B
Page Load Tests Overall decrease ⚠️
vercel/next.js canary Timer/next.js hotfix/upgrade-use-subscription Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.581 2.705 ⚠️ +0.12
/ avg req/sec 968.79 924.11 ⚠️ -44.68
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.556 1.532 -0.02
/error-in-render avg req/sec 1607.19 1631.37 +24.18
Client Bundles (main, webpack, commons)
vercel/next.js canary Timer/next.js hotfix/upgrade-use-subscription Change
677f882d2ed8..e2a1.js gzip 12.7 kB 12.7 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-15d43b2..eae1.js gzip 6.48 kB 6.48 kB ✓
webpack-e067..f178.js gzip 751 B 751 B ✓
Overall change 58.9 kB 58.9 kB ✓
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary Timer/next.js hotfix/upgrade-use-subscription Change
677f882d2ed8..dule.js gzip 8.23 kB 8.23 kB ✓
framework.HA..dule.js gzip 39 kB 39 kB ✓
main-351dac8..dule.js gzip 5.58 kB 5.58 kB ✓
webpack-07c5..dule.js gzip 751 B 751 B ✓
Overall change 53.5 kB 53.5 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary Timer/next.js hotfix/upgrade-use-subscription Change
polyfills-4b..e242.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary Timer/next.js hotfix/upgrade-use-subscription Change
_app-3b0cf13..85f8.js gzip 1.28 kB 1.28 kB ✓
_error-6f635..c393.js gzip 3.44 kB 3.44 kB ✓
hooks-d4ffc3..9e0f.js gzip 887 B 887 B ✓
index-17468f..5d83.js gzip 227 B 227 B ✓
link-d9a15a0..130a.js gzip 1.57 kB 1.57 kB ✓
routerDirect..924c.js gzip 284 B 284 B ✓
withRouter-7..c13d.js gzip 284 B 284 B ✓
Overall change 7.98 kB 7.98 kB ✓
Client Pages Modern
vercel/next.js canary Timer/next.js hotfix/upgrade-use-subscription Change
_app-75d3a82..dule.js gzip 625 B 625 B ✓
_error-f2fcc..dule.js gzip 2.29 kB 2.29 kB ✓
hooks-cbf13f..dule.js gzip 387 B 387 B ✓
index-b9a643..dule.js gzip 226 B 226 B ✓
link-973cce3..dule.js gzip 1.51 kB 1.51 kB ✓
routerDirect..dule.js gzip 284 B 284 B ✓
withRouter-f..dule.js gzip 282 B 282 B ✓
Overall change 5.6 kB 5.6 kB ✓
Client Build Manifests
vercel/next.js canary Timer/next.js hotfix/upgrade-use-subscription Change
_buildManifest.js gzip 321 B 321 B ✓
_buildManife..dule.js gzip 330 B 330 B ✓
Overall change 651 B 651 B ✓
Rendered Page Sizes
vercel/next.js canary Timer/next.js hotfix/upgrade-use-subscription Change
index.html gzip 969 B 969 B ✓
link.html gzip 975 B 975 B ✓
withRouter.html gzip 962 B 962 B ✓
Overall change 2.91 kB 2.91 kB ✓
Serverless Mode (Increase detected ⚠️)
General Overall decrease ✓
vercel/next.js canary Timer/next.js hotfix/upgrade-use-subscription Change
buildDuration 15.6s 15.3s -297ms
nodeModulesSize 84.8 MB 84.8 MB -152 B
Client Bundles (main, webpack, commons)
vercel/next.js canary Timer/next.js hotfix/upgrade-use-subscription Change
677f882d2ed8..e2a1.js gzip 12.7 kB 12.7 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-15d43b2..eae1.js gzip 6.48 kB 6.48 kB ✓
webpack-e067..f178.js gzip 751 B 751 B ✓
Overall change 58.9 kB 58.9 kB ✓
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary Timer/next.js hotfix/upgrade-use-subscription Change
677f882d2ed8..dule.js gzip 8.23 kB 8.23 kB ✓
framework.HA..dule.js gzip 39 kB 39 kB ✓
main-351dac8..dule.js gzip 5.58 kB 5.58 kB ✓
webpack-07c5..dule.js gzip 751 B 751 B ✓
Overall change 53.5 kB 53.5 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary Timer/next.js hotfix/upgrade-use-subscription Change
polyfills-4b..e242.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary Timer/next.js hotfix/upgrade-use-subscription Change
_app-3b0cf13..85f8.js gzip 1.28 kB 1.28 kB ✓
_error-6f635..c393.js gzip 3.44 kB 3.44 kB ✓
hooks-d4ffc3..9e0f.js gzip 887 B 887 B ✓
index-17468f..5d83.js gzip 227 B 227 B ✓
link-d9a15a0..130a.js gzip 1.57 kB 1.57 kB ✓
routerDirect..924c.js gzip 284 B 284 B ✓
withRouter-7..c13d.js gzip 284 B 284 B ✓
Overall change 7.98 kB 7.98 kB ✓
Client Pages Modern
vercel/next.js canary Timer/next.js hotfix/upgrade-use-subscription Change
_app-75d3a82..dule.js gzip 625 B 625 B ✓
_error-f2fcc..dule.js gzip 2.29 kB 2.29 kB ✓
hooks-cbf13f..dule.js gzip 387 B 387 B ✓
index-b9a643..dule.js gzip 226 B 226 B ✓
link-973cce3..dule.js gzip 1.51 kB 1.51 kB ✓
routerDirect..dule.js gzip 284 B 284 B ✓
withRouter-f..dule.js gzip 282 B 282 B ✓
Overall change 5.6 kB 5.6 kB ✓
Client Build Manifests
vercel/next.js canary Timer/next.js hotfix/upgrade-use-subscription Change
_buildManifest.js gzip 321 B 321 B ✓
_buildManife..dule.js gzip 330 B 330 B ✓
Overall change 651 B 651 B ✓
Serverless bundles Overall increase ⚠️
vercel/next.js canary Timer/next.js hotfix/upgrade-use-subscription Change
_error.js 916 kB 916 kB ⚠️ +4 B
404.html 4.61 kB 4.61 kB ✓
hooks.html 3.86 kB 3.86 kB ✓
index.js 916 kB 916 kB ⚠️ +4 B
link.js 974 kB 974 kB ⚠️ +4 B
routerDirect.js 967 kB 967 kB ⚠️ +4 B
withRouter.js 967 kB 967 kB ⚠️ +4 B
Overall change 4.75 MB 4.75 MB ⚠️ +20 B
Commit: e9bce15

@kodiakhq kodiakhq bot merged commit 67494bd into vercel:canary Nov 12, 2020
@Timer Timer deleted the hotfix/upgrade-use-subscription branch November 12, 2020 05:56
@vercel vercel locked as resolved and limited conversation to collaborators Jan 29, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ijjk ijjk ijjk approved these changes

@lfades lfades Awaiting requested review from lfades

@timneutkens timneutkens Awaiting requested review from timneutkens timneutkens is a code owner

Assignees
No one assigned
Labels
type: next
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Next.js v10.0.0 forces React v17 to be installed
2 participants
@Timer @ijjk