Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Call res.write('') inside apiRes.redirect() helper to prevent an edge case #20461

Merged
merged 3 commits into from Jan 4, 2021
Merged

Call res.write('') inside apiRes.redirect() helper to prevent an edge case #20461

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
77fc25d
Call res.write('') inside apiRes.redirect() helper
kachkaev Dec 24, 2020
b834f39
Merge branch 'canary' into prevent-edge-case-in-redirect
kachkaev Jan 3, 2021
33f6bff
Merge branch 'canary' into prevent-edge-case-in-redirect
kodiakhq[bot] Jan 4, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 3 additions & 1 deletion packages/next/next-server/server/api-utils.ts
View file
Open in desktop
Expand Up @@ -212,7 +212,9 @@ export function redirect(
`Invalid redirect arguments. Please use a single argument URL, e.g. res.redirect('/destination') or use a status code and URL, e.g. res.redirect(307, '/destination').`
)
}
res.writeHead(statusOrUrl, { Location: url }).end()
res.writeHead(statusOrUrl, { Location: url })
res.write('')
res.end()
return res
}

Expand Down