Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade Tailwindcss to 2.0.2 #20517

Merged
merged 2 commits into from Dec 28, 2020
Merged

Upgrade Tailwindcss to 2.0.2 #20517

merged 2 commits into from Dec 28, 2020

Conversation

awareness481
Copy link
Contributor

Normally I wouldn't make a PR for a minor version upgrade, but the 2.0.2 version contains some important performance improvements.
tailwindlabs/tailwindcss#3032

@awareness481
Upgrade Tailwindcss to 2.0.2
e2e5b1c 
Normally I wouldn't make a PR for a minor version upgrade, but the 2.0.2 contains some performance improvements.
tailwindlabs/tailwindcss#3032
@ijjk ijjk added the examples Issue/PR related to examples label Dec 27, 2020
@vercel vercel bot temporarily deployed to Preview December 27, 2020 19:23 Inactive
@ijjk
Copy link
Member

ijjk commented Dec 27, 2020

Stats from current PR

Default Server Mode (Increase detected ⚠️)
General
vercel/next.js canary awareness481/next.js patch-1 Change
buildDuration 8.9s 9s ⚠️ +93ms
nodeModulesSize 82.6 MB 82.6 MB ✓
Page Load Tests Overall increase ✓
vercel/next.js canary awareness481/next.js patch-1 Change
/ failed reqs 0 0 ✓
/ total time (seconds) 1.753 1.723 -0.03
/ avg req/sec 1426.36 1450.7 +24.34
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.12 1.115 -0.01
/error-in-render avg req/sec 2231.4 2242.86 +11.46
Client Bundles (main, webpack, commons)
vercel/next.js canary awareness481/next.js patch-1 Change
677f882d2ed8..5e70.js gzip 12.8 kB 12.8 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-e0d2962..b163.js gzip 6.56 kB 6.56 kB ✓
webpack-95c2..e870.js gzip 751 B 751 B ✓
Overall change 59 kB 59 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary awareness481/next.js patch-1 Change
polyfills-d3..23f6.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary awareness481/next.js patch-1 Change
_app-0d19cb6..5497.js gzip 1.28 kB 1.28 kB ✓
_error-85785..a9f3.js gzip 3.44 kB 3.44 kB ✓
hooks-42456f..0c06.js gzip 887 B 887 B ✓
index-8081ce..e44f.js gzip 227 B 227 B ✓
link-0ab9f83..fa00.js gzip 1.61 kB 1.61 kB ✓
routerDirect..c3d8.js gzip 303 B 303 B ✓
withRouter-0..a68e.js gzip 302 B 302 B ✓
Overall change 8.05 kB 8.05 kB ✓
Client Build Manifests
vercel/next.js canary awareness481/next.js patch-1 Change
_buildManifest.js gzip 323 B 323 B ✓
Overall change 323 B 323 B ✓
Rendered Page Sizes
vercel/next.js canary awareness481/next.js patch-1 Change
index.html gzip 612 B 612 B ✓
link.html gzip 620 B 620 B ✓
withRouter.html gzip 607 B 607 B ✓
Overall change 1.84 kB 1.84 kB ✓
Serverless Mode
General
vercel/next.js canary awareness481/next.js patch-1 Change
buildDuration 10.5s 10.6s ⚠️ +86ms
nodeModulesSize 82.6 MB 82.6 MB ✓
Client Bundles (main, webpack, commons)
vercel/next.js canary awareness481/next.js patch-1 Change
677f882d2ed8..5e70.js gzip 12.8 kB 12.8 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-e0d2962..b163.js gzip 6.56 kB 6.56 kB ✓
webpack-95c2..e870.js gzip 751 B 751 B ✓
Overall change 59 kB 59 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary awareness481/next.js patch-1 Change
polyfills-d3..23f6.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary awareness481/next.js patch-1 Change
_app-0d19cb6..5497.js gzip 1.28 kB 1.28 kB ✓
_error-85785..a9f3.js gzip 3.44 kB 3.44 kB ✓
hooks-42456f..0c06.js gzip 887 B 887 B ✓
index-8081ce..e44f.js gzip 227 B 227 B ✓
link-0ab9f83..fa00.js gzip 1.61 kB 1.61 kB ✓
routerDirect..c3d8.js gzip 303 B 303 B ✓
withRouter-0..a68e.js gzip 302 B 302 B ✓
Overall change 8.05 kB 8.05 kB ✓
Client Build Manifests
vercel/next.js canary awareness481/next.js patch-1 Change
_buildManifest.js gzip 323 B 323 B ✓
Overall change 323 B 323 B ✓
Serverless bundles
vercel/next.js canary awareness481/next.js patch-1 Change
_error.js 1 MB 1 MB ✓
404.html 2.67 kB 2.67 kB ✓
hooks.html 1.92 kB 1.92 kB ✓
index.js 1 MB 1 MB ✓
link.js 1.06 MB 1.06 MB ✓
routerDirect.js 1.05 MB 1.05 MB ✓
withRouter.js 1.05 MB 1.05 MB ✓
Overall change 5.16 MB 5.16 MB ✓
Commit: e2e5b1c

Timer
Timer approved these changes Dec 28, 2020
View reviewed changes
Copy link
Member

@Timer Timer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@vercel vercel bot temporarily deployed to Preview December 28, 2020 17:18 Inactive
@ijjk
Copy link
Member

ijjk commented Dec 28, 2020

Stats from current PR

Default Server Mode (Decrease detected ✓)
General
vercel/next.js canary awareness481/next.js patch-1 Change
buildDuration 8.8s 8.9s ⚠️ +138ms
nodeModulesSize 82.6 MB 82.6 MB ✓
Page Load Tests Overall decrease ⚠️
vercel/next.js canary awareness481/next.js patch-1 Change
/ failed reqs 0 0 ✓
/ total time (seconds) 1.784 1.76 -0.02
/ avg req/sec 1401.49 1420.76 +19.27
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.117 1.144 ⚠️ +0.03
/error-in-render avg req/sec 2238.49 2186.19 ⚠️ -52.3
Client Bundles (main, webpack, commons)
vercel/next.js canary awareness481/next.js patch-1 Change
677f882d2ed8..5e70.js gzip 12.8 kB 12.8 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-e0d2962..b163.js gzip 6.56 kB 6.56 kB ✓
webpack-95c2..e870.js gzip 751 B 751 B ✓
Overall change 59 kB 59 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary awareness481/next.js patch-1 Change
polyfills-d3..23f6.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary awareness481/next.js patch-1 Change
_app-0d19cb6..5497.js gzip 1.28 kB 1.28 kB ✓
_error-85785..a9f3.js gzip 3.44 kB 3.44 kB ✓
hooks-42456f..0c06.js gzip 887 B 887 B ✓
index-8081ce..e44f.js gzip 227 B 227 B ✓
link-0ab9f83..fa00.js gzip 1.61 kB 1.61 kB ✓
routerDirect..c3d8.js gzip 303 B 303 B ✓
withRouter-0..a68e.js gzip 302 B 302 B ✓
Overall change 8.05 kB 8.05 kB ✓
Client Build Manifests
vercel/next.js canary awareness481/next.js patch-1 Change
_buildManifest.js gzip 323 B 323 B ✓
Overall change 323 B 323 B ✓
Rendered Page Sizes
vercel/next.js canary awareness481/next.js patch-1 Change
index.html gzip 612 B 612 B ✓
link.html gzip 620 B 620 B ✓
withRouter.html gzip 607 B 607 B ✓
Overall change 1.84 kB 1.84 kB ✓
Serverless Mode
General
vercel/next.js canary awareness481/next.js patch-1 Change
buildDuration 10.4s 10.5s ⚠️ +144ms
nodeModulesSize 82.6 MB 82.6 MB ✓
Client Bundles (main, webpack, commons)
vercel/next.js canary awareness481/next.js patch-1 Change
677f882d2ed8..5e70.js gzip 12.8 kB 12.8 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-e0d2962..b163.js gzip 6.56 kB 6.56 kB ✓
webpack-95c2..e870.js gzip 751 B 751 B ✓
Overall change 59 kB 59 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary awareness481/next.js patch-1 Change
polyfills-d3..23f6.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary awareness481/next.js patch-1 Change
_app-0d19cb6..5497.js gzip 1.28 kB 1.28 kB ✓
_error-85785..a9f3.js gzip 3.44 kB 3.44 kB ✓
hooks-42456f..0c06.js gzip 887 B 887 B ✓
index-8081ce..e44f.js gzip 227 B 227 B ✓
link-0ab9f83..fa00.js gzip 1.61 kB 1.61 kB ✓
routerDirect..c3d8.js gzip 303 B 303 B ✓
withRouter-0..a68e.js gzip 302 B 302 B ✓
Overall change 8.05 kB 8.05 kB ✓
Client Build Manifests
vercel/next.js canary awareness481/next.js patch-1 Change
_buildManifest.js gzip 323 B 323 B ✓
Overall change 323 B 323 B ✓
Serverless bundles
vercel/next.js canary awareness481/next.js patch-1 Change
_error.js 1 MB 1 MB ✓
404.html 2.67 kB 2.67 kB ✓
hooks.html 1.92 kB 1.92 kB ✓
index.js 1 MB 1 MB ✓
link.js 1.06 MB 1.06 MB ✓
routerDirect.js 1.05 MB 1.05 MB ✓
withRouter.js 1.05 MB 1.05 MB ✓
Overall change 5.16 MB 5.16 MB ✓
Commit: 61680fe

@kodiakhq kodiakhq bot merged commit 556ab4f into vercel:canary Dec 28, 2020
@vercel vercel locked as resolved and limited conversation to collaborators Jan 29, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Timer Timer Timer approved these changes

@chibicode chibicode Awaiting requested review from chibicode

@ijjk ijjk Awaiting requested review from ijjk

@lfades lfades Awaiting requested review from lfades

@timneutkens timneutkens Awaiting requested review from timneutkens

Assignees
No one assigned
Labels
examples Issue/PR related to examples
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@awareness481 @ijjk @Timer