Remove upper limit on images.domains.length #20636

twogood · 2020-12-31T08:45:19Z

Large sites may have more than 50 external ímage sources, so better remove the limit than setting another arbitrary limit.

This will undo part of #18217

Large sites may have more than 50 external ímage sources, so better remove the limit than setting another arbitrary limit. This will undo part of #18217

ijjk · 2020-12-31T08:55:05Z

Stats from current PR

Default Server Mode (Increase detected ⚠️)

General Overall decrease ✓

	vercel/next.js canary	twogood/next.js remove-images-domains-length-limit	Change
buildDuration	10.8s	11.1s	⚠️ +210ms
nodeModulesSize	83 MB	83 MB	-717 B

Page Load Tests Overall increase ✓

	vercel/next.js canary	twogood/next.js remove-images-domains-length-limit	Change
/ failed reqs	0	0	✓
/ total time (seconds)	2.173	2.159	-0.01
/ avg req/sec	1150.32	1158.17	+7.85
/error-in-render failed reqs	0	0	✓
/error-in-render total time (seconds)	1.364	1.312	-0.05
/error-in-render avg req/sec	1832.3	1905.93	+73.63

Client Bundles (main, webpack, commons)

	vercel/next.js canary	twogood/next.js remove-images-domains-length-limit	Change
677f882d2ed8..8a8f.js gzip	12.8 kB	12.8 kB	✓
framework.HASH.js gzip	39 kB	39 kB	✓
main-5b13c61..eaca.js gzip	6.59 kB	6.59 kB	✓
webpack-7193..1446.js gzip	751 B	751 B	✓
Overall change	59.1 kB	59.1 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	twogood/next.js remove-images-domains-length-limit	Change
polyfills-67..b7d1.js gzip	31.2 kB	31.2 kB	✓
Overall change	31.2 kB	31.2 kB	✓

Client Pages

	vercel/next.js canary	twogood/next.js remove-images-domains-length-limit	Change
_app-6220e08..9a40.js gzip	1.28 kB	1.28 kB	✓
_error-4b0b5..2c91.js gzip	3.44 kB	3.44 kB	✓
hooks-5f309a..7282.js gzip	887 B	887 B	✓
index-57f580..c562.js gzip	227 B	227 B	✓
link-b862cd7..dba8.js gzip	1.64 kB	1.64 kB	✓
routerDirect..bd82.js gzip	303 B	303 B	✓
withRouter-2..e384.js gzip	302 B	302 B	✓
Overall change	8.08 kB	8.08 kB	✓

Client Build Manifests

	vercel/next.js canary	twogood/next.js remove-images-domains-length-limit	Change
_buildManifest.js gzip	321 B	321 B	✓
Overall change	321 B	321 B	✓

Rendered Page Sizes

	vercel/next.js canary	twogood/next.js remove-images-domains-length-limit	Change
index.html gzip	616 B	616 B	✓
link.html gzip	622 B	622 B	✓
withRouter.html gzip	610 B	610 B	✓
Overall change	1.85 kB	1.85 kB	✓

Serverless Mode (Decrease detected ✓)

General Overall decrease ✓

	vercel/next.js canary	twogood/next.js remove-images-domains-length-limit	Change
buildDuration	12.6s	13.2s	⚠️ +523ms
nodeModulesSize	83 MB	83 MB	-717 B

Client Bundles (main, webpack, commons)

	vercel/next.js canary	twogood/next.js remove-images-domains-length-limit	Change
677f882d2ed8..8a8f.js gzip	12.8 kB	12.8 kB	✓
framework.HASH.js gzip	39 kB	39 kB	✓
main-5b13c61..eaca.js gzip	6.59 kB	6.59 kB	✓
webpack-7193..1446.js gzip	751 B	751 B	✓
Overall change	59.1 kB	59.1 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	twogood/next.js remove-images-domains-length-limit	Change
polyfills-67..b7d1.js gzip	31.2 kB	31.2 kB	✓
Overall change	31.2 kB	31.2 kB	✓

Client Pages

	vercel/next.js canary	twogood/next.js remove-images-domains-length-limit	Change
_app-6220e08..9a40.js gzip	1.28 kB	1.28 kB	✓
_error-4b0b5..2c91.js gzip	3.44 kB	3.44 kB	✓
hooks-5f309a..7282.js gzip	887 B	887 B	✓
index-57f580..c562.js gzip	227 B	227 B	✓
link-b862cd7..dba8.js gzip	1.64 kB	1.64 kB	✓
routerDirect..bd82.js gzip	303 B	303 B	✓
withRouter-2..e384.js gzip	302 B	302 B	✓
Overall change	8.08 kB	8.08 kB	✓

Client Build Manifests

	vercel/next.js canary	twogood/next.js remove-images-domains-length-limit	Change
_buildManifest.js gzip	321 B	321 B	✓
Overall change	321 B	321 B	✓

Serverless bundles

	vercel/next.js canary	twogood/next.js remove-images-domains-length-limit	Change
_error.js	1 MB	1 MB	✓
404.html	2.67 kB	2.67 kB	✓
hooks.html	1.92 kB	1.92 kB	✓
index.js	1 MB	1 MB	✓
link.js	1.06 MB	1.06 MB	✓
routerDirect.js	1.05 MB	1.05 MB	✓
withRouter.js	1.05 MB	1.05 MB	✓
Overall change	5.17 MB	5.17 MB	✓

Commit: 1b9466c

twogood · 2020-12-31T09:01:06Z

@ijjk
Maybe this check is a bit too sensitive? :)

buildDuration | 10.8s | 11.1s | ⚠️ +210ms

ijjk · 2021-01-01T21:01:43Z

@twogood this stat is mainly for us to notice any large changes, small changes as noticed are more so due to differences in executing the apps in CI so aren't paid as much attention to.

twogood · 2021-01-01T23:00:20Z

@twogood this stat is mainly for us to notice any large changes, small changes as noticed are more so due to differences in executing the apps in CI so aren't paid as much attention to.

Sounds reasonable! :)

ijjk · 2021-01-01T23:09:02Z

Stats from current PR

Default Server Mode (Decrease detected ✓)

General Overall decrease ✓

	vercel/next.js canary	twogood/next.js remove-images-domains-length-limit	Change
buildDuration	10.4s	10.6s	⚠️ +153ms
nodeModulesSize	80.6 MB	80.6 MB	-717 B

Page Load Tests Overall decrease ⚠️

	vercel/next.js canary	twogood/next.js remove-images-domains-length-limit	Change
/ failed reqs	0	0	✓
/ total time (seconds)	2.032	2.112	⚠️ +0.08
/ avg req/sec	1230.25	1183.73	⚠️ -46.52
/error-in-render failed reqs	0	0	✓
/error-in-render total time (seconds)	1.29	1.31	⚠️ +0.02
/error-in-render avg req/sec	1938.7	1908.72	⚠️ -29.98

Client Bundles (main, webpack, commons)

	vercel/next.js canary	twogood/next.js remove-images-domains-length-limit	Change
677f882d2ed8..42af.js gzip	13 kB	13 kB	✓
framework.HASH.js gzip	39 kB	39 kB	✓
main-243368f..7063.js gzip	6.59 kB	6.59 kB	✓
webpack-50be..df5b.js gzip	751 B	751 B	✓
Overall change	59.3 kB	59.3 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	twogood/next.js remove-images-domains-length-limit	Change
polyfills-81..14d7.js gzip	31.2 kB	31.2 kB	✓
Overall change	31.2 kB	31.2 kB	✓

Client Pages

	vercel/next.js canary	twogood/next.js remove-images-domains-length-limit	Change
_app-b6fc6bc..222c.js gzip	1.28 kB	1.28 kB	✓
_error-cfcb6..fe1c.js gzip	3.44 kB	3.44 kB	✓
hooks-010c20..8411.js gzip	887 B	887 B	✓
index-bbee2f..528b.js gzip	227 B	227 B	✓
link-705099c..c35d.js gzip	1.64 kB	1.64 kB	✓
routerDirect..bf84.js gzip	303 B	303 B	✓
withRouter-a..5826.js gzip	302 B	302 B	✓
Overall change	8.08 kB	8.08 kB	✓

Client Build Manifests

	vercel/next.js canary	twogood/next.js remove-images-domains-length-limit	Change
_buildManifest.js gzip	323 B	323 B	✓
Overall change	323 B	323 B	✓

Rendered Page Sizes

	vercel/next.js canary	twogood/next.js remove-images-domains-length-limit	Change
index.html gzip	615 B	615 B	✓
link.html gzip	621 B	621 B	✓
withRouter.html gzip	607 B	607 B	✓
Overall change	1.84 kB	1.84 kB	✓

Serverless Mode (Decrease detected ✓)

General Overall decrease ✓

	vercel/next.js canary	twogood/next.js remove-images-domains-length-limit	Change
buildDuration	12.7s	12.7s	⚠️ +70ms
nodeModulesSize	80.6 MB	80.6 MB	-717 B

Client Bundles (main, webpack, commons)

	vercel/next.js canary	twogood/next.js remove-images-domains-length-limit	Change
677f882d2ed8..42af.js gzip	13 kB	13 kB	✓
framework.HASH.js gzip	39 kB	39 kB	✓
main-243368f..7063.js gzip	6.59 kB	6.59 kB	✓
webpack-50be..df5b.js gzip	751 B	751 B	✓
Overall change	59.3 kB	59.3 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	twogood/next.js remove-images-domains-length-limit	Change
polyfills-81..14d7.js gzip	31.2 kB	31.2 kB	✓
Overall change	31.2 kB	31.2 kB	✓

Client Pages

	vercel/next.js canary	twogood/next.js remove-images-domains-length-limit	Change
_app-b6fc6bc..222c.js gzip	1.28 kB	1.28 kB	✓
_error-cfcb6..fe1c.js gzip	3.44 kB	3.44 kB	✓
hooks-010c20..8411.js gzip	887 B	887 B	✓
index-bbee2f..528b.js gzip	227 B	227 B	✓
link-705099c..c35d.js gzip	1.64 kB	1.64 kB	✓
routerDirect..bf84.js gzip	303 B	303 B	✓
withRouter-a..5826.js gzip	302 B	302 B	✓
Overall change	8.08 kB	8.08 kB	✓

Client Build Manifests

	vercel/next.js canary	twogood/next.js remove-images-domains-length-limit	Change
_buildManifest.js gzip	323 B	323 B	✓
Overall change	323 B	323 B	✓

Serverless bundles

	vercel/next.js canary	twogood/next.js remove-images-domains-length-limit	Change
_error.js	1 MB	1 MB	✓
404.html	2.67 kB	2.67 kB	✓
hooks.html	1.92 kB	1.92 kB	✓
index.js	1 MB	1 MB	✓
link.js	1.06 MB	1.06 MB	✓
routerDirect.js	1.05 MB	1.05 MB	✓
withRouter.js	1.05 MB	1.05 MB	✓
Overall change	5.17 MB	5.17 MB	✓

Commit: af357ea

ijjk · 2021-01-04T13:56:05Z

Stats from current PR

Default Server Mode (Decrease detected ✓)

General Overall decrease ✓

	vercel/next.js canary	twogood/next.js remove-images-domains-length-limit	Change
buildDuration	10.5s	10.5s	⚠️ +33ms
nodeModulesSize	80.6 MB	80.6 MB	-717 B

Page Load Tests Overall decrease ⚠️

	vercel/next.js canary	twogood/next.js remove-images-domains-length-limit	Change
/ failed reqs	0	0	✓
/ total time (seconds)	2.1	2.174	⚠️ +0.07
/ avg req/sec	1190.61	1150.21	⚠️ -40.4
/error-in-render failed reqs	0	0	✓
/error-in-render total time (seconds)	1.354	1.368	⚠️ +0.01
/error-in-render avg req/sec	1846.03	1827.52	⚠️ -18.51

Client Bundles (main, webpack, commons)

	vercel/next.js canary	twogood/next.js remove-images-domains-length-limit	Change
677f882d2ed8..396f.js gzip	13 kB	13 kB	✓
framework.HASH.js gzip	39 kB	39 kB	✓
main-a9a6f0d..a96d.js gzip	6.59 kB	6.59 kB	✓
webpack-50be..df5b.js gzip	751 B	751 B	✓
Overall change	59.3 kB	59.3 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	twogood/next.js remove-images-domains-length-limit	Change
polyfills-81..14d7.js gzip	31.2 kB	31.2 kB	✓
Overall change	31.2 kB	31.2 kB	✓

Client Pages

	vercel/next.js canary	twogood/next.js remove-images-domains-length-limit	Change
_app-b6fc6bc..222c.js gzip	1.28 kB	1.28 kB	✓
_error-e2ffa..0f3f.js gzip	3.46 kB	3.46 kB	✓
hooks-010c20..8411.js gzip	887 B	887 B	✓
index-bbee2f..528b.js gzip	227 B	227 B	✓
link-705099c..c35d.js gzip	1.64 kB	1.64 kB	✓
routerDirect..bf84.js gzip	303 B	303 B	✓
withRouter-a..5826.js gzip	302 B	302 B	✓
Overall change	8.09 kB	8.09 kB	✓

Client Build Manifests

	vercel/next.js canary	twogood/next.js remove-images-domains-length-limit	Change
_buildManifest.js gzip	323 B	323 B	✓
Overall change	323 B	323 B	✓

Rendered Page Sizes

	vercel/next.js canary	twogood/next.js remove-images-domains-length-limit	Change
index.html gzip	615 B	615 B	✓
link.html gzip	621 B	621 B	✓
withRouter.html gzip	607 B	607 B	✓
Overall change	1.84 kB	1.84 kB	✓

Serverless Mode (Decrease detected ✓)

General Overall decrease ✓

	vercel/next.js canary	twogood/next.js remove-images-domains-length-limit	Change
buildDuration	12.4s	12.5s	⚠️ +88ms
nodeModulesSize	80.6 MB	80.6 MB	-717 B

Client Bundles (main, webpack, commons)

	vercel/next.js canary	twogood/next.js remove-images-domains-length-limit	Change
677f882d2ed8..396f.js gzip	13 kB	13 kB	✓
framework.HASH.js gzip	39 kB	39 kB	✓
main-a9a6f0d..a96d.js gzip	6.59 kB	6.59 kB	✓
webpack-50be..df5b.js gzip	751 B	751 B	✓
Overall change	59.3 kB	59.3 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	twogood/next.js remove-images-domains-length-limit	Change
polyfills-81..14d7.js gzip	31.2 kB	31.2 kB	✓
Overall change	31.2 kB	31.2 kB	✓

Client Pages

	vercel/next.js canary	twogood/next.js remove-images-domains-length-limit	Change
_app-b6fc6bc..222c.js gzip	1.28 kB	1.28 kB	✓
_error-e2ffa..0f3f.js gzip	3.46 kB	3.46 kB	✓
hooks-010c20..8411.js gzip	887 B	887 B	✓
index-bbee2f..528b.js gzip	227 B	227 B	✓
link-705099c..c35d.js gzip	1.64 kB	1.64 kB	✓
routerDirect..bf84.js gzip	303 B	303 B	✓
withRouter-a..5826.js gzip	302 B	302 B	✓
Overall change	8.09 kB	8.09 kB	✓

Client Build Manifests

	vercel/next.js canary	twogood/next.js remove-images-domains-length-limit	Change
_buildManifest.js gzip	323 B	323 B	✓
Overall change	323 B	323 B	✓

Serverless bundles

	vercel/next.js canary	twogood/next.js remove-images-domains-length-limit	Change
_error.js	1 MB	1 MB	✓
404.html	2.67 kB	2.67 kB	✓
hooks.html	1.92 kB	1.92 kB	✓
index.js	1 MB	1 MB	✓
link.js	1.06 MB	1.06 MB	✓
routerDirect.js	1.05 MB	1.05 MB	✓
withRouter.js	1.05 MB	1.05 MB	✓
Overall change	5.17 MB	5.17 MB	✓

Commit: 4730e92

royjosefsson · 2021-01-04T14:55:04Z

I like this pull request as a matter of fact. Either removing the upper limit or give the user ability to increase the limit 👍

@ijjk

timneutkens · 2021-01-25T15:28:23Z

These limits are intentionally added and should not be removed without a clear reason why. Please open a feature request first.

twogood · 2021-01-25T20:15:24Z

These limits are intentionally added and should not be removed without a clear reason why. Please open a feature request first.

Thank you for your feedback @timneutkens ! Can you point to the feature request that introduced this limit so we can start from there? I've only found the commit #18217 and issue #18122 but not the reasoning behind the limitation.

Cheers, David.

twogood added 2 commits December 31, 2020 09:37

Remove upper limit on images.domains.length

ea8b54b

Large sites may have more than 50 external ímage sources, so better remove the limit than setting another arbitrary limit. This will undo part of #18217

Also remove test case :)

86e62be

twogood requested review from ijjk, lfades, Timer and timneutkens as code owners December 31, 2020 08:45

ijjk added type: documentation type: next labels Dec 31, 2020

vercel bot temporarily deployed to Preview December 31, 2020 08:45 Inactive

Merge branch 'canary' into remove-images-domains-length-limit

1b9466c

vercel bot temporarily deployed to Preview December 31, 2020 08:45 Inactive

Merge branch 'canary' into remove-images-domains-length-limit

af357ea

Merge branch 'canary' into remove-images-domains-length-limit

4730e92

timneutkens closed this Jan 25, 2021

vercel locked as resolved and limited conversation to collaborators Jan 29, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Remove upper limit on images.domains.length #20636

Remove upper limit on images.domains.length #20636

twogood commented Dec 31, 2020

ijjk commented Dec 31, 2020

twogood commented Dec 31, 2020

ijjk commented Jan 1, 2021

twogood commented Jan 1, 2021

ijjk commented Jan 1, 2021

ijjk commented Jan 4, 2021

royjosefsson commented Jan 4, 2021

timneutkens commented Jan 25, 2021

twogood commented Jan 25, 2021

Remove upper limit on images.domains.length #20636

Remove upper limit on images.domains.length #20636

Conversation

twogood commented Dec 31, 2020

ijjk commented Dec 31, 2020

Stats from current PR

twogood commented Dec 31, 2020

ijjk commented Jan 1, 2021

twogood commented Jan 1, 2021

ijjk commented Jan 1, 2021

Stats from current PR

ijjk commented Jan 4, 2021

Stats from current PR

royjosefsson commented Jan 4, 2021

timneutkens commented Jan 25, 2021

twogood commented Jan 25, 2021