refactor: polyfill-nomodule handling #21418
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit removes unnecessary redirection that bundles `@next/polyfill-nomodule`, which is a first-party dependency.
This comment has been minimized.
This comment has been minimized.
10 tasks
|
Finished up this PR in #27596 |
timneutkens
added a commit
to timneutkens/next.js
that referenced
this pull request
Jul 29, 2021
Removes the extra webpack handling that was previously done, this ensures the file which is already minified and compiled does not get passed through minification again. Largely based on vercel#21418 Closes vercel#21418 Co-Authored-By: Joe Haddad <timer150@gmail.com>
kodiakhq bot
pushed a commit
that referenced
this pull request
Aug 13, 2021
…27596) Removes the extra webpack handling that was previously done, this ensures the file which is already minified and compiled does not get passed through minification again. Largely based on #21418 Closes #21418 The polyfill loading already has tests so no other changes are necessary. ## Bug - [ ] Related issues linked using `fixes #number` - [ ] Integration tests added - [ ] Errors have helpful link attached, see `contributing.md` ## Feature - [ ] Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR. - [ ] Related issues linked using `fixes #number` - [ ] Integration tests added - [ ] Documentation added - [ ] Telemetry added. In case of a feature if it's used or not. - [ ] Errors have helpful link attached, see `contributing.md` ## Documentation / Examples - [ ] Make sure the linting passes
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes unnecessary redirection that bundles
@next/polyfill-nomodule, which is a first-party dependency.