Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make sure all example packages has private: true #28008

Merged
merged 6 commits into from Aug 12, 2021
Merged

Make sure all example packages has private: true #28008

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
763d997
Update `check-examples.sh` to make sure all examples are `private: true`
oBusk Aug 12, 2021
bcdc4a3
Add `private: true` to example that lack it
oBusk Aug 12, 2021
5576cce
Merge branch 'canary' into examples-package-private
oBusk Aug 12, 2021
c60efa0
Merge branch 'canary' into examples-package-private
oBusk Aug 12, 2021
95572d3
Merge branch 'canary' into examples-package-private
ijjk Aug 12, 2021
09007be
Merge branch 'canary' into examples-package-private
kodiakhq[bot] Aug 12, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
1 change: 1 addition & 0 deletions examples/with-fauna/package.json
View file
Open in desktop
@@ -1,4 +1,5 @@
{
"private": true,
"name": "with-fauna",
"version": "1.0.0",
"license": "MIT",
Expand Down
2 changes: 1 addition & 1 deletion scripts/check-examples.sh
View file
Open in desktop
Expand Up @@ -3,7 +3,7 @@
for folder in examples/* ; do
cp -n packages/create-next-app/templates/default/gitignore $folder/.gitignore;
if [ -f "$folder/package.json" ]; then
cat $folder/package.json | jq '.license = "MIT"' | sponge $folder/package.json
cat $folder/package.json | jq '.license = "MIT" | .private = true' | sponge $folder/package.json
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It doesn't look like we are running this in CI currently, can we add this to the lint job here

next.js/.github/workflows/build_test_deploy.yml

Line 44 in 965a280

- run: ./scripts/check-manifests.js

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ijjk I was actually creating a separate PR for that! (#28009) Just so it'd be a bit clearer what each PR does 😄 Also, the job would fail until the other PRs that does various fixes to examples should probably be merged first so that everything is fine once the CI starts checking it

fi
done;

Expand Down