Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix next env vars injection in dynamic #28309

Merged
merged 3 commits into from Aug 20, 2021
Merged

Fix next env vars injection in dynamic #28309

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
627bc24
Fix next env vars injection in dynamic
huozhi Aug 19, 2021
defe400
Merge branch 'canary' into fix-dynamic-bundle
ijjk Aug 19, 2021
ba3b8ed
Merge branch 'canary' into fix-dynamic-bundle
huozhi Aug 20, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 3 additions & 1 deletion packages/next/build/webpack-config.ts
View file
Open in desktop
Expand Up @@ -742,7 +742,7 @@ export default async function getBaseWebpackConfig(
}

const notExternalModules =
/^(?:private-next-pages\/|next\/(?:dist\/pages\/|(?:app|document|link|image|constants)$)|string-hash$)/
/^(?:private-next-pages\/|next\/(?:dist\/pages\/|(?:app|document|link|image|constants|dynamic)$)|string-hash$)/
if (notExternalModules.test(request)) {
return
}
Expand Down Expand Up @@ -1490,6 +1490,8 @@ export default async function getBaseWebpackConfig(
reactProductionProfiling,
webpack: !!config.webpack,
hasRewrites,
reactRoot: config.experimental.reactRoot,
concurrentFeatures: config.experimental.concurrentFeatures,
})

const cache: any = {
Expand Down