Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing typescript property to NextConfig #28459

Merged
merged 1 commit into from Aug 24, 2021
Merged

Add missing typescript property to NextConfig #28459

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 2 additions & 2 deletions packages/next/build/index.ts
View file
Open in desktop
Expand Up @@ -176,7 +176,7 @@ export default async function build(
telemetry.record(events)
)

const ignoreTypeScriptErrors = Boolean(config.typescript?.ignoreBuildErrors)
const ignoreTypeScriptErrors = Boolean(config.typescript.ignoreBuildErrors)
const typeCheckStart = process.hrtime()
const typeCheckingSpinner = createSpinner({
prefixText: `${Log.prefixes.info} ${
Expand Down Expand Up @@ -216,7 +216,7 @@ export default async function build(
typeCheckingSpinner.stopAndPersist()
}

const ignoreESLint = Boolean(config.eslint?.ignoreDuringBuilds)
const ignoreESLint = Boolean(config.eslint.ignoreDuringBuilds)
const eslintCacheDir = path.join(cacheDir, 'eslint/')
if (!ignoreESLint && runLint) {
await nextBuildSpan
Expand Down
12 changes: 12 additions & 0 deletions packages/next/server/config-shared.ts
View file
Open in desktop
Expand Up @@ -29,10 +29,16 @@ export interface ESLintConfig {
ignoreDuringBuilds?: boolean
}

export interface TypeScriptConfig {
/** Do not run TypeScript during production builds (`next build`). */
ignoreBuildErrors?: boolean
}

export type NextConfig = { [key: string]: any } & {
i18n?: I18NConfig | null

eslint?: ESLintConfig
typescript?: TypeScriptConfig

headers?: () => Promise<Header[]>
rewrites?: () => Promise<
Expand Down Expand Up @@ -139,6 +145,12 @@ export const defaultConfig: NextConfig = {
env: {},
webpack: null,
webpackDevMiddleware: null,
eslint: {
ignoreDuringBuilds: false,
},
typescript: {
ignoreBuildErrors: false,
},
distDir: '.next',
cleanDistDir: true,
assetPrefix: '',
Expand Down