Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typings of dynamic suspense #28740

Merged
merged 3 commits into from Sep 2, 2021
Merged

Conversation

huozhi
Copy link
Member

@huozhi huozhi commented Sep 2, 2021

ijjk
ijjk previously approved these changes Sep 2, 2021
@ijjk

This comment has been minimized.

@huozhi huozhi requested a review from ijjk September 2, 2021 14:54
styfle
styfle previously approved these changes Sep 2, 2021
@huozhi
Copy link
Member Author

huozhi commented Sep 2, 2021

dimiss review shortly to add a test

@huozhi huozhi marked this pull request as draft September 2, 2021 14:59
@huozhi huozhi dismissed stale reviews from styfle and ijjk via 9acb30d September 2, 2021 15:06
@huozhi huozhi marked this pull request as ready for review September 2, 2021 15:06
@huozhi huozhi requested a review from styfle September 2, 2021 15:15
@ijjk

This comment has been minimized.

@ijjk
Copy link
Member

ijjk commented Sep 2, 2021

Stats from current PR

Default Build (Decrease detected ✓)
General Overall increase ⚠️
vercel/next.js canary huozhi/next.js fix/dynamic-typings Change
buildDuration 12.9s 12.9s ⚠️ +8ms
buildDurationCached 3.3s 3.3s -48ms
nodeModulesSize 49.1 MB 49.1 MB ⚠️ +21 B
Page Load Tests Overall decrease ⚠️
vercel/next.js canary huozhi/next.js fix/dynamic-typings Change
/ failed reqs 0 0
/ total time (seconds) 2.51 2.621 ⚠️ +0.11
/ avg req/sec 995.86 953.74 ⚠️ -42.12
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.348 1.435 ⚠️ +0.09
/error-in-render avg req/sec 1854.68 1741.94 ⚠️ -112.74
Client Bundles (main, webpack, commons)
vercel/next.js canary huozhi/next.js fix/dynamic-typings Change
745.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42.2 kB 42.2 kB
main-HASH.js gzip 23.3 kB 23.3 kB
webpack-HASH.js gzip 1.45 kB 1.45 kB
Overall change 67.2 kB 67.2 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary huozhi/next.js fix/dynamic-typings Change
polyfills-a4..dd70.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary huozhi/next.js fix/dynamic-typings Change
_app-HASH.js gzip 979 B 979 B
_error-HASH.js gzip 194 B 194 B
amp-HASH.js gzip 312 B 312 B
css-HASH.js gzip 329 B 329 B
dynamic-HASH.js gzip 2.67 kB 2.67 kB
head-HASH.js gzip 351 B 351 B
hooks-HASH.js gzip 918 B 918 B
image-HASH.js gzip 4.14 kB 4.14 kB
index-HASH.js gzip 261 B 261 B
link-HASH.js gzip 1.66 kB 1.66 kB
routerDirect..HASH.js gzip 318 B 318 B
script-HASH.js gzip 387 B 387 B
withRouter-HASH.js gzip 320 B 320 B
bb14e60e810b..30f.css gzip 125 B 125 B
Overall change 13 kB 13 kB
Client Build Manifests
vercel/next.js canary huozhi/next.js fix/dynamic-typings Change
_buildManifest.js gzip 492 B 492 B
Overall change 492 B 492 B
Rendered Page Sizes
vercel/next.js canary huozhi/next.js fix/dynamic-typings Change
index.html gzip 539 B 539 B
link.html gzip 552 B 552 B
withRouter.html gzip 532 B 532 B
Overall change 1.62 kB 1.62 kB

Webpack 4 Mode (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary huozhi/next.js fix/dynamic-typings Change
buildDuration 10.3s 10.5s ⚠️ +142ms
buildDurationCached 4.3s 4.3s -22ms
nodeModulesSize 49.1 MB 49.1 MB ⚠️ +21 B
Page Load Tests Overall increase ✓
vercel/next.js canary huozhi/next.js fix/dynamic-typings Change
/ failed reqs 0 0
/ total time (seconds) 2.471 2.484 ⚠️ +0.01
/ avg req/sec 1011.78 1006.54 ⚠️ -5.24
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.364 1.338 -0.03
/error-in-render avg req/sec 1833.15 1868.3 +35.15
Client Bundles (main, webpack, commons)
vercel/next.js canary huozhi/next.js fix/dynamic-typings Change
16.HASH.js gzip 186 B 186 B
677f882d2ed8..HASH.js gzip 14.1 kB 14.1 kB
framework.HASH.js gzip 41.9 kB 41.9 kB
main-HASH.js gzip 10.7 kB 10.7 kB
webpack-HASH.js gzip 1.19 kB 1.19 kB
Overall change 68.1 kB 68.1 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary huozhi/next.js fix/dynamic-typings Change
polyfills-a4..dd70.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary huozhi/next.js fix/dynamic-typings Change
_app-HASH.js gzip 964 B 964 B
_error-HASH.js gzip 3.8 kB 3.8 kB
amp-HASH.js gzip 552 B 552 B
css-HASH.js gzip 333 B 333 B
dynamic-HASH.js gzip 2.87 kB 2.87 kB
head-HASH.js gzip 3.06 kB 3.06 kB
hooks-HASH.js gzip 924 B 924 B
index-HASH.js gzip 231 B 231 B
link-HASH.js gzip 1.64 kB 1.64 kB
routerDirect..HASH.js gzip 298 B 298 B
script-HASH.js gzip 3.03 kB 3.03 kB
withRouter-HASH.js gzip 295 B 295 B
30809af5c834..565.css gzip 125 B 125 B
Overall change 18.1 kB 18.1 kB
Client Build Manifests
vercel/next.js canary huozhi/next.js fix/dynamic-typings Change
_buildManifest.js gzip 500 B 500 B
Overall change 500 B 500 B
Rendered Page Sizes
vercel/next.js canary huozhi/next.js fix/dynamic-typings Change
index.html gzip 584 B 584 B
link.html gzip 597 B 597 B
withRouter.html gzip 579 B 579 B
Overall change 1.76 kB 1.76 kB
Commit: 3c0823f

@kodiakhq kodiakhq bot merged commit 7f09df3 into vercel:canary Sep 2, 2021
@huozhi huozhi deleted the fix/dynamic-typings branch October 21, 2021 16:29
@vercel vercel locked as resolved and limited conversation to collaborators Jan 27, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants