Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use webpack resolve with nft #29342

Merged
merged 3 commits into from
Sep 24, 2021
Merged

Conversation

ijjk
Copy link
Member

@ijjk ijjk commented Sep 23, 2021

This is a follow-up to #29341 to add using the webpack resolver while tracing for better performance.

@ijjk ijjk added created-by: Next.js team PRs by the Next.js team type: next labels Sep 23, 2021
@ijjk

This comment has been minimized.

@ijjk

This comment has been minimized.

@ijjk
Copy link
Member Author

ijjk commented Sep 23, 2021

Stats from current PR

Default Build (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary ijjk/next.js update/nft-webpack-resolve Change
buildDuration 14.8s 15s ⚠️ +242ms
buildDurationCached 3.8s 3.8s -67ms
nodeModulesSize 182 MB 182 MB ⚠️ +7.28 kB
Page Load Tests Overall increase ✓
vercel/next.js canary ijjk/next.js update/nft-webpack-resolve Change
/ failed reqs 0 0
/ total time (seconds) 3.244 3.198 -0.05
/ avg req/sec 770.69 781.7 +11.01
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.615 1.619 0
/error-in-render avg req/sec 1547.58 1544.59 ⚠️ -2.99
Client Bundles (main, webpack, commons)
vercel/next.js canary ijjk/next.js update/nft-webpack-resolve Change
779.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42.2 kB 42.2 kB
main-HASH.js gzip 26.8 kB 26.8 kB
webpack-HASH.js gzip 1.45 kB 1.45 kB
Overall change 70.6 kB 70.6 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary ijjk/next.js update/nft-webpack-resolve Change
polyfills-a4..dd70.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary ijjk/next.js update/nft-webpack-resolve Change
_app-HASH.js gzip 977 B 977 B
_error-HASH.js gzip 194 B 194 B
amp-HASH.js gzip 311 B 311 B
css-HASH.js gzip 328 B 328 B
dynamic-HASH.js gzip 2.67 kB 2.67 kB
head-HASH.js gzip 351 B 351 B
hooks-HASH.js gzip 918 B 918 B
image-HASH.js gzip 4.14 kB 4.14 kB
index-HASH.js gzip 260 B 260 B
link-HASH.js gzip 1.66 kB 1.66 kB
routerDirect..HASH.js gzip 320 B 320 B
script-HASH.js gzip 386 B 386 B
withRouter-HASH.js gzip 319 B 319 B
bb14e60e810b..30f.css gzip 125 B 125 B
Overall change 13 kB 13 kB
Client Build Manifests
vercel/next.js canary ijjk/next.js update/nft-webpack-resolve Change
_buildManifest.js gzip 493 B 493 B
Overall change 493 B 493 B
Rendered Page Sizes
vercel/next.js canary ijjk/next.js update/nft-webpack-resolve Change
index.html gzip 538 B 538 B
link.html gzip 550 B 550 B
withRouter.html gzip 532 B 532 B
Overall change 1.62 kB 1.62 kB

Default Build with SWC (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary ijjk/next.js update/nft-webpack-resolve Change
buildDuration 7.6s 7.8s ⚠️ +137ms
buildDurationCached 3.8s 3.8s -34ms
nodeModulesSize 182 MB 182 MB ⚠️ +7.28 kB
Page Load Tests Overall increase ✓
vercel/next.js canary ijjk/next.js update/nft-webpack-resolve Change
/ failed reqs 0 0
/ total time (seconds) 3.245 3.194 -0.05
/ avg req/sec 770.37 782.83 +12.46
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.639 1.573 -0.07
/error-in-render avg req/sec 1525.28 1588.91 +63.63
Client Bundles (main, webpack, commons)
vercel/next.js canary ijjk/next.js update/nft-webpack-resolve Change
675-HASH.js gzip 13.8 kB 13.8 kB
770.HASH.js gzip 178 B 178 B
framework-HASH.js gzip 50.7 kB 50.7 kB
main-HASH.js gzip 34.7 kB 34.7 kB
webpack-HASH.js gzip 1.65 kB 1.65 kB
Overall change 101 kB 101 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary ijjk/next.js update/nft-webpack-resolve Change
polyfills-a4..dd70.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary ijjk/next.js update/nft-webpack-resolve Change
_app-HASH.js gzip 1.32 kB 1.32 kB
_error-HASH.js gzip 180 B 180 B
amp-HASH.js gzip 315 B 315 B
css-HASH.js gzip 331 B 331 B
dynamic-HASH.js gzip 2.8 kB 2.8 kB
head-HASH.js gzip 356 B 356 B
hooks-HASH.js gzip 637 B 637 B
image-HASH.js gzip 573 B 573 B
index-HASH.js gzip 262 B 262 B
link-HASH.js gzip 2.2 kB 2.2 kB
routerDirect..HASH.js gzip 326 B 326 B
script-HASH.js gzip 393 B 393 B
withRouter-HASH.js gzip 322 B 322 B
bb14e60e810b..30f.css gzip 125 B 125 B
Overall change 10.1 kB 10.1 kB
Client Build Manifests
vercel/next.js canary ijjk/next.js update/nft-webpack-resolve Change
_buildManifest.js gzip 511 B 511 B
Overall change 511 B 511 B
Rendered Page Sizes
vercel/next.js canary ijjk/next.js update/nft-webpack-resolve Change
index.html gzip 538 B 538 B
link.html gzip 552 B 552 B
withRouter.html gzip 532 B 532 B
Overall change 1.62 kB 1.62 kB
Commit: 5b9b34e

@ijjk ijjk marked this pull request as ready for review September 24, 2021 00:45
@kodiakhq kodiakhq bot merged commit a986581 into vercel:canary Sep 24, 2021
@ijjk ijjk deleted the update/nft-webpack-resolve branch September 24, 2021 14:04
@vercel vercel locked as resolved and limited conversation to collaborators Jan 27, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants