Added more examples to Response Helpers page #29462
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
molebox
requested review from
huozhi,
ijjk,
leerob,
lfades,
padmaia,
shuding,
styfle and
timneutkens
as code owners
styfle
reviewed
Sep 28, 2021
styfle
reviewed
Sep 28, 2021
styfle
reviewed
Sep 28, 2021
styfle
reviewed
Sep 28, 2021
styfle
reviewed
Sep 28, 2021
styfle
reviewed
Sep 28, 2021
This comment has been minimized.
This comment has been minimized.
Co-authored-by: Steven <steven@ceriously.com>
Co-authored-by: Steven <steven@ceriously.com>
Co-authored-by: Steven <steven@ceriously.com>
Co-authored-by: Steven <steven@ceriously.com>
Co-authored-by: Steven <steven@ceriously.com>
I didnt! I installed the dpes and they appeared. I wasnt sure what the deal was as its the first time ive run the project. Whats the play here? |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
…rcel/next.js into refactor-reponse-helpers-page
|
This should be good to go now @timneutkens |
ijjk
reviewed
Oct 13, 2021
ijjk
reviewed
Oct 13, 2021
ijjk
reviewed
Oct 13, 2021
ijjk
reviewed
Oct 13, 2021
Co-authored-by: JJ Kasper <jj@jjsweb.site>
Co-authored-by: JJ Kasper <jj@jjsweb.site>
Co-authored-by: JJ Kasper <jj@jjsweb.site>
Co-authored-by: JJ Kasper <jj@jjsweb.site>
ijjk
reviewed
Oct 13, 2021
ijjk
approved these changes
Oct 13, 2021
barrymay
reviewed
Oct 14, 2021
| The included helpers are: | ||
|
|
||
| - `res.status(code)` - A function to set the status code. `code` must be a valid [HTTP status code](https://en.wikipedia.org/wiki/List_of_HTTP_status_codes) | ||
| - `res.json(body)` - Sends a JSON response. `body` must be a [serialiazable object](https://developer.mozilla.org/en-US/docs/Glossary/Serialization) |
There was a problem hiding this comment.
Hi - wanted to point out that serializable is spelled wrong here (it's wrong in current production as well)
There was a problem hiding this comment.
Good catch, opened PR here updating this #29899
1 task
kodiakhq bot
pushed a commit
that referenced
this pull request
Oct 14, 2021
Fixes typo per #29462 (comment) ## Documentation / Examples - [x] Make sure the linting passes
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug
contributing.mdFeature
fixes #numbercontributing.mdDocumentation / Examples